From: Josua Mayer <josua@solid-run.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Li Yang <leoyang.li@nxp.com>,
Philippe Schenker <philippe.schenker@toradex.com>,
Fabio Estevam <festevam@denx.de>,
Aishwarya Kothari <aishwarya.kothari@toradex.com>,
Marco Felsch <m.felsch@pengutronix.de>,
Tim Harvey <tharvey@gateworks.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Marek Vasut <marex@denx.de>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>
Subject: Re: [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board
Date: Sun, 1 Oct 2023 12:21:57 +0200 [thread overview]
Message-ID: <15d382c5-ad09-4532-ab30-7b19e8786d00@solid-run.com> (raw)
In-Reply-To: <20230924135111.GJ7231@dragon>
Hi Shawn,
Thank you for the review.
@all - some of you have received this email including HTML,
this is attempted resend as plain text ...
Am 24.09.23 um 15:51 schrieb Shawn Guo:
> On Fri, Aug 18, 2023 at 01:10:16PM +0200, Josua Mayer wrote:
>> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
>> index a750be13ace8..9448d2effd8a 100644
>> --- a/arch/arm64/boot/dts/freescale/Makefile
>> +++ b/arch/arm64/boot/dts/freescale/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>> dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
>> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-clearfog.dtb
> Out of alphabetical order.
Ack.
>> +
>> + led_sfp_at: led-sfp-at {
>> + gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>; /* PROC_IRQ5 */
>> + default-state = "off";
>> + };
> Have a newline between nodes.
Ack.
>> +&i2c2 {
> This label node seems out of alphabetical order.
Ack.
>> +&esdhc1 {
>> + status = "okay";
>> + bus-width = <8>;
>> + mmc-hs200-1_8v;
>> + mmc-hs400-1_8v;
> We usually have 'status' be the last property.
You are not the first to notice this, but somehow in each version I
forgot about changing it :(.
v6 will for sure put this status property in last place!
> Shawn
sincerely
Josua Mayer
prev parent reply other threads:[~2023-10-01 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 11:10 [PATCH v5 0/4] arm64: dts: freescale: Add support for LX2162 SoM & Clearfog Board Josua Mayer
2023-08-18 11:10 ` [PATCH v5 1/4] arm64: dts: lx2160a: describe the SerDes block #2 Josua Mayer
2023-09-17 14:33 ` Josua Mayer
2023-08-18 11:10 ` [PATCH v5 2/4] dt-bindings: net: dpaa2 mac: add phys property Josua Mayer
2023-08-18 11:10 ` [PATCH v5 3/4] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board Josua Mayer
2023-08-18 11:10 ` [PATCH v5 4/4] arm64: dts: freescale: Add support for LX2162 " Josua Mayer
2023-09-24 13:51 ` Shawn Guo
2023-10-01 10:21 ` Josua Mayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d382c5-ad09-4532-ab30-7b19e8786d00@solid-run.com \
--to=josua@solid-run.com \
--cc=aishwarya.kothari@toradex.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=frieder.schrempf@kontron.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=marcel.ziswiler@toradex.com \
--cc=marex@denx.de \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).