From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: pwm: Drop PWM reg dependency
Date: Sat, 27 Aug 2022 12:31:09 +0300 [thread overview]
Message-ID: <15d7c1a8-18b6-e2a7-e4c1-1cdad6f3604f@linaro.org> (raw)
In-Reply-To: <20220826123547.3392457-2-bryan.odonoghue@linaro.org>
On 26/08/2022 15:35, Bryan O'Donoghue wrote:
> Drop the reg dependency from the qcom PWM description.
>
> The PWM driver doesn't depend on the reg so we should drop the dependency
> and remove the pwm@reg from the nodename.
Driver is not really a sufficient reason. Based on
https://lore.kernel.org/all/CAA8EJppGS38aP7gyd1c3kNgraAVJDoqUef2cDfZpu2aL_iwW0g@mail.gmail.com/
reason could be:
The PWM node is not a separate device and is expected to be part of
parent SPMI PMIC node, thus it obtains the address space from the
parent. One IO address in "reg" is also not correct description because
LPG block maps to several regions.
>
> Fixes: e79a1385ab74 ("arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 +--
Patches should be split. One patchset, but two patches.
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> index 65cbc6dee545e..2a5bafe0660a0 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> @@ -92,6 +92,10 @@ properties:
> type: object
> $ref: /schemas/regulator/regulator.yaml#
>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-08-27 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 12:35 [PATCH v2 0/1] arm64: dts: qcom: pwm: Drop PWM reg dependency Bryan O'Donoghue
2022-08-26 12:35 ` [PATCH v2 1/1] " Bryan O'Donoghue
2022-08-27 9:31 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15d7c1a8-18b6-e2a7-e4c1-1cdad6f3604f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).