From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2389C43603 for ; Fri, 6 Dec 2019 16:02:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E2B42173E for ; Fri, 6 Dec 2019 16:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfLFQCB convert rfc822-to-8bit (ORCPT ); Fri, 6 Dec 2019 11:02:01 -0500 Received: from gloria.sntech.de ([185.11.138.130]:41988 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbfLFQCB (ORCPT ); Fri, 6 Dec 2019 11:02:01 -0500 Received: from p57b772b2.dip0.t-ipconnect.de ([87.183.114.178] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idG3K-0003JS-JN; Fri, 06 Dec 2019 17:01:58 +0100 From: Heiko Stuebner To: Miquel Raynal Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Paul Kocialkowski , Maxime Chevallier , Thomas Petazzoni Subject: Re: [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Date: Fri, 06 Dec 2019 17:01:58 +0100 Message-ID: <1601413.9zADmrJRdp@phil> In-Reply-To: <20191206165250.5877dec8@xps13> References: <20191206154247.28057-1-miquel.raynal@bootlin.com> <3285991.EbEXlA3CnX@phil> <20191206165250.5877dec8@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Freitag, 6. Dezember 2019, 16:52:50 CET schrieb Miquel Raynal: > Hi Heiko, > > Heiko Stuebner wrote on Fri, 06 Dec 2019 16:48:00 > +0100: > > > Hi Miquel, > > > > Am Freitag, 6. Dezember 2019, 16:42:47 CET schrieb Miquel Raynal: > > > PMIC interrupt can be active high or active low depending on BIT(1) of > > > the GPIO_INT_CFG pin. The default is 0x1, which means active > > > high. Change the polarity in the device tree to reflect the default > > > state. > > > > > > Without this and with the current code base, the interrupt never stops > > > triggering while the MFD driver does not see anything to > > > check/clear/mask so after 100000 spurious IRQs, the kernel simply > > > desactivates the interrupt: > > > > > > irq 36: nobody cared (try booting with the "irqpoll" option) > > > [...] > > > handlers: > > > [<(____ptrval____)>] irq_default_primary_handler threaded > > > [<(____ptrval____)>] regmap_irq_thread > > > Disabling IRQ #36 > > > > > > Signed-off-by: Miquel Raynal > > > > *coughs slightly* > > > > mfd: rk808: Set RK817 interrupt polarity to low > > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/drivers/mfd/rk808.c?h=for-mfd-next&id=dbd16ef53487084816a20f662423ab543a75fc83 > > > > Should be in the current merge window already I guess ;-) > > This time I swear I checked your tree. But this time we did not ended > with the same fix so I missed this one *again* :) No worries ... I guess I should check where I hid additional patches ;-) So right now px30 stuff is in the trees: - mine - mfd - phy (first round of dsi phy, refinement pending on the list) - nvmem (for the otp controller) - drm (drm/rockchip: vop: add the definition of dclk_pol) - clk and pending on lists: - drm (dsi support + timings) - phy (refinement as mentioned above) not submitted yet but planning to get this done this weekend: - panel driver for px30-evb - dsi devicetree stuff Hope this helps a bit to prevent more double work ;-) Heiko > > > > > Having this consistent over all rk8xx seemed nicer. > > I'm fine with this approach too. > > Thanks, > Miquèl