Re: [PATCH v2 5/5] dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682 document

[Jiaxin Yu <jiaxin.yu@mediatek.com>]

On Wed, 2020-10-21 at 09:56 -0500, Rob Herring wrote:
> On Wed, Oct 21, 2020 at 04:53:55PM +0800, Jiaxin Yu wrote:
> > This patch adds document for the machine board with mt6358, rt1015
> > and rt5682.
> > 
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> >  .../sound/mt8192-mt6359-rt1015-rt5682.yaml    | 42 +++++++++++++++++++
> >  1 file changed, 42 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > new file mode 100644
> > index 0000000000000..4c39e88906fc1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause)
> 
> GPL-2.0-only
> 
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver
> > +
> > +maintainers:
> > +   - Jiaxin Yu <jiaxin.yu@mediatek.com>
> > +   - Shane Chien <shane.chien@mediatek.com>
> > +
> > +description:
> > +  This binding describes the MT8192 sound card.
> > +
> > +properties:
> > +  compatible:
> > +      const: mediatek,mt8192_mt6359_rt1015_rt5682
> 
> I still don't think this is the right way to do this.
> 
Dear Rob,
This nomencalture is extended to the MTK mt8183/mt8173.
And we think it's better to maintain multiple boards, but
the disadvantage is need to write one more machine drivers.

> > +
> > +  mediatek,platform:
> > +    $ref: "/schemas/types.yaml#/definitions/phandle"
> > +    description: The phandle of MT8192 ASoC platform.
> 
> I still don't understand what this is.
> 

This property will assign to 'snd_soc_dai_link->platforms->of_node'.
The value of 'mediatek,platform' here is &afe that is mt8192 platform
driver.
It will be resolved from a phandle property to a device_node pointer.

> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - mediatek,platform
> > +
> > +examples:
> > +  - |
> > +
> > +    sound: mt8192-sound {
> > +        compatible = "mediatek,mt8192-mt6359-rt1015-rt5682";
> > +        mediatek,platform = <&afe>;
> > +        pinctrl-names = "aud_clk_mosi_off",
> > +                        "aud_clk_mosi_on";
> > +        pinctrl-0 = <&aud_clk_mosi_off>;
> > +        pinctrl-1 = <&aud_clk_mosi_on>;
> > +    };
> > +
> > +...
> > -- 
> > 2.18.0