From: Hector Yuan <hector.yuan@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>, "Rob Herring" <robh+dt@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Maxime Ripard <mripard@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
"Stephen Boyd" <sboyd@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Dave Gerlach <d-gerlach@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wsd_upstream@mediatek.com>
Subject: Re: [PATCH v1] cpufreq: mediatek-hw: Add support for Mediatek cpufreq HW driver
Date: Mon, 26 Oct 2020 14:20:34 +0800 [thread overview]
Message-ID: <1603693234.20535.9.camel@mtkswgap22> (raw)
In-Reply-To: <20201023092720.qpws5wivqb4u6fwl@vireshk-i7>
On Fri, 2020-10-23 at 14:57 +0530, Viresh Kumar wrote:
> On 23-10-20, 17:08, Hector Yuan wrote:
> > On Fri, 2020-10-23 at 13:58 +0530, Viresh Kumar wrote:
> > > On 23-10-20, 16:24, Hector Yuan wrote:
> > > > This patchset includes 6 patches and depends on the MT6779 DTS patch[1] submitted by Hanks Chen.
> > > > The first 3 patches are for CPUFREQ HW driver and device tree binding, which are already sent before separately [2][3]. For binding part, I add a new patch to add property in cpu schema.
> > > > Besides, we add three more patches including EM power table, SVS CPU initialize, and cooling device.
> > >
> > > And even after so many versions of these you chose to name this V1. It
> > > is very difficult for reviewers to find time to review your stuff, and
> > > they expect some sort of summary from you on what exactly changed from
> > > last version and you also need to name the current version currently.
> > >
> > > This should have been V8 and you should have added a "V7->V8 diff:"
> > > section here, naming all the changes you did. Please send that as
> > > reply to this email, so I can see what really changed.
> > >
> > Hi, Viresh
> >
> > Sorry for your inconvenience.
> > #1~#3 is for cpufreq driver we have reviewed and the bindings which
> > separate freq domain to CPU schema.There is no change for the driver
> > itself.
> > 1. cpufreq: mediatek-hw: Add support for CPUFREQ HW
> > 2. dt-bindings: arm: cpus: Document 'mtk,freq-domain' property
> > 3. dt-bindings: cpufreq: add bindings for MediaTek cpufreq HW
> >
> > #4~#6 is for other CPU features, i.e. SVS [1]
> > 4. cpufreq: mediatek-hw: register EM power table
> > 5. cpufreq: mediatek-hw: Add SVS CPU initialization
> > 6. cpufreq: mediatek-hw: Add cooling dev flag
> >
> > I supposed that it could be more clean to separate #4~#6 in another
> > patchset.May I know is it okay to you? Or I should merge all of changes
> > into v8 like you mentioned? Thank you.
>
> Merge them all together and explain any special features (like SVS) in
> the commit log. It will also help in future when people want to
> understand your driver. Explain whatever is worth explaining there and
> is not straight forward.
>
> Thanks for the details.
>
OK, I will merge all changes in v8. And explain details in cover-letter.
Thank you.
next prev parent reply other threads:[~2020-10-26 6:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:24 [PATCH v1] cpufreq: mediatek-hw: Add support for Mediatek cpufreq HW driver Hector Yuan
2020-10-23 8:24 ` [PATCH v1 1/6] cpufreq: mediatek-hw: Add support for CPUFREQ HW Hector Yuan
2020-10-23 8:24 ` [PATCH v1 2/6] dt-bindings: arm: cpus: Document 'mtk,freq-domain' property Hector Yuan
2020-10-23 8:29 ` Viresh Kumar
2020-10-26 6:14 ` Hector Yuan
2020-10-23 16:20 ` Rob Herring
2020-10-26 6:12 ` Hector Yuan
2020-10-23 8:24 ` [PATCH v1 3/6] dt-bindings: cpufreq: add bindings for MediaTek cpufreq HW Hector Yuan
2020-10-23 8:35 ` Viresh Kumar
2020-10-26 6:17 ` Hector Yuan
2020-10-23 16:15 ` Rob Herring
2020-10-26 6:15 ` Hector Yuan
2020-10-23 8:24 ` [PATCH v1 4/6] cpufreq: mediatek-hw: register EM power table Hector Yuan
2020-10-23 8:24 ` [PATCH v1 5/6] cpufreq: mediatek-hw: Add SVS CPU initialization Hector Yuan
2020-10-23 8:37 ` Viresh Kumar
2020-10-23 8:24 ` [PATCH v1 6/6] cpufreq: mediatek-hw: Add cooling dev flag Hector Yuan
2020-10-23 8:28 ` [PATCH v1] cpufreq: mediatek-hw: Add support for Mediatek cpufreq HW driver Viresh Kumar
2020-10-23 9:08 ` Hector Yuan
2020-10-23 9:27 ` Viresh Kumar
2020-10-26 6:20 ` Hector Yuan [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-13 7:07 Hector Yuan
2020-08-06 12:18 Hector Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603693234.20535.9.camel@mtkswgap22 \
--to=hector.yuan@mediatek.com \
--cc=amit.kucheria@linaro.org \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mripard@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=ssantosh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).