* [PATCH v1] arm64: dts: sc7180: Add camera clock controller node
@ 2020-11-06 18:38 Taniya Das
2020-11-11 2:08 ` Doug Anderson
2020-11-11 4:47 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Taniya Das @ 2020-11-06 18:38 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Douglas Anderson, Stephen Boyd, Andy Gross, devicetree,
linux-arm-msm, linux-kernel, Taniya Das
Add the camera clock controller node supported on SC7180.
Signed-off-by: Taniya Das <tdas@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index f5ef2cb..e795dba 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -5,6 +5,7 @@
* Copyright (c) 2019, The Linux Foundation. All rights reserved.
*/
+#include <dt-bindings/clock/qcom,camcc-sc7180.h>
#include <dt-bindings/clock/qcom,dispcc-sc7180.h>
#include <dt-bindings/clock/qcom,gcc-sc7180.h>
#include <dt-bindings/clock/qcom,gpucc-sc7180.h>
@@ -2896,6 +2897,18 @@
qcom,bcm-voters = <&apps_bcm_voter>;
};
+ camcc: clock-controller@ad00000 {
+ compatible = "qcom,sc7180-camcc";
+ reg = <0 0x0ad00000 0 0x10000>;
+ clocks = <&rpmhcc RPMH_CXO_CLK>,
+ <&gcc GCC_CAMERA_AHB_CLK>,
+ <&gcc GCC_CAMERA_XO_CLK>;
+ clock-names = "bi_tcxo", "iface", "xo";
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ #power-domain-cells = <1>;
+ };
+
mdss: mdss@ae00000 {
compatible = "qcom,sc7180-mdss";
reg = <0 0x0ae00000 0 0x1000>;
--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] arm64: dts: sc7180: Add camera clock controller node
2020-11-06 18:38 [PATCH v1] arm64: dts: sc7180: Add camera clock controller node Taniya Das
@ 2020-11-11 2:08 ` Doug Anderson
2020-11-11 4:47 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-11-11 2:08 UTC (permalink / raw)
To: Taniya Das
Cc: Rob Herring, Bjorn Andersson, Stephen Boyd, Andy Gross,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm, LKML
Hi,
On Fri, Nov 6, 2020 at 10:39 AM Taniya Das <tdas@codeaurora.org> wrote:
>
> Add the camera clock controller node supported on SC7180.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
This matches the bindings, which has landed in the clock tree. It's
also sorted properly. Thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64: dts: sc7180: Add camera clock controller node
2020-11-06 18:38 [PATCH v1] arm64: dts: sc7180: Add camera clock controller node Taniya Das
2020-11-11 2:08 ` Doug Anderson
@ 2020-11-11 4:47 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-11-11 4:47 UTC (permalink / raw)
To: Taniya Das
Cc: Rob Herring, Douglas Anderson, Stephen Boyd, Andy Gross,
devicetree, linux-arm-msm, linux-kernel
On Fri 06 Nov 12:38 CST 2020, Taniya Das wrote:
> Add the camera clock controller node supported on SC7180.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index f5ef2cb..e795dba 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -5,6 +5,7 @@
> * Copyright (c) 2019, The Linux Foundation. All rights reserved.
> */
>
> +#include <dt-bindings/clock/qcom,camcc-sc7180.h>
Applied the patch without this include, as it was not available in the
tag I branched off my 5.11 branch off.
Regards,
Bjorn
> #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
> #include <dt-bindings/clock/qcom,gcc-sc7180.h>
> #include <dt-bindings/clock/qcom,gpucc-sc7180.h>
> @@ -2896,6 +2897,18 @@
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> + camcc: clock-controller@ad00000 {
> + compatible = "qcom,sc7180-camcc";
> + reg = <0 0x0ad00000 0 0x10000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_CAMERA_AHB_CLK>,
> + <&gcc GCC_CAMERA_XO_CLK>;
> + clock-names = "bi_tcxo", "iface", "xo";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +
> mdss: mdss@ae00000 {
> compatible = "qcom,sc7180-mdss";
> reg = <0 0x0ae00000 0 0x1000>;
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-11 4:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-06 18:38 [PATCH v1] arm64: dts: sc7180: Add camera clock controller node Taniya Das
2020-11-11 2:08 ` Doug Anderson
2020-11-11 4:47 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).