devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: mt8173: Add afe device node
@ 2015-07-09  3:32 Koro Chen
       [not found] ` <1436412725-55129-1-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2015-07-17 21:42 ` Matthias Brugger
  0 siblings, 2 replies; 4+ messages in thread
From: Koro Chen @ 2015-07-09  3:32 UTC (permalink / raw)
  To: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w
  Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ, djkurtz-F7+t8E8rja9g9hUCZPvPmw,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Koro Chen

This adds afe (audio front end) device node to the MT8173 dtsi file.

Signed-off-by: Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
This patch is based on Matthias's tree:
https://github.com/mbgg/linux-mediatek
branch: v4.2-next/arm64

Changes since v1:
- change node name to afe: audio-controller@11220000
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index 0696f8f..ce9255a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -14,6 +14,7 @@
 #include <dt-bindings/clock/mt8173-clk.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/mt8173-power.h>
 #include <dt-bindings/reset-controller/mt8173-resets.h>
 #include "mt8173-pinfunc.h"
 
@@ -393,6 +394,37 @@
 			#size-cells = <0>;
 			status = "disabled";
 		};
+
+		afe: audio-controller@11220000  {
+			compatible = "mediatek,mt8173-afe-pcm";
+			reg = <0 0x11220000 0 0x1000>;
+			interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
+			power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
+			clocks = <&infracfg CLK_INFRA_AUDIO>,
+				 <&topckgen CLK_TOP_AUDIO_SEL>,
+				 <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
+				 <&topckgen CLK_TOP_APLL1_DIV0>,
+				 <&topckgen CLK_TOP_APLL2_DIV0>,
+				 <&topckgen CLK_TOP_I2S0_M_SEL>,
+				 <&topckgen CLK_TOP_I2S1_M_SEL>,
+				 <&topckgen CLK_TOP_I2S2_M_SEL>,
+				 <&topckgen CLK_TOP_I2S3_M_SEL>,
+				 <&topckgen CLK_TOP_I2S3_B_SEL>;
+			clock-names = "infra_sys_audio_clk",
+				      "top_pdn_audio",
+				      "top_pdn_aud_intbus",
+				      "bck0",
+				      "bck1",
+				      "i2s0_m",
+				      "i2s1_m",
+				      "i2s2_m",
+				      "i2s3_m",
+				      "i2s3_b";
+			assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
+					  <&topckgen CLK_TOP_AUD_2_SEL>;
+			assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
+						 <&topckgen CLK_TOP_APLL2>;
+		};
 	};
 };
 
-- 
1.8.1.1.dirty

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: mt8173: Add afe device node
       [not found] ` <1436412725-55129-1-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2015-07-09 10:45   ` Daniel Kurtz
  2015-07-13  7:19     ` Koro Chen
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Kurtz @ 2015-07-09 10:45 UTC (permalink / raw)
  To: Koro Chen
  Cc: Matthias Brugger, srv_heupstream,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sascha Hauer,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw, open list:OPEN FIRMWARE AND...

On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> This adds afe (audio front end) device node to the MT8173 dtsi file.
>
> Signed-off-by: Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

Reviewed-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

I believe this patch depends on the fix in:
https://patchwork.kernel.org/patch/6752521/

If so, I think it would have been better to upload them together and
mention the dependency in the cover letter.
However, now that they are both on the list, we just need to ensure
they are merged together.

-Dan


> ---
> This patch is based on Matthias's tree:
> https://github.com/mbgg/linux-mediatek
> branch: v4.2-next/arm64
>
> Changes since v1:
> - change node name to afe: audio-controller@11220000
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 0696f8f..ce9255a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -14,6 +14,7 @@
>  #include <dt-bindings/clock/mt8173-clk.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/mt8173-power.h>
>  #include <dt-bindings/reset-controller/mt8173-resets.h>
>  #include "mt8173-pinfunc.h"
>
> @@ -393,6 +394,37 @@
>                         #size-cells = <0>;
>                         status = "disabled";
>                 };
> +
> +               afe: audio-controller@11220000  {
> +                       compatible = "mediatek,mt8173-afe-pcm";
> +                       reg = <0 0x11220000 0 0x1000>;
> +                       interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
> +                       power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> +                       clocks = <&infracfg CLK_INFRA_AUDIO>,
> +                                <&topckgen CLK_TOP_AUDIO_SEL>,
> +                                <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
> +                                <&topckgen CLK_TOP_APLL1_DIV0>,
> +                                <&topckgen CLK_TOP_APLL2_DIV0>,
> +                                <&topckgen CLK_TOP_I2S0_M_SEL>,
> +                                <&topckgen CLK_TOP_I2S1_M_SEL>,
> +                                <&topckgen CLK_TOP_I2S2_M_SEL>,
> +                                <&topckgen CLK_TOP_I2S3_M_SEL>,
> +                                <&topckgen CLK_TOP_I2S3_B_SEL>;
> +                       clock-names = "infra_sys_audio_clk",
> +                                     "top_pdn_audio",
> +                                     "top_pdn_aud_intbus",
> +                                     "bck0",
> +                                     "bck1",
> +                                     "i2s0_m",
> +                                     "i2s1_m",
> +                                     "i2s2_m",
> +                                     "i2s3_m",
> +                                     "i2s3_b";
> +                       assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
> +                                         <&topckgen CLK_TOP_AUD_2_SEL>;
> +                       assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
> +                                                <&topckgen CLK_TOP_APLL2>;
> +               };
>         };
>  };
>
> --
> 1.8.1.1.dirty
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: mt8173: Add afe device node
  2015-07-09 10:45   ` Daniel Kurtz
@ 2015-07-13  7:19     ` Koro Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Koro Chen @ 2015-07-13  7:19 UTC (permalink / raw)
  To: Daniel Kurtz
  Cc: Matthias Brugger, srv_heupstream, linux-mediatek, Sascha Hauer,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, alsa-devel,
	open list:OPEN FIRMWARE AND...

On Thu, 2015-07-09 at 18:45 +0800, Daniel Kurtz wrote:
> On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> 
> I believe this patch depends on the fix in:
> https://patchwork.kernel.org/patch/6752521/  
> 
> If so, I think it would have been better to upload them together and
> mention the dependency in the cover letter.
> However, now that they are both on the list, we just need to ensure
> they are merged together.

The above patch was already merged, so now it is OK to merge this one
(If there is no problem for this patch, of course)
> 
> -Dan
> 
> 
> > ---
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> >
> > Changes since v1:
> > - change node name to afe: audio-controller@11220000
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 0696f8f..ce9255a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> >  #include <dt-bindings/clock/mt8173-clk.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/mt8173-power.h>
> >  #include <dt-bindings/reset-controller/mt8173-resets.h>
> >  #include "mt8173-pinfunc.h"
> >
> > @@ -393,6 +394,37 @@
> >                         #size-cells = <0>;
> >                         status = "disabled";
> >                 };
> > +
> > +               afe: audio-controller@11220000  {
> > +                       compatible = "mediatek,mt8173-afe-pcm";
> > +                       reg = <0 0x11220000 0 0x1000>;
> > +                       interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
> > +                       power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> > +                       clocks = <&infracfg CLK_INFRA_AUDIO>,
> > +                                <&topckgen CLK_TOP_AUDIO_SEL>,
> > +                                <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
> > +                                <&topckgen CLK_TOP_APLL1_DIV0>,
> > +                                <&topckgen CLK_TOP_APLL2_DIV0>,
> > +                                <&topckgen CLK_TOP_I2S0_M_SEL>,
> > +                                <&topckgen CLK_TOP_I2S1_M_SEL>,
> > +                                <&topckgen CLK_TOP_I2S2_M_SEL>,
> > +                                <&topckgen CLK_TOP_I2S3_M_SEL>,
> > +                                <&topckgen CLK_TOP_I2S3_B_SEL>;
> > +                       clock-names = "infra_sys_audio_clk",
> > +                                     "top_pdn_audio",
> > +                                     "top_pdn_aud_intbus",
> > +                                     "bck0",
> > +                                     "bck1",
> > +                                     "i2s0_m",
> > +                                     "i2s1_m",
> > +                                     "i2s2_m",
> > +                                     "i2s3_m",
> > +                                     "i2s3_b";
> > +                       assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
> > +                                         <&topckgen CLK_TOP_AUD_2_SEL>;
> > +                       assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
> > +                                                <&topckgen CLK_TOP_APLL2>;
> > +               };
> >         };
> >  };
> >
> > --
> > 1.8.1.1.dirty
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] arm64: dts: mt8173: Add afe device node
  2015-07-09  3:32 [PATCH v2] arm64: dts: mt8173: Add afe device node Koro Chen
       [not found] ` <1436412725-55129-1-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2015-07-17 21:42 ` Matthias Brugger
  1 sibling, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2015-07-17 21:42 UTC (permalink / raw)
  To: Koro Chen
  Cc: srv_heupstream, linux-mediatek, s.hauer, djkurtz,
	linux-arm-kernel, linux-kernel, alsa-devel, devicetree

On Thursday, July 09, 2015 11:32:05 AM Koro Chen wrote:
> This adds afe (audio front end) device node to the MT8173 dtsi file.
> 
> Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> ---
> This patch is based on Matthias's tree:
> https://github.com/mbgg/linux-mediatek
> branch: v4.2-next/arm64
> 
> Changes since v1:
> - change node name to afe: audio-controller@11220000
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-17 21:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-09  3:32 [PATCH v2] arm64: dts: mt8173: Add afe device node Koro Chen
     [not found] ` <1436412725-55129-1-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-09 10:45   ` Daniel Kurtz
2015-07-13  7:19     ` Koro Chen
2015-07-17 21:42 ` Matthias Brugger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).