From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>,
Wen Su <wen.su@mediatek.com>
Subject: Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator
Date: Wed, 16 Dec 2020 12:34:19 +0800 [thread overview]
Message-ID: <1608093259.2412.1.camel@mtksdaap41> (raw)
In-Reply-To: <20200923162458.GE5707@sirena.org.uk>
Hi,
On Wed, 2020-09-23 at 17:24 +0100, Mark Brown wrote:
> On Mon, Sep 21, 2020 at 07:48:10PM +0800, Hsin-Hsiung Wang wrote:
>
> > +Required properties:
> > +- compatible: "mediatek,mt6359-regulator"
>
> The compatible isn't used by the driver (which is good!) so should be
> dropped from the binding document.
Thanks for your comments, but I have a question about it.
When I remove the compatible name in the dts, there will be some error
message:
[ 0.437562] mt6359-regulator: Failed to locate of_node [id: -1]
[ 0.440612] mt6359-sound: Failed to locate of_node [id: -1]
Do you mean that we don't need any compatible name in dts, mfd and
regulator driver?
next prev parent reply other threads:[~2020-12-16 4:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 11:48 [PATCH v2 0/8] Add Support for MediaTek PMIC MT6359 Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 1/8] mfd: mt6358: refine interrupt code Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 2/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2020-09-23 16:24 ` Mark Brown
2020-12-16 4:34 ` Hsin-hsiung Wang [this message]
2020-12-16 13:05 ` Mark Brown
2020-09-21 11:48 ` [PATCH v2 4/8] mfd: Add support for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 5/8] regulator: mt6359: Add support for MT6359 regulator Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 6/8] regulator: mt6359: Set the enable time for LDOs Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 7/8] regulator: mt6359: Add support for MT6359P regulator Hsin-Hsiung Wang
2020-09-21 11:48 ` [PATCH v2 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608093259.2412.1.camel@mtksdaap41 \
--to=hsin-hsiung.wang@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wen.su@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).