From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
javier@osg.samsung.com, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration
Date: Thu, 01 Sep 2016 12:59:41 +0200 [thread overview]
Message-ID: <1608454.1ZuTJsprje@amdc1976> (raw)
In-Reply-To: <1472721715-2833-6-git-send-email-k.kozlowski@samsung.com>
Hi,
On Thursday, September 01, 2016 11:21:54 AM Krzysztof Kozlowski wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier
> to read. One does not have to remember which value means pull-up/down
> or specific driver strength.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> index 527e3193817f..6274359fb323 100644
> --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> @@ -8,6 +8,8 @@
> * published by the Free Software Foundation.
> */
>
> +#include <dt-bindings/pinctrl/samsung.h>
> +
> &pinctrl_0 {
> /*
> * Pin banks
> @@ -83,91 +85,91 @@
>
> uart0_data: uart0-data {
> samsung,pins = "gph-0", "gph-1";
> - samsung,pin-function = <2>;
> + samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
Shouldn't macros that are also used by s3c* be named as
SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2016-09-01 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 9:21 [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 2/6] pinctrl: dt-bindings: samsung: Add macros for S3C64xx pin configuration Krzysztof Kozlowski
[not found] ` <1472721715-2833-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-01 9:21 ` [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros Krzysztof Kozlowski
2016-09-01 10:29 ` Javier Martinez Canillas
2016-09-01 10:31 ` Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 3/6] ARM: dts: s3c64xx: Use common macros for pinctrl configuration Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 4/6] ARM: dts: s5pv210: Use " Krzysztof Kozlowski
2016-09-01 9:21 ` [PATCH 5/6] ARM: dts: s3c2416: " Krzysztof Kozlowski
2016-09-01 10:59 ` Bartlomiej Zolnierkiewicz [this message]
2016-09-01 11:12 ` Krzysztof Kozlowski
2016-09-01 11:17 ` Arnd Bergmann
2016-09-01 9:21 ` [PATCH 6/6] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2016-09-01 10:53 ` [PATCH 0/6] pinctrl: s3c/samsung: Add header with values used for configuration Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608454.1ZuTJsprje@amdc1976 \
--to=b.zolnierkie@samsung.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).