[PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform

[PATCH v1 0/2] arm64: Support devapc on MediaTek MT6779 platform

[Neal Liu]

This series adds DEVAPC (Device Access Permission Control) support on MediaTek MT6779 SoC platform.

*** BLURB HERE ***

Neal Liu (2):
  arm64: dts: mt6779: Support devapc
  arm64: configs: Support DEVAPC on MediaTek platforms

 arch/arm64/boot/dts/mediatek/mt6779.dtsi | 8 ++++++++
 arch/arm64/configs/defconfig             | 1 +
 2 files changed, 9 insertions(+)

-- 
2.18.0

[PATCH v1 1/2] arm64: dts: mt6779: Support devapc

[Neal Liu]

Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6779.dtsi |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
index 370f309..52ecfc7 100644
--- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
@@ -189,6 +189,14 @@
 			#clock-cells = <1>;
 		};
 
+		devapc: devapc@10207000 {
+			compatible = "mediatek,mt6779-devapc";
+			reg = <0 0x10207000 0 0x1000>;
+			interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
+			clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
+			clock-names = "devapc-infra-clock";
+		};
+
 		uart0: serial@11002000 {
 			compatible = "mediatek,mt6779-uart",
 				     "mediatek,mt6577-uart";
-- 
1.7.9.5

Re: [PATCH v1 1/2] arm64: dts: mt6779: Support devapc

[Neal Liu]

+add comments & reviewed-by Hanks

On Wed, 2020-12-23 at 16:44 +0800, Neal Liu wrote:

Support DEVAPC on MT6779 platforms by adding device node.

Reviewed-by: Hanks Chen <hanks.chen@mediatek.com>
> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6779.dtsi |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6779.dtsi b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> index 370f309..52ecfc7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6779.dtsi
> @@ -189,6 +189,14 @@
>  			#clock-cells = <1>;
>  		};
>  
> +		devapc: devapc@10207000 {
> +			compatible = "mediatek,mt6779-devapc";
> +			reg = <0 0x10207000 0 0x1000>;
> +			interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&infracfg_ao CLK_INFRA_DEVICE_APC>;
> +			clock-names = "devapc-infra-clock";
> +		};
> +
>  		uart0: serial@11002000 {
>  			compatible = "mediatek,mt6779-uart",
>  				     "mediatek,mt6577-uart";

[PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms

[Neal Liu]

Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.

Signed-off-by: Neal Liu <neal.liu@mediatek.com>
---
 arch/arm64/configs/defconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
 CONFIG_MTD_NAND_FSL_IFC=y
 CONFIG_MTD_NAND_QCOM=y
 CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
 CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m
-- 
1.7.9.5

Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms

[Matthias Brugger]

On 31/01/2021 23:23, Arnd Bergmann wrote:
> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>> On 23/12/2020 09:44, Neal Liu wrote:
>>> Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.
>>>
>>> Signed-off-by: Neal Liu <neal.liu@mediatek.com>
>>> ---
>>>  arch/arm64/configs/defconfig |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>> index 17a2df6..a373776 100644
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
>>>  CONFIG_MTD_NAND_FSL_IFC=y
>>>  CONFIG_MTD_NAND_QCOM=y
>>>  CONFIG_MTD_SPI_NOR=y
>>> +CONFIG_MTK_DEVAPC=m
>>>  CONFIG_SPI_CADENCE_QUADSPI=y
>>>  CONFIG_BLK_DEV_LOOP=y
>>>  CONFIG_BLK_DEV_NBD=m
>>>
>>
>> From my understanding, defconfig is for a minimal config that allows to boot a
>> machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
>> violations, I think it's not a good candidate for inclusion in defconfig.
>>
>> In any case, I added the SoC maintainer, so that they can correct me, if I'm
>> wrong :)
> 
> I generally don't mind adding platform specific drivers as loadable modules
> even if they are somewhat obscure. For built-in drivers, this is
> different though,
> as those have a noticeable impact on other platforms.
> 
> I haven't kept track of what this particular driver does, but from the Kconfig
> description, I'd say it should get enabled in defconfig.
> 

Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig