From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] arm64: dts: rockchip: improve rk3328-roc-cc rgmii performance. Date: Thu, 27 Jun 2019 00:22:36 +0200 Message-ID: <1609807.FCSDk0ZevM@phil> References: <20190626130443.22025-1-pgwipeout@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190626130443.22025-1-pgwipeout-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Peter Geis Cc: Jose Abreu , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Robin Murphy , "Leonidas P . Papadakos" List-Id: devicetree@vger.kernel.org Am Mittwoch, 26. Juni 2019, 15:04:43 CEST schrieb Peter Geis: > Currently the rk3328-roc-cc ethernet is enabled using "snps,force_thresh_dma_mode". > While this works, the performance leaves a lot to be desired. > A previous attempt to improve performance used "snps,txpbl = <0x4>". > This also allowed networking to function, but performance varied between boards. > > This patch takes that one step further. > Set txpbl and rxpbl to 0x4. > This can also be accomplished with "snps,pbl =<0x4>" which affects both. > Also set "snps,aal" which forces address aligned DMA mode. > > Fixes: 4bc4d6013b7f (arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues) > > Signed-off-by: Peter Geis > > Tested-by: Leonidas P. Papadakos applied for 5.3 after sorting the new properties alphabetically. Thanks Heiko