From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF52AC7EE23 for ; Fri, 26 May 2023 09:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243163AbjEZJrc (ORCPT ); Fri, 26 May 2023 05:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243238AbjEZJrJ (ORCPT ); Fri, 26 May 2023 05:47:09 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36C92E65 for ; Fri, 26 May 2023 02:46:53 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-30abe551605so481818f8f.0 for ; Fri, 26 May 2023 02:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1685094411; x=1687686411; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nat2dXg+UOzIavY+WSMDfeXKleU0IIvcUkgX31+SwQ0=; b=QClPu3uwppIpWhb4E3uBUouUHuGMdCDCap+TS3E6hGmLnA4VjA4bKSBHIHelGx0ccW FEr0tengi50fv5JkQcvgU1KTRffYujLtgVjvOOvZFIGz7/sclzkeUoKurDBYRU7U4O+E SqZapO1awa/OnzqqYNJX4m6EBvNJHwiV0MmIk2Fg6KECJgzQiaRlFOAckqdKWBEhO/rr Zw2s3DnpcD0f9Xqt48cK4kdPbfgP6+ls3uZmqN3D0SfZahD/EwRw0v+HDDU6oOj8wjYV Acdo8a+1fB2+ZoPrSuE8Lf6gCE7iWPqS8QXsj3t50cBRwpqKw4Lme7PRmLQwPNJLszhT KLfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685094411; x=1687686411; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nat2dXg+UOzIavY+WSMDfeXKleU0IIvcUkgX31+SwQ0=; b=PN5W7qSjpoCijF3T4a6HKE6gepPd2GWFCn3SMTP2s+LfiNzxBOdSlNiUNwblXUGZhB wPYRoY4lDKFrTTZP2RI0FWTSh3Oe1/i7IrjEYTutF6vh3dk4xdCUJAqFaG0DtCGEu9Hd aYWE1CvnQ00ocy8hUB1SpdewGa3GZmHRkYYEWZE5Vega9IN2Xs8nqCzsbEn59dphPs93 Aa+WwCYcPl2fZHWUS55sHWAA+Wayk54/6hKOaokR4y6x6EG/A/5s+fa9yZ992AAe3Ylo jD7lhISggKSmOWCegoZmeb8hBSMm4uRy1oKLETH4EY6IgngXiUoPrIwG0IeSDe7ZPzu9 UThw== X-Gm-Message-State: AC+VfDxqmefHZaY8+N6kLH+50eU+phfnEqiOrYZ5cx4nuWmD2mkZGMbz J8vLQuLR7Tst5Fe915E42do+Ww== X-Google-Smtp-Source: ACHHUZ7zzzPEEncZvQtOFznUC+/7QoK+Qxxmiu8AfkXUIs6gj8Ym6jXeyUI0v0C9XmNiOfMiKm+5OQ== X-Received: by 2002:a5d:5506:0:b0:309:491b:39ca with SMTP id b6-20020a5d5506000000b00309491b39camr1037698wrv.33.1685094410926; Fri, 26 May 2023 02:46:50 -0700 (PDT) Received: from [192.168.1.172] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.gmail.com with ESMTPSA id u10-20020a5d514a000000b00307b5376b2csm4463662wrt.90.2023.05.26.02.46.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 02:46:50 -0700 (PDT) Message-ID: <160d8ea5-81bd-ece6-a4a6-b93a62b4d749@baylibre.com> Date: Fri, 26 May 2023 11:46:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: clock: mediatek: replace unusable clock Content-Language: en-US To: AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Chen-Yu Tsai Cc: Markus Schneider-Pargmann , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230517-fix-clk-index-v2-0-1b686cefcb7e@baylibre.com> <20230517-fix-clk-index-v2-1-1b686cefcb7e@baylibre.com> From: Alexandre Mergnat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/05/2023 10:30, AngeloGioacchino Del Regno wrote: > Il 25/05/23 16:50, Alexandre Mergnat ha scritto: >> The “mcu_pm_bclk_ck_cg” clock is used by co-processors and should not be >> added to the kernel driver, otherwise the CPU just halt and the board is >> rebooted by the wathdog. >> >> Instead, add the "aes_top0_bclk_ck_cg" missing clock to prevent >> re-shuffling index and then preserve the ABI. > > It's still a breakage. Besides, have you tried to add it as > CLK_IS_CRITICAL? :-) As I said to Conor, I can fix the driver index issue (patch 2/2) without fixing the binding (using CLK_IGNORE_UNUSED but CLK_IS_CRITICAL works too). -- Regards, Alexandre