From: Rob Herring <robh@kernel.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: Rob Herring <robh+dt@kernel.org>, Nancy Yuen <yuenn@google.com>,
Tali Perry <tali.perry1@gmail.com>,
linux-kernel@vger.kernel.org, Tomer Maimon <tmaimon77@gmail.com>,
Patrick Venture <venture@google.com>,
openbmc@lists.ozlabs.org, devicetree@vger.kernel.org,
Benjamin Fair <benjaminfair@google.com>,
Avi Fishman <avifishman70@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML
Date: Sun, 10 Jan 2021 11:18:46 -0600 [thread overview]
Message-ID: <1610299126.020227.785276.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210108224008.705687-1-j.neuschaefer@gmx.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]
On Fri, 08 Jan 2021 23:40:06 +0100, Jonathan Neuschäfer wrote:
> The general trend is to have devicetree bindings in YAML format, to
> allow automatic validation of bindings and devicetrees.
>
> Convert the NPCM SoC family's binding to YAML before it accumulates more
> entries.
>
> The nuvoton,npcm750-evb compatible string is introduced to keep the
> structure of the binding a little simpler.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> If someone else wants to be listed as the maintainer, please let me
> know.
> ---
> .../devicetree/bindings/arm/npcm/npcm.txt | 6 -----
> .../devicetree/bindings/arm/npcm/npcm.yaml | 23 +++++++++++++++++++
> 2 files changed, 23 insertions(+), 6 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
> create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/npcm/npcm.yaml:20:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/npcm/npcm.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/arm/npcm/npcm.yaml#
See https://patchwork.ozlabs.org/patch/1423975
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-01-10 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 22:40 [PATCH 1/2] dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML Jonathan Neuschäfer
2021-01-08 22:40 ` [PATCH 2/2] ARM: dts: Add board-specific compatible string to npcm750-evb devicetree Jonathan Neuschäfer
2021-01-10 17:18 ` Rob Herring [this message]
2021-01-10 19:49 ` [PATCH 1/2] dt-bindings: arm: Convert nuvoton, npcm750 binding to YAML Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610299126.020227.785276.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).