From: Tomasz Figa <t.figa@samsung.com>
To: Padmavathi Venna <padma.v@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, padma.kvr@gmail.com,
sbkim73@samsung.com, broonie@kernel.org, kgene.kim@samsung.com,
mturquette@linaro.org, dianders@chromium.org,
abrestic@chromium.org
Subject: Re: [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree
Date: Mon, 22 Jul 2013 18:28:47 +0200 [thread overview]
Message-ID: <1610421.OFFn8rqlxt@amdc1227> (raw)
In-Reply-To: <1373458313-18970-3-git-send-email-padma.v@samsung.com>
Hi Padmavathi, Andrew,
On Wednesday 10 of July 2013 17:41:51 Padmavathi Venna wrote:
> From: Andrew Bresticker <abrestic@chromium.org>
>
> This allows the input clocks to the Exynos AudioSS block to be specified
> via device-tree bindings. Default names will be used when an input clock
> is not given. This will be useful when adding support for the
> Exynos5420 where the audio bus clock is called "sclk_maudio0" instead of
> "sclk_audio0".
>
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Reviewed-on: https://gerrit.chromium.org/gerrit/57833
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> .../devicetree/bindings/clock/clk-exynos-audss.txt | 31
> ++++++++++++++++++- drivers/clk/samsung/clk-exynos-audss.c |
> 28 +++++++++++++++-- 2 files changed, 53 insertions(+), 6 deletions(-)
Well, this is basically how it should be done, but in current state of
clock core I can see a problem: can we really rely on the order of clock
initialization? I mean, we can't defer initialization of particular clock
controller until all external clocks it needs are available, because there
is no probing involved here.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-22 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 12:11 [PATCH 0/4] clk: Samsung: audss: Add support for Exynos5420 Padmavathi Venna
2013-07-10 12:11 ` [PATCH 1/4] clk: exynos-audss: add support for Exynos 5420 Padmavathi Venna
2013-07-10 12:11 ` [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree Padmavathi Venna
2013-07-22 16:28 ` Tomasz Figa [this message]
2013-07-22 18:15 ` Mike Turquette
2013-07-22 19:42 ` Tomasz Figa
2013-07-23 10:25 ` Padma Venkat
2013-08-14 20:11 ` Andrew Bresticker
2013-07-10 12:11 ` [PATCH 3/4] ARM: dts: Correct the /include entry on exynos5420 dtsi file Padmavathi Venna
2013-08-18 19:54 ` Kukjin Kim
2013-07-10 12:11 ` [PATCH 4/4] ARM: dts: exynos5420: add audio clock controller Padmavathi Venna
2013-08-18 19:54 ` Kukjin Kim
2013-08-12 10:15 ` [PATCH 0/4] clk: Samsung: audss: Add support for Exynos5420 Padma Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610421.OFFn8rqlxt@amdc1227 \
--to=t.figa@samsung.com \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=padma.kvr@gmail.com \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).