Re: [PATCH 1/2] dt-bindings: mediatek: mt6359: add ASoC mt6359 accdet document

[Argus Lin <argus.lin@mediatek.com>]

Dear maintainers:
Can you reply to me if any opinion?
thanks

B.R.
Argus

On Wed, 2021-01-06 at 20:19 +0800, Argus Lin wrote:
> This patch adds MediaTek MT6359 accdet document.
> 
> Signed-off-by: Argus Lin <argus.lin@mediatek.com>
> ---
>  .../devicetree/bindings/sound/mt6359-accdet.yaml   | 142 +++++++++++++++++++++
>  1 file changed, 142 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mt6359-accdet.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/mt6359-accdet.yaml b/Documentation/devicetree/bindings/sound/mt6359-accdet.yaml
> new file mode 100644
> index 0000000..fde0d29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt6359-accdet.yaml
> @@ -0,0 +1,142 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mt6359-accdet.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Technologies Inc. MT6359 ASoC accdet driver bindings
> +
> +maintainers:
> +  - Chipeng Chang <chipeng.chang@mediatek.com>
> +
> +description: |
> +  This binding describes the Mediatek Technologies MT6359 ASoC
> +  accdet driver.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mediatek,mt6359-accdet
> +      - mediatek,pmic-accdet
> +
> +  accdet-name:
> +    maxItems: 1
> +    description: named as "mt6359-accdet" for snd_soc_card_jack.
> +
> +  accdet-mic-vol:
> +    maxItems: 1
> +    description: |
> +      accdet micbias1 voltage.
> +
> +      enum:
> +        - 0x00 # 1.7v - micbias1 volage is 1.7v.
> +        - 0x01 # 1.8v - micbias1 volage is 1.8v.
> +        - 0x02 # 1.9v - micbias1 volage is 1.9v.
> +        - 0x03 # 2.0v - micbias1 volage is 2.0v.
> +        - 0x04 # 2.1v - micbias1 volage is 2.1v.
> +        - 0x05 # 2.5v - micbias1 volage is 2.5v.
> +        - 0x06 # 2.6v - micbias1 volage is 2.6v.
> +        - 0x07 # 2.7v - micbias1 volage is 2.7v.
> +        - 0x08 # 2.8v - micbias1 volage is 2.8v.
> +        - 0x09 # 2.85v - micbias1 volage is 2.85v.
> +
> +  accdet-plugout-debounce:
> +    maxItems: 1
> +    description: For using ap gpio eint only, it is sw debounce time.
> +
> +  accdet-mic-mode:
> +    maxItems: 1
> +    description: |
> +      value as 1, 2, 6 to indicate ACC/DCC mode. default is DCC mode 2.
> +
> +      enum:
> +        - 0x01 # ACC - ACC mode.
> +        - 0x02 # DCC - low cost without in bias.
> +        - 0x06 # DCC - low cost with in bias.
> +
> +  eint_use_ext_res:
> +    maxItems: 1
> +    description: select HP_EINT pull up resistance, default 0 use internal resistance.
> +
> +  headset-mode-setting:
> +    maxItems: 15
> +    description: |
> +       headset-mode-setting : Indicates customized pwm, debounce setting
> +       accdet pwm_width, pwm_thresh, fall_delay, rise_delay
> +       debounce0, debounce1, debounce3, debounce4
> +       eint pwm_width, eint pwm_thresh
> +       eint deb(debounce0, debounce1, debounce2, debounce3), inv_debounce.
> +
> +  headset-use-ap-eint:
> +    maxItems: 1
> +    description: indicates to use ap gpio.
> +
> +  headset-eint-num:
> +    maxItems: 1
> +    description: |
> +      incicates pmic eint usage.
> +
> +      enum:
> +        - 0x0 # PMIC_EINT0 - use pmic eint0 to trigger plug interrupt.
> +        - 0x1 # PMIC_EINT1 - use pmic eint1 to trigger plug interrupt.
> +        - 0x2 # PMIC_BI_EINT - use pmic eint0/1 to trigger plug interrupt.
> +
> +  headset-eint-trig-mode:
> +    maxItems: 1
> +    description: |
> +      incicates pmic eint trigger mode.
> +
> +      enum:
> +        - 0x0 # PMIC_GPIO - use pmic gpio to detect plug status by setting polarity to high or low.
> +        - 0x1 # PMIC_INVERTER - use pmic inverter to detect plug status.
> +
> +  headset-key-mode:
> +    maxItems: 1
> +    description: |
> +      incicates key mode type.
> +
> +      enum:
> +        - 0x0 # THREE_KEY - support 3-key key mode.
> +        - 0x1 # FOUR_KEY - support 4-key key mode.
> +        - 0x1 # TRI_KEY_CDD - support 3-key google CDD key mode.
> +
> +  headset-three-key-threshold:
> +    maxItems: 4
> +    description: |
> +      3 key device detection threshold: 0--MD_MAX--UP_MAX--DW_MAX.
> +
> +  headset-three-key-threshold-CDD:
> +    maxItems: 4
> +    description: |
> +       3 key CDD device detection threshold: 0--MD_MAX--UP_MAX--DW_MAX.
> +
> +  headset-four-key-threshold:
> +    maxItems: 4
> +    description: |
> +      4 key device detection threshold: 0--MD_MAX--VOICE_MAX--UP_MAX--DW_MAX.
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    accdet: accdet {
> +        compatible = "mediatek,mt6359-accdet";
> +        accdet-name = "mt6359-accdet";
> +        accdet-mic-vol = <8>;
> +        accdet-plugout-debounce = <1>;
> +        accdet-mic-mode = <2>;
> +        eint_use_ext_res = <0>;
> +        headset-mode-setting = <0x500 0x500 1 0x1f0
> +                                0x800 0x800 0x20 0x44
> +                                0x4 0x1
> +                                0x5 0x3 0x3 0x5 0xe>;
> +        headset-use-ap-eint = <0>;
> +        headset-eint-num = <0>;
> +        headset-eint-trig-mode = <1>;
> +        headset-key-mode = <0>;
> +        headset-three-key-threshold = <0 80 220 400>;
> +        headset-three-key-threshold-CDD = <0 121 192 600>;
> +        headset-four-key-threshold = <0 58 121 192 400>;
> +        status = "okay";
> +    };
> +...
> --
> 1.8.1.1.dirty
>