From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
linux-clk@vger.kernel.org, Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Prashant Gaikwad <pgaikwad@nvidia.com>,
linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v4 7/7] dt-bindings: clock: tegra: Convert to schema
Date: Mon, 15 Mar 2021 08:22:57 -0600 [thread overview]
Message-ID: <1615818177.169631.876367.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210312163632.8861-8-digetx@gmail.com>
On Fri, 12 Mar 2021 19:36:32 +0300, Dmitry Osipenko wrote:
> Convert NVIDIA Tegra clock bindings to schema.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../bindings/clock/nvidia,tegra-car.yaml | 118 ++++++++++++++++++
> .../bindings/clock/nvidia,tegra114-car.txt | 63 ----------
> .../bindings/clock/nvidia,tegra124-car.txt | 107 ----------------
> .../bindings/clock/nvidia,tegra20-car.txt | 63 ----------
> .../bindings/clock/nvidia,tegra210-car.txt | 56 ---------
> .../bindings/clock/nvidia,tegra30-car.txt | 63 ----------
> 6 files changed, 118 insertions(+), 352 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra-car.yaml
> delete mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra114-car.txt
> delete mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra124-car.txt
> delete mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra20-car.txt
> delete mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra210-car.txt
> delete mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra30-car.txt
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/nvidia,tegra-car.example.dt.yaml: usb-controller@c5004000: compatible: 'oneOf' conditional failed, one must be fixed:
['nvidia,tegra20-ehci', 'usb-ehci'] is too long
Additional items are not allowed ('usb-ehci' was unexpected)
'nvidia,tegra20-ehci' is not one of ['allwinner,sun4i-a10-ehci', 'allwinner,sun50i-a64-ehci', 'allwinner,sun50i-h6-ehci', 'allwinner,sun5i-a13-ehci', 'allwinner,sun6i-a31-ehci', 'allwinner,sun7i-a20-ehci', 'allwinner,sun8i-a23-ehci', 'allwinner,sun8i-h3-ehci', 'allwinner,sun8i-r40-ehci', 'allwinner,sun9i-a80-ehci', 'aspeed,ast2400-ehci', 'aspeed,ast2500-ehci', 'aspeed,ast2600-ehci', 'brcm,bcm3384-ehci', 'brcm,bcm63268-ehci', 'brcm,bcm6328-ehci', 'brcm,bcm6358-ehci', 'brcm,bcm6362-ehci', 'brcm,bcm6368-ehci', 'brcm,bcm7125-ehci', 'brcm,bcm7346-ehci', 'brcm,bcm7358-ehci', 'brcm,bcm7360-ehci', 'brcm,bcm7362-ehci', 'brcm,bcm7420-ehci', 'brcm,bcm7425-ehci', 'brcm,bcm7435-ehci', 'ibm,476gtr-ehci', 'nxp,lpc1850-ehci', 'qca,ar7100-ehci', 'snps,hsdk-v1.0-ehci', 'socionext,uniphier-ehci']
'nvidia,tegra20-ehci' is not one of ['cavium,octeon-6335-ehci', 'ibm,usb-ehci-440epx', 'ibm,usb-ehci-460ex', 'nintendo,hollywood-usb-ehci', 'st,spear600-ehci']
'nvidia,tegra20-ehci' is not one of ['generic-ehci', 'usb-ehci']
'generic-ehci' was expected
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/generic-ehci.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/nvidia,tegra-car.example.dt.yaml: usb-controller@c5004000: 'oneOf' conditional failed, one must be fixed:
'interrupts' is a required property
'interrupts-extended' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/generic-ehci.yaml
See https://patchwork.ozlabs.org/patch/1452220
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-03-15 14:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 16:36 [PATCH v4 0/7] Couple improvements for Tegra clk driver Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 1/7] clk: tegra30: Use 300MHz for video decoder by default Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 2/7] clk: tegra: Fix refcounting of gate clocks Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 3/7] clk: tegra: Ensure that PLLU configuration is applied properly Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 4/7] clk: tegra: Halve SCLK rate on Tegra20 Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 5/7] MAINTAINERS: Hand Tegra clk driver to Jon and Thierry Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 6/7] clk: tegra: Don't allow zero clock rate for PLLs Dmitry Osipenko
2021-03-12 16:36 ` [PATCH v4 7/7] dt-bindings: clock: tegra: Convert to schema Dmitry Osipenko
2021-03-15 14:22 ` Rob Herring [this message]
2021-03-15 15:53 ` Rob Herring
2021-03-15 19:07 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615818177.169631.876367.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).