From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<srv_heupstream@mediatek.com>, "Rob Herring" <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Stephen Boyd" <sboyd@kernel.org>
Subject: Re: [PATCH v7 2/4] dt-bindings: spmi: document binding for the Mediatek SPMI controller
Date: Tue, 16 Mar 2021 01:30:25 +0800 [thread overview]
Message-ID: <1615829425.2591.1.camel@mtksdaap41> (raw)
In-Reply-To: <1615818177.192018.876373.nullmailer@robh.at.kernel.org>
Hi, Sir
On Mon, 2021-03-15 at 08:22 -0600, Rob Herring wrote:
> On Sun, 14 Mar 2021 02:00:51 +0800, Hsin-Hsiung Wang wrote:
> > This adds documentation for the SPMI controller found on Mediatek SoCs.
> >
> > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> > changes since v6:
> > - no changes.
> > ---
> > .../bindings/spmi/mtk,spmi-mtk-pmif.yaml | 74 +++++++++++++++++++
> > 1 file changed, 74 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dts:19:18: fatal error: dt-bindings/clock/mt8192-clk.h: No such file or directory
> 19 | #include <dt-bindings/clock/mt8192-clk.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/spmi/mtk,spmi-mtk-pmif.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1380: dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1452529
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Thanks for the review.
This series is based on Weiyi's patches.
https://patchwork.kernel.org/project/linux-mediatek/patch/1608642587-15634-7-git-send-email-weiyi.lu@mediatek.com/
next prev parent reply other threads:[~2021-03-15 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 18:00 [PATCH v7 0/4] Add SPMI support for Mediatek MT6873/8192 SoC IC Hsin-Hsiung Wang
2021-03-13 18:00 ` [PATCH v7 1/4] dt-bindings: spmi: modify the constraint 'maxItems' to 'minItems' Hsin-Hsiung Wang
2021-03-13 18:00 ` [PATCH v7 2/4] dt-bindings: spmi: document binding for the Mediatek SPMI controller Hsin-Hsiung Wang
2021-03-15 14:22 ` Rob Herring
2021-03-15 17:30 ` Hsin-hsiung Wang [this message]
2021-03-13 18:00 ` [PATCH v7 3/4] spmi: mediatek: Add support for MT6873/8192 Hsin-Hsiung Wang
2021-04-13 5:49 ` Hsin-hsiung Wang
2021-03-13 18:00 ` [PATCH v7 4/4] arm64: dts: mt8192: add spmi node Hsin-Hsiung Wang
2021-03-21 0:18 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615829425.2591.1.camel@mtksdaap41 \
--to=hsin-hsiung.wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).