From: Mason Zhang <mason.zhang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <hanks.chen@mediatek.com>,
<wsd_upstream@mediatek.com>
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: add MT6779 spi master dts node
Date: Fri, 9 Apr 2021 10:27:17 +0800 [thread overview]
Message-ID: <1617935237.16711.6.camel@mbjsdccf07> (raw)
In-Reply-To: <4e39785a-06a6-4ec5-5930-8a5bf53e4f7b@gmail.com>
On Wed, 2021-04-07 at 13:17 +0200, Matthias Brugger wrote:
>
> From the binding description:
> - #address-cells: should be 1.
>
> - #size-cells: should be 0.
>
> We are missing both here. Please fix that.
>
> Apart the binding description is naming PLL, clock mux and clock gate IDs which
> do not correspond to the ones used here. It seems that this binding was tailored
> for a specific SoC family but never made generic. If you want, please do so and
> convert it to yaml.
Dear Matthias:
I have update patch v2:
https://patchwork.kernel.org/project/linux-mediatek/patch/20210409015651.11474-1-Mason.Zhang@mediatek.com/
Please gentle ping on this patch. Thanks~
Thanks
Mason
prev parent reply other threads:[~2021-04-09 2:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 10:59 [PATCH 1/2] arm64: dts: mediatek: add MT6779 spi master dts node Mason Zhang
2021-03-01 2:01 ` Mason Zhang
2021-03-22 11:28 ` Mason Zhang
2021-03-29 15:50 ` Matthias Brugger
2021-04-07 8:49 ` Mason Zhang
2021-04-07 11:17 ` Matthias Brugger
2021-04-09 2:27 ` Mason Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617935237.16711.6.camel@mbjsdccf07 \
--to=mason.zhang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hanks.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).