From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900 Date: Mon, 11 Jul 2016 00:22:09 +0200 Message-ID: <1618088.N8H7ez3XRZ@wuerfel> References: <1468136542-2656-1-git-send-email-vw@iommu.org> <1468136542-2656-2-git-send-email-vw@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1468136542-2656-2-git-send-email-vw@iommu.org> Sender: linux-clk-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun List-Id: devicetree@vger.kernel.org On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote: > diff --git a/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt > new file mode 100644 > index 0000000..0284edf > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt > @@ -0,0 +1,12 @@ > +. Nuvoton NUC900 series, Soc specific driver binding. > + > +Required properties: > +- compatible : Should be "nuvoton,nuc900-soc" > +- syscon : Reference to gcr controller. > + > +Example: > + > +reset { > + compatible = "nuvoton,nuc900-soc"; > + syscon = <&gcr>; > +}; I think this one should be dropped: Instead of modeling the DT based on what is convenient for the current Linux driver implementation, we only want to list devices in the dts that are physically present, and the "soc" is really the sum of all the on-chip devices. Better change the soc_device driver to bind directly to the "nuvoton,nuc970-gcr" device. Arnd