From: Heiko Stuebner <heiko@sntech.de>
To: Akash Gajjar <Akash_Gajjar@mentor.com>
Cc: Deepak_Das@mentor.com, Pragnesh_Patel@mentor.com,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Nickey Yang <nickey.yang@rock-chips.com>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Randy Li <ayaka@soulik.info>, Chris Zhong <zyw@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: update pinmux setting in rk3399.dtsi
Date: Mon, 24 Sep 2018 14:58:15 +0200 [thread overview]
Message-ID: <1621920.B7a7Pky3iO@phil> (raw)
In-Reply-To: <1537368317-22170-1-git-send-email-Akash_Gajjar@mentor.com>
Hi Akash,
Am Mittwoch, 19. September 2018, 16:45:15 CEST schrieb Akash Gajjar:
> replace pin numbers with equivalent pin macro in rk3399.dtsi
>
> Signed-off-by: Akash Gajjar <Akash_Gajjar@mentor.com>
so far my "policy" has been to have new stuff use the constants
but not mass-converting the old entries, due to me being anxious
about accidentially breaking some seldom used settings.
With the newly added linebreaks your change looks pretty much hand-
generated, so I guess there is a bit of probability for typos creeping in
and it of course also only adapts one of the Rockchip socs.
So while I _may_ be persuaded of a scripted conversion [including seeing
the script] doing all Rockchip socs (per architecture) at once, I currently
somehow prefer keeping the status quo ;-)
Heiko
prev parent reply other threads:[~2018-09-24 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:45 [PATCH] arm64: dts: rockchip: update pinmux setting in rk3399.dtsi Akash Gajjar
2018-09-24 12:58 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621920.B7a7Pky3iO@phil \
--to=heiko@sntech.de \
--cc=Akash_Gajjar@mentor.com \
--cc=Deepak_Das@mentor.com \
--cc=Pragnesh_Patel@mentor.com \
--cc=ayaka@soulik.info \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=nickey.yang@rock-chips.com \
--cc=robh+dt@kernel.org \
--cc=zhengsq@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).