From: Rob Herring <robh@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
lee.jones@linaro.org, linux-rockchip@lists.infradead.org,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, jbx6244@gmail.com
Subject: Re: [PATCH v2 1/3] dt-bindings: soc: rockchip: convert io-domain.txt to YAML
Date: Thu, 27 May 2021 09:23:27 -0500 [thread overview]
Message-ID: <1622125407.801041.731793.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210527082905.1447591-2-jay.xu@rock-chips.com>
On Thu, 27 May 2021 16:29:03 +0800, Jianqun Xu wrote:
> This patch moves the rockchip-io-domain.txt from power/avs dir to soc
> dir and rename to io-domain.txt, without any change in the step.
>
> Then covert the io-domain.txt to YAML.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
> v2:
> - first version
> .../bindings/power/rockchip-io-domain.txt | 135 ------------------
> .../bindings/soc/rockchip/io-domain.yaml | 45 ++++++
> 2 files changed, 45 insertions(+), 135 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/rockchip-io-domain.txt
> create mode 100644 Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml:17:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
./Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml:36:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/soc/rockchip/io-domain.example.dts'
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 421, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 109, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a block scalar
in "<unicode string>", line 32, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 36, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/soc/rockchip/io-domain.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml: while scanning a block scalar
in "<unicode string>", line 32, column 5
found a tab character where an indentation space is expected
in "<unicode string>", line 36, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/soc/rockchip/io-domain.yaml
make: *** [Makefile:1416: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1484505
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-05-27 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 8:29 [PATCH v2 0/3] rockchip io domain Jianqun Xu
2021-05-27 8:29 ` [PATCH v2 1/3] dt-bindings: soc: rockchip: convert io-domain.txt to YAML Jianqun Xu
2021-05-27 14:23 ` Rob Herring [this message]
2021-05-27 8:29 ` [PATCH v2 2/3] soc: rockchip: io-domain: add rk3568 support Jianqun Xu
2021-08-05 13:02 ` Peter Geis
2021-08-05 14:10 ` Heiko Stübner
2021-05-27 8:29 ` [PATCH v2 3/3] dt-bindings: soc: rockchip: add rk3568-pmu-io-domain support Jianqun Xu
-- strict thread matches above, loose matches on Subject: below --
2021-05-27 8:24 [PATCH v2 0/3] rockchip io domain Jianqun Xu
2021-05-27 8:24 ` [PATCH v2 1/3] dt-bindings: soc: rockchip: convert io-domain.txt to YAML Jianqun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622125407.801041.731793.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).