From: cy_huang <u0084500@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, matthias.bgg@gmail.com,
robh+dt@kernel.org, gene_chen@richtek.com
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
cy_huang@richtek.com, gene.chen.richtek@gmail.com
Subject: [PATCH 2/2] regulator: mt6360: Add power off sequence config for default-on power
Date: Wed, 2 Jun 2021 14:54:35 +0800 [thread overview]
Message-ID: <1622616875-22740-2-git-send-email-u0084500@gmail.com> (raw)
In-Reply-To: <1622616875-22740-1-git-send-email-u0084500@gmail.com>
From: ChiYuan Huang <cy_huang@richtek.com>
Add power off sequence config for default-on power.
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
Hi,
Originally, we think it must write in platform dependent code like as bootloader.
But after the evaluation, it must write only when system normal halt or power_off.
For the other cases, just follow HW immediate off by default.
---
drivers/regulator/mt6360-regulator.c | 37 +++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/mt6360-regulator.c b/drivers/regulator/mt6360-regulator.c
index 4d34be9..6625f8f 100644
--- a/drivers/regulator/mt6360-regulator.c
+++ b/drivers/regulator/mt6360-regulator.c
@@ -9,12 +9,17 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
+#include <linux/reboot.h>
#include <linux/regmap.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/machine.h>
#include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+#define MT6360_REG_BUCK1_SEQTD 0x117
+#define MT6360_SEQOFF_REGNUM 4
+
enum {
MT6360_REGULATOR_BUCK1 = 0,
MT6360_REGULATOR_BUCK2,
@@ -45,6 +50,9 @@ struct mt6360_regulator_desc {
struct mt6360_regulator_data {
struct device *dev;
struct regmap *regmap;
+ struct notifier_block reboot_notifier;
+ /* Only for BUCK1/BUCK2/LDO7/LDO6, these are default on power */
+ u8 power_off_seq[MT6360_SEQOFF_REGNUM];
};
static irqreturn_t mt6360_pgb_event_handler(int irq, void *data)
@@ -394,10 +402,28 @@ static int mt6360_regulator_irq_register(struct platform_device *pdev,
return 0;
}
+static int reboot_notify_call(struct notifier_block *nb, unsigned long action, void *data)
+{
+ struct mt6360_regulator_data *mrd = container_of(nb, struct mt6360_regulator_data,
+ reboot_notifier);
+ int ret;
+
+ if (action != SYS_HALT && action != SYS_POWER_OFF)
+ return NOTIFY_DONE;
+
+ ret = regmap_raw_write(mrd->regmap, MT6360_REG_BUCK1_SEQTD, mrd->power_off_seq,
+ MT6360_SEQOFF_REGNUM);
+ if (ret)
+ dev_err(mrd->dev, "Failed to apply the power off sequence\n");
+
+ return NOTIFY_DONE;
+}
+
static int mt6360_regulator_probe(struct platform_device *pdev)
{
struct mt6360_regulator_data *mrd;
struct regulator_config config = {};
+ struct fwnode_handle *fwnode;
int i, ret;
mrd = devm_kzalloc(&pdev->dev, sizeof(*mrd), GFP_KERNEL);
@@ -434,7 +460,16 @@ static int mt6360_regulator_probe(struct platform_device *pdev)
}
}
- return 0;
+ fwnode = device_get_named_child_node(pdev->dev.parent, "regulator");
+ if (fwnode) {
+ ret = fwnode_property_read_u8_array(fwnode, "mediatek,power-off-sequence",
+ mrd->power_off_seq, MT6360_SEQOFF_REGNUM);
+ if (ret)
+ dev_warn(&pdev->dev, "Use no delay immediate off by default [%d]\n", ret);
+ }
+
+ mrd->reboot_notifier.notifier_call = reboot_notify_call;
+ return devm_register_reboot_notifier(&pdev->dev, &mrd->reboot_notifier);
}
static const struct platform_device_id mt6360_regulator_id_table[] = {
--
2.7.4
next prev parent reply other threads:[~2021-06-02 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 6:54 [PATCH 1/2] regulator: mt6360: Add optional mediatek.power-off-sequence in bindings document cy_huang
2021-06-02 6:54 ` cy_huang [this message]
2021-06-11 20:16 ` Rob Herring
2021-06-14 15:04 ` ChiYuan Huang
2021-06-17 16:29 ` Mark Brown
2021-06-18 3:28 ` ChiYuan Huang
2021-06-17 16:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622616875-22740-2-git-send-email-u0084500@gmail.com \
--to=u0084500@gmail.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).