devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v16 RESEND 0/7] of: add display helper
@ 2013-01-21 11:07 Steffen Trumtrar
  2013-01-22 21:50 ` Rob Clark
  0 siblings, 1 reply; 10+ messages in thread
From: Steffen Trumtrar @ 2013-01-21 11:07 UTC (permalink / raw)
  To: devicetree-discuss, David Airlie
  Cc: Steffen Trumtrar, Rob Herring, linux-fbdev, dri-devel,
	Laurent Pinchart, Thierry Reding, Guennady Liakhovetski,
	linux-media, Tomi Valkeinen, Stephen Warren,
	Florian Tobias Schandinat, Rob Clark, Leela Krishna Amudala,
	Mohammed, Afzal, kernel

Hi!

There was still no maintainer, that commented, ack'd, nack'd, apply'd the
series. So, this is just a resend.
The patches were tested with:

	- v15 on Tegra by Thierry
	- sh-mobile-lcdcfb by Laurent
	- MX53QSB by Marek
	- Exynos: smdk5250 by Leela
	- AM335X EVM & AM335X EVM-SK by Afzal
	- imx6q: sabrelite, sabresd by Philipp and me
	- imx53: tqma53/mba53 by me


Changes since v15:
        - move include/linux/{videomode,display_timing}.h to include/video
        - move include/linux/of_{videomode,display_timing}.h to include/video
        - reimplement flags: add VESA flags and data flags
        - let pixelclock in struct videomode be unsigned long
        - rename of_display_timings_exists to of_display_timings_exist
        - revise logging/error messages: replace __func__ with np->full_name
        - rename pixelclk-inverted to pixelclk-active
        - revise comments in code

Changes since v14:
        - fix "const struct *" warning
                (reported by: Leela Krishna Amudala <l.krishna@samsung.com>)
        - return -EINVAL when htotal or vtotal are zero
        - remove unreachable code in of_get_display_timings
        - include headers in .c files and not implicit in .h
        - sort includes alphabetically
        - fix lower/uppercase in binding documentation
        - rebase onto v3.7-rc7

Changes since v13:
        - fix "const struct *" warning
                (reported by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>)
        - prevent division by zero in fb_videomode_from_videomode

Changes since v12:
        - rename struct display_timing to via_display_timing in via subsystem
        - fix refreshrate calculation
        - fix "const struct *" warnings
                (reported by: Manjunathappa, Prakash <prakash.pm@ti.com>)
        - some CodingStyle fixes
        - rewrite parts of commit messages and display-timings.txt
        - let display_timing_get_value get all values instead of just typical

Changes since v11:
        - make pointers const where applicable
        - add reviewed-by Laurent Pinchart

Changes since v10:
        - fix function name (drm_)display_mode_from_videomode
        - add acked-by, reviewed-by, tested-by

Changes since v9:
        - don't leak memory when previous timings were correct
        - CodingStyle fixes
        - move blank lines around

Changes since v8:
        - fix memory leaks
        - change API to be more consistent (foo_from_bar(struct bar, struct foo))
        - include headers were necessary
        - misc minor bugfixes

Changes since v7:
        - move of_xxx to drivers/video
        - remove non-binding documentation from display-timings.txt
        - squash display_timings and videomode in one patch
        - misc minor fixes

Changes since v6:
        - get rid of some empty lines etc.
        - move functions to their subsystems
        - split of_ from non-of_ functions
        - add at least some kerneldoc to some functions

Changes since v5:
        - removed all display stuff and just describe timings

Changes since v4:
        - refactored functions

Changes since v3:
        - print error messages
        - free alloced memory
        - general cleanup

Changes since v2:
        - use hardware-near property-names
        - provide a videomode structure
        - allow ranges for all properties (<min,typ,max>)
        - functions to get display_mode or fb_videomode


Regards,
Steffen


Steffen Trumtrar (7):
  viafb: rename display_timing to via_display_timing
  video: add display_timing and videomode
  video: add of helper for display timings/videomode
  fbmon: add videomode helpers
  fbmon: add of_videomode helpers
  drm_modes: add videomode helpers
  drm_modes: add of_videomode helpers

 .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
 drivers/gpu/drm/drm_modes.c                        |   70 ++++++
 drivers/video/Kconfig                              |   21 ++
 drivers/video/Makefile                             |    4 +
 drivers/video/display_timing.c                     |   24 ++
 drivers/video/fbmon.c                              |   94 ++++++++
 drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
 drivers/video/of_videomode.c                       |   54 +++++
 drivers/video/via/hw.c                             |    6 +-
 drivers/video/via/hw.h                             |    2 +-
 drivers/video/via/lcd.c                            |    2 +-
 drivers/video/via/share.h                          |    2 +-
 drivers/video/via/via_modesetting.c                |    8 +-
 drivers/video/via/via_modesetting.h                |    6 +-
 drivers/video/videomode.c                          |   39 ++++
 include/drm/drmP.h                                 |    9 +
 include/linux/fb.h                                 |    8 +
 include/video/display_timing.h                     |  124 ++++++++++
 include/video/of_display_timing.h                  |   20 ++
 include/video/of_videomode.h                       |   18 ++
 include/video/videomode.h                          |   48 ++++
 21 files changed, 894 insertions(+), 13 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
 create mode 100644 drivers/video/display_timing.c
 create mode 100644 drivers/video/of_display_timing.c
 create mode 100644 drivers/video/of_videomode.c
 create mode 100644 drivers/video/videomode.c
 create mode 100644 include/video/display_timing.h
 create mode 100644 include/video/of_display_timing.h
 create mode 100644 include/video/of_videomode.h
 create mode 100644 include/video/videomode.h

-- 
1.7.10.4

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-21 11:07 Steffen Trumtrar
@ 2013-01-22 21:50 ` Rob Clark
  2013-01-23  9:12   ` Steffen Trumtrar
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Clark @ 2013-01-22 21:50 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: devicetree-discuss, David Airlie, Rob Herring, linux-fbdev,
	dri-devel, Laurent Pinchart, Thierry Reding,
	Guennady Liakhovetski, linux-media, Tomi Valkeinen,
	Stephen Warren, Florian Tobias Schandinat, Leela Krishna Amudala,
	Mohammed, Afzal, kernel

On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar
<s.trumtrar@pengutronix.de> wrote:
> Hi!
>
> There was still no maintainer, that commented, ack'd, nack'd, apply'd the
> series. So, this is just a resend.
> The patches were tested with:
>
>         - v15 on Tegra by Thierry
>         - sh-mobile-lcdcfb by Laurent
>         - MX53QSB by Marek
>         - Exynos: smdk5250 by Leela
>         - AM335X EVM & AM335X EVM-SK by Afzal
>         - imx6q: sabrelite, sabresd by Philipp and me
>         - imx53: tqma53/mba53 by me


btw, you can add my tested-by for this series..  I've been using them
for the tilcdc lcd-panel output driver support.

BR,
-R


>
>
> Changes since v15:
>         - move include/linux/{videomode,display_timing}.h to include/video
>         - move include/linux/of_{videomode,display_timing}.h to include/video
>         - reimplement flags: add VESA flags and data flags
>         - let pixelclock in struct videomode be unsigned long
>         - rename of_display_timings_exists to of_display_timings_exist
>         - revise logging/error messages: replace __func__ with np->full_name
>         - rename pixelclk-inverted to pixelclk-active
>         - revise comments in code
>
> Changes since v14:
>         - fix "const struct *" warning
>                 (reported by: Leela Krishna Amudala <l.krishna@samsung.com>)
>         - return -EINVAL when htotal or vtotal are zero
>         - remove unreachable code in of_get_display_timings
>         - include headers in .c files and not implicit in .h
>         - sort includes alphabetically
>         - fix lower/uppercase in binding documentation
>         - rebase onto v3.7-rc7
>
> Changes since v13:
>         - fix "const struct *" warning
>                 (reported by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>)
>         - prevent division by zero in fb_videomode_from_videomode
>
> Changes since v12:
>         - rename struct display_timing to via_display_timing in via subsystem
>         - fix refreshrate calculation
>         - fix "const struct *" warnings
>                 (reported by: Manjunathappa, Prakash <prakash.pm@ti.com>)
>         - some CodingStyle fixes
>         - rewrite parts of commit messages and display-timings.txt
>         - let display_timing_get_value get all values instead of just typical
>
> Changes since v11:
>         - make pointers const where applicable
>         - add reviewed-by Laurent Pinchart
>
> Changes since v10:
>         - fix function name (drm_)display_mode_from_videomode
>         - add acked-by, reviewed-by, tested-by
>
> Changes since v9:
>         - don't leak memory when previous timings were correct
>         - CodingStyle fixes
>         - move blank lines around
>
> Changes since v8:
>         - fix memory leaks
>         - change API to be more consistent (foo_from_bar(struct bar, struct foo))
>         - include headers were necessary
>         - misc minor bugfixes
>
> Changes since v7:
>         - move of_xxx to drivers/video
>         - remove non-binding documentation from display-timings.txt
>         - squash display_timings and videomode in one patch
>         - misc minor fixes
>
> Changes since v6:
>         - get rid of some empty lines etc.
>         - move functions to their subsystems
>         - split of_ from non-of_ functions
>         - add at least some kerneldoc to some functions
>
> Changes since v5:
>         - removed all display stuff and just describe timings
>
> Changes since v4:
>         - refactored functions
>
> Changes since v3:
>         - print error messages
>         - free alloced memory
>         - general cleanup
>
> Changes since v2:
>         - use hardware-near property-names
>         - provide a videomode structure
>         - allow ranges for all properties (<min,typ,max>)
>         - functions to get display_mode or fb_videomode
>
>
> Regards,
> Steffen
>
>
> Steffen Trumtrar (7):
>   viafb: rename display_timing to via_display_timing
>   video: add display_timing and videomode
>   video: add of helper for display timings/videomode
>   fbmon: add videomode helpers
>   fbmon: add of_videomode helpers
>   drm_modes: add videomode helpers
>   drm_modes: add of_videomode helpers
>
>  .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
>  drivers/gpu/drm/drm_modes.c                        |   70 ++++++
>  drivers/video/Kconfig                              |   21 ++
>  drivers/video/Makefile                             |    4 +
>  drivers/video/display_timing.c                     |   24 ++
>  drivers/video/fbmon.c                              |   94 ++++++++
>  drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
>  drivers/video/of_videomode.c                       |   54 +++++
>  drivers/video/via/hw.c                             |    6 +-
>  drivers/video/via/hw.h                             |    2 +-
>  drivers/video/via/lcd.c                            |    2 +-
>  drivers/video/via/share.h                          |    2 +-
>  drivers/video/via/via_modesetting.c                |    8 +-
>  drivers/video/via/via_modesetting.h                |    6 +-
>  drivers/video/videomode.c                          |   39 ++++
>  include/drm/drmP.h                                 |    9 +
>  include/linux/fb.h                                 |    8 +
>  include/video/display_timing.h                     |  124 ++++++++++
>  include/video/of_display_timing.h                  |   20 ++
>  include/video/of_videomode.h                       |   18 ++
>  include/video/videomode.h                          |   48 ++++
>  21 files changed, 894 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
>  create mode 100644 drivers/video/display_timing.c
>  create mode 100644 drivers/video/of_display_timing.c
>  create mode 100644 drivers/video/of_videomode.c
>  create mode 100644 drivers/video/videomode.c
>  create mode 100644 include/video/display_timing.h
>  create mode 100644 include/video/of_display_timing.h
>  create mode 100644 include/video/of_videomode.h
>  create mode 100644 include/video/videomode.h
>
> --
> 1.7.10.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-22 21:50 ` Rob Clark
@ 2013-01-23  9:12   ` Steffen Trumtrar
  2013-01-24  0:15     ` Dave Airlie
       [not found]     ` <20130123091202.GA11828-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
  0 siblings, 2 replies; 10+ messages in thread
From: Steffen Trumtrar @ 2013-01-23  9:12 UTC (permalink / raw)
  To: Rob Clark
  Cc: devicetree-discuss, David Airlie, Rob Herring, linux-fbdev,
	dri-devel, Laurent Pinchart, Thierry Reding,
	Guennady Liakhovetski, linux-media, Tomi Valkeinen,
	Stephen Warren, Florian Tobias Schandinat, Leela Krishna Amudala,
	Mohammed, Afzal, kernel

On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
> On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar
> <s.trumtrar@pengutronix.de> wrote:
> > Hi!
> >
> > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
> > series. So, this is just a resend.
> > The patches were tested with:
> >
> >         - v15 on Tegra by Thierry
> >         - sh-mobile-lcdcfb by Laurent
> >         - MX53QSB by Marek
> >         - Exynos: smdk5250 by Leela
> >         - AM335X EVM & AM335X EVM-SK by Afzal
> >         - imx6q: sabrelite, sabresd by Philipp and me
> >         - imx53: tqma53/mba53 by me
> 
> 
> btw, you can add my tested-by for this series..  I've been using them
> for the tilcdc lcd-panel output driver support.
> 

Thanks. The more drivers the merrier ;-)

Steffen

> >
> >
> > Changes since v15:
> >         - move include/linux/{videomode,display_timing}.h to include/video
> >         - move include/linux/of_{videomode,display_timing}.h to include/video
> >         - reimplement flags: add VESA flags and data flags
> >         - let pixelclock in struct videomode be unsigned long
> >         - rename of_display_timings_exists to of_display_timings_exist
> >         - revise logging/error messages: replace __func__ with np->full_name
> >         - rename pixelclk-inverted to pixelclk-active
> >         - revise comments in code
> >
> > Changes since v14:
> >         - fix "const struct *" warning
> >                 (reported by: Leela Krishna Amudala <l.krishna@samsung.com>)
> >         - return -EINVAL when htotal or vtotal are zero
> >         - remove unreachable code in of_get_display_timings
> >         - include headers in .c files and not implicit in .h
> >         - sort includes alphabetically
> >         - fix lower/uppercase in binding documentation
> >         - rebase onto v3.7-rc7
> >
> > Changes since v13:
> >         - fix "const struct *" warning
> >                 (reported by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>)
> >         - prevent division by zero in fb_videomode_from_videomode
> >
> > Changes since v12:
> >         - rename struct display_timing to via_display_timing in via subsystem
> >         - fix refreshrate calculation
> >         - fix "const struct *" warnings
> >                 (reported by: Manjunathappa, Prakash <prakash.pm@ti.com>)
> >         - some CodingStyle fixes
> >         - rewrite parts of commit messages and display-timings.txt
> >         - let display_timing_get_value get all values instead of just typical
> >
> > Changes since v11:
> >         - make pointers const where applicable
> >         - add reviewed-by Laurent Pinchart
> >
> > Changes since v10:
> >         - fix function name (drm_)display_mode_from_videomode
> >         - add acked-by, reviewed-by, tested-by
> >
> > Changes since v9:
> >         - don't leak memory when previous timings were correct
> >         - CodingStyle fixes
> >         - move blank lines around
> >
> > Changes since v8:
> >         - fix memory leaks
> >         - change API to be more consistent (foo_from_bar(struct bar, struct foo))
> >         - include headers were necessary
> >         - misc minor bugfixes
> >
> > Changes since v7:
> >         - move of_xxx to drivers/video
> >         - remove non-binding documentation from display-timings.txt
> >         - squash display_timings and videomode in one patch
> >         - misc minor fixes
> >
> > Changes since v6:
> >         - get rid of some empty lines etc.
> >         - move functions to their subsystems
> >         - split of_ from non-of_ functions
> >         - add at least some kerneldoc to some functions
> >
> > Changes since v5:
> >         - removed all display stuff and just describe timings
> >
> > Changes since v4:
> >         - refactored functions
> >
> > Changes since v3:
> >         - print error messages
> >         - free alloced memory
> >         - general cleanup
> >
> > Changes since v2:
> >         - use hardware-near property-names
> >         - provide a videomode structure
> >         - allow ranges for all properties (<min,typ,max>)
> >         - functions to get display_mode or fb_videomode
> >
> >
> > Regards,
> > Steffen
> >
> >
> > Steffen Trumtrar (7):
> >   viafb: rename display_timing to via_display_timing
> >   video: add display_timing and videomode
> >   video: add of helper for display timings/videomode
> >   fbmon: add videomode helpers
> >   fbmon: add of_videomode helpers
> >   drm_modes: add videomode helpers
> >   drm_modes: add of_videomode helpers
> >
> >  .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
> >  drivers/gpu/drm/drm_modes.c                        |   70 ++++++
> >  drivers/video/Kconfig                              |   21 ++
> >  drivers/video/Makefile                             |    4 +
> >  drivers/video/display_timing.c                     |   24 ++
> >  drivers/video/fbmon.c                              |   94 ++++++++
> >  drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
> >  drivers/video/of_videomode.c                       |   54 +++++
> >  drivers/video/via/hw.c                             |    6 +-
> >  drivers/video/via/hw.h                             |    2 +-
> >  drivers/video/via/lcd.c                            |    2 +-
> >  drivers/video/via/share.h                          |    2 +-
> >  drivers/video/via/via_modesetting.c                |    8 +-
> >  drivers/video/via/via_modesetting.h                |    6 +-
> >  drivers/video/videomode.c                          |   39 ++++
> >  include/drm/drmP.h                                 |    9 +
> >  include/linux/fb.h                                 |    8 +
> >  include/video/display_timing.h                     |  124 ++++++++++
> >  include/video/of_display_timing.h                  |   20 ++
> >  include/video/of_videomode.h                       |   18 ++
> >  include/video/videomode.h                          |   48 ++++
> >  21 files changed, 894 insertions(+), 13 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
> >  create mode 100644 drivers/video/display_timing.c
> >  create mode 100644 drivers/video/of_display_timing.c
> >  create mode 100644 drivers/video/of_videomode.c
> >  create mode 100644 drivers/video/videomode.c
> >  create mode 100644 include/video/display_timing.h
> >  create mode 100644 include/video/of_display_timing.h
> >  create mode 100644 include/video/of_videomode.h
> >  create mode 100644 include/video/videomode.h
> >
> > --
> > 1.7.10.4
> >
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-23  9:12   ` Steffen Trumtrar
@ 2013-01-24  0:15     ` Dave Airlie
  2013-01-24  7:56       ` Steffen Trumtrar
       [not found]     ` <20130123091202.GA11828-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
  1 sibling, 1 reply; 10+ messages in thread
From: Dave Airlie @ 2013-01-24  0:15 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: Rob Clark, devicetree-discuss, David Airlie, Rob Herring,
	linux-fbdev, dri-devel, Laurent Pinchart, Thierry Reding,
	Guennady Liakhovetski, linux-media, Tomi Valkeinen,
	Stephen Warren, Florian Tobias Schandinat, Leela Krishna Amudala,
	Mohammed, Afzal, kernel

>> > Hi!
>> >
>> > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
>> > series. So, this is just a resend.
>> > The patches were tested with:
>> >
>> >         - v15 on Tegra by Thierry
>> >         - sh-mobile-lcdcfb by Laurent
>> >         - MX53QSB by Marek
>> >         - Exynos: smdk5250 by Leela
>> >         - AM335X EVM & AM335X EVM-SK by Afzal
>> >         - imx6q: sabrelite, sabresd by Philipp and me
>> >         - imx53: tqma53/mba53 by me
>>
>>
>> btw, you can add my tested-by for this series..  I've been using them
>> for the tilcdc lcd-panel output driver support.
>>
>
> Thanks. The more drivers the merrier ;-)
>

I'll probably merge these via my tree for lack of anyone else doing
it. I just don't want to end up as the fbdev maintainer by default,
maybe if we move the console stuff out of drivers/video to somewhere
else I'd be willing to look after it, but the thought of maintaining
fbdev drivers would drive me to a liver transplant.

Dave.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
       [not found]     ` <20130123091202.GA11828-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2013-01-24  5:14       ` Leela Krishna Amudala
  2013-01-24  8:19         ` Steffen Trumtrar
  0 siblings, 1 reply; 10+ messages in thread
From: Leela Krishna Amudala @ 2013-01-24  5:14 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA, Mohammed, Afzal, David Airlie,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	Florian Tobias Schandinat,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Rob Clark,
	Tomi Valkeinen, Laurent Pinchart, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	Guennady Liakhovetski, linux-media-u79uwXL29TY76Z2rM5mHXA

Steffen,

You can add my tested-by for this series.. :)
I have been using them for Exynos: smdk5250 board.

On Wed, Jan 23, 2013 at 2:42 PM, Steffen Trumtrar
<s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
> On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
>> On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar
>> <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote:
>> > Hi!
>> >
>> > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
>> > series. So, this is just a resend.
>> > The patches were tested with:
>> >
>> >         - v15 on Tegra by Thierry
>> >         - sh-mobile-lcdcfb by Laurent
>> >         - MX53QSB by Marek
>> >         - Exynos: smdk5250 by Leela
>> >         - AM335X EVM & AM335X EVM-SK by Afzal
>> >         - imx6q: sabrelite, sabresd by Philipp and me
>> >         - imx53: tqma53/mba53 by me
>>
>>
>> btw, you can add my tested-by for this series..  I've been using them
>> for the tilcdc lcd-panel output driver support.
>>
>
> Thanks. The more drivers the merrier ;-)
>
> Steffen
>
>> >
>> >
>> > Changes since v15:
>> >         - move include/linux/{videomode,display_timing}.h to include/video
>> >         - move include/linux/of_{videomode,display_timing}.h to include/video
>> >         - reimplement flags: add VESA flags and data flags
>> >         - let pixelclock in struct videomode be unsigned long
>> >         - rename of_display_timings_exists to of_display_timings_exist
>> >         - revise logging/error messages: replace __func__ with np->full_name
>> >         - rename pixelclk-inverted to pixelclk-active
>> >         - revise comments in code
>> >
>> > Changes since v14:
>> >         - fix "const struct *" warning
>> >                 (reported by: Leela Krishna Amudala <l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>)
>> >         - return -EINVAL when htotal or vtotal are zero
>> >         - remove unreachable code in of_get_display_timings
>> >         - include headers in .c files and not implicit in .h
>> >         - sort includes alphabetically
>> >         - fix lower/uppercase in binding documentation
>> >         - rebase onto v3.7-rc7
>> >
>> > Changes since v13:
>> >         - fix "const struct *" warning
>> >                 (reported by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>)
>> >         - prevent division by zero in fb_videomode_from_videomode
>> >
>> > Changes since v12:
>> >         - rename struct display_timing to via_display_timing in via subsystem
>> >         - fix refreshrate calculation
>> >         - fix "const struct *" warnings
>> >                 (reported by: Manjunathappa, Prakash <prakash.pm-l0cyMroinI0@public.gmane.org>)
>> >         - some CodingStyle fixes
>> >         - rewrite parts of commit messages and display-timings.txt
>> >         - let display_timing_get_value get all values instead of just typical
>> >
>> > Changes since v11:
>> >         - make pointers const where applicable
>> >         - add reviewed-by Laurent Pinchart
>> >
>> > Changes since v10:
>> >         - fix function name (drm_)display_mode_from_videomode
>> >         - add acked-by, reviewed-by, tested-by
>> >
>> > Changes since v9:
>> >         - don't leak memory when previous timings were correct
>> >         - CodingStyle fixes
>> >         - move blank lines around
>> >
>> > Changes since v8:
>> >         - fix memory leaks
>> >         - change API to be more consistent (foo_from_bar(struct bar, struct foo))
>> >         - include headers were necessary
>> >         - misc minor bugfixes
>> >
>> > Changes since v7:
>> >         - move of_xxx to drivers/video
>> >         - remove non-binding documentation from display-timings.txt
>> >         - squash display_timings and videomode in one patch
>> >         - misc minor fixes
>> >
>> > Changes since v6:
>> >         - get rid of some empty lines etc.
>> >         - move functions to their subsystems
>> >         - split of_ from non-of_ functions
>> >         - add at least some kerneldoc to some functions
>> >
>> > Changes since v5:
>> >         - removed all display stuff and just describe timings
>> >
>> > Changes since v4:
>> >         - refactored functions
>> >
>> > Changes since v3:
>> >         - print error messages
>> >         - free alloced memory
>> >         - general cleanup
>> >
>> > Changes since v2:
>> >         - use hardware-near property-names
>> >         - provide a videomode structure
>> >         - allow ranges for all properties (<min,typ,max>)
>> >         - functions to get display_mode or fb_videomode
>> >
>> >
>> > Regards,
>> > Steffen
>> >
>> >
>> > Steffen Trumtrar (7):
>> >   viafb: rename display_timing to via_display_timing
>> >   video: add display_timing and videomode
>> >   video: add of helper for display timings/videomode
>> >   fbmon: add videomode helpers
>> >   fbmon: add of_videomode helpers
>> >   drm_modes: add videomode helpers
>> >   drm_modes: add of_videomode helpers
>> >
>> >  .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
>> >  drivers/gpu/drm/drm_modes.c                        |   70 ++++++
>> >  drivers/video/Kconfig                              |   21 ++
>> >  drivers/video/Makefile                             |    4 +
>> >  drivers/video/display_timing.c                     |   24 ++
>> >  drivers/video/fbmon.c                              |   94 ++++++++
>> >  drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
>> >  drivers/video/of_videomode.c                       |   54 +++++
>> >  drivers/video/via/hw.c                             |    6 +-
>> >  drivers/video/via/hw.h                             |    2 +-
>> >  drivers/video/via/lcd.c                            |    2 +-
>> >  drivers/video/via/share.h                          |    2 +-
>> >  drivers/video/via/via_modesetting.c                |    8 +-
>> >  drivers/video/via/via_modesetting.h                |    6 +-
>> >  drivers/video/videomode.c                          |   39 ++++
>> >  include/drm/drmP.h                                 |    9 +
>> >  include/linux/fb.h                                 |    8 +
>> >  include/video/display_timing.h                     |  124 ++++++++++
>> >  include/video/of_display_timing.h                  |   20 ++
>> >  include/video/of_videomode.h                       |   18 ++
>> >  include/video/videomode.h                          |   48 ++++
>> >  21 files changed, 894 insertions(+), 13 deletions(-)
>> >  create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
>> >  create mode 100644 drivers/video/display_timing.c
>> >  create mode 100644 drivers/video/of_display_timing.c
>> >  create mode 100644 drivers/video/of_videomode.c
>> >  create mode 100644 drivers/video/videomode.c
>> >  create mode 100644 include/video/display_timing.h
>> >  create mode 100644 include/video/of_display_timing.h
>> >  create mode 100644 include/video/of_videomode.h
>> >  create mode 100644 include/video/videomode.h
>> >
>> > --
>> > 1.7.10.4
>> >
>>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-24  0:15     ` Dave Airlie
@ 2013-01-24  7:56       ` Steffen Trumtrar
  0 siblings, 0 replies; 10+ messages in thread
From: Steffen Trumtrar @ 2013-01-24  7:56 UTC (permalink / raw)
  To: Dave Airlie
  Cc: Rob Clark, devicetree-discuss, David Airlie, Rob Herring,
	linux-fbdev, dri-devel, Laurent Pinchart, Thierry Reding,
	Guennady Liakhovetski, linux-media, Tomi Valkeinen,
	Stephen Warren, Florian Tobias Schandinat, Leela Krishna Amudala,
	Mohammed, Afzal, kernel

On Thu, Jan 24, 2013 at 10:15:54AM +1000, Dave Airlie wrote:
> >> > Hi!
> >> >
> >> > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
> >> > series. So, this is just a resend.
> >> > The patches were tested with:
> >> >
> >> >         - v15 on Tegra by Thierry
> >> >         - sh-mobile-lcdcfb by Laurent
> >> >         - MX53QSB by Marek
> >> >         - Exynos: smdk5250 by Leela
> >> >         - AM335X EVM & AM335X EVM-SK by Afzal
> >> >         - imx6q: sabrelite, sabresd by Philipp and me
> >> >         - imx53: tqma53/mba53 by me
> >>
> >>
> >> btw, you can add my tested-by for this series..  I've been using them
> >> for the tilcdc lcd-panel output driver support.
> >>
> >
> > Thanks. The more drivers the merrier ;-)
> >
> 
> I'll probably merge these via my tree for lack of anyone else doing
> it. I just don't want to end up as the fbdev maintainer by default,

\o/ very good to hear. Thanks.

> maybe if we move the console stuff out of drivers/video to somewhere

Okay. That confused me for a second, but it doesn't seem to be directed at
me *phew*.

> else I'd be willing to look after it, but the thought of maintaining
> fbdev drivers would drive me to a liver transplant.
> 
> Dave.
> 

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-24  5:14       ` Leela Krishna Amudala
@ 2013-01-24  8:19         ` Steffen Trumtrar
  2013-01-24  8:47           ` Mohammed, Afzal
  0 siblings, 1 reply; 10+ messages in thread
From: Steffen Trumtrar @ 2013-01-24  8:19 UTC (permalink / raw)
  To: Leela Krishna Amudala
  Cc: linux-fbdev, Mohammed, Afzal, David Airlie, devicetree-discuss,
	Florian Tobias Schandinat, dri-devel, Rob Clark, Tomi Valkeinen,
	Laurent Pinchart, kernel, Guennady Liakhovetski, linux-media

On Thu, Jan 24, 2013 at 10:44:50AM +0530, Leela Krishna Amudala wrote:
> Steffen,
> 
> You can add my tested-by for this series.. :)
> I have been using them for Exynos: smdk5250 board.
> 

Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4.

Regards,
Steffen

> On Wed, Jan 23, 2013 at 2:42 PM, Steffen Trumtrar
> <s.trumtrar@pengutronix.de> wrote:
> > On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
> >> On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar
> >> <s.trumtrar@pengutronix.de> wrote:
> >> > Hi!
> >> >
> >> > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
> >> > series. So, this is just a resend.
> >> > The patches were tested with:
> >> >
> >> >         - v15 on Tegra by Thierry
> >> >         - sh-mobile-lcdcfb by Laurent
> >> >         - MX53QSB by Marek
> >> >         - Exynos: smdk5250 by Leela
> >> >         - AM335X EVM & AM335X EVM-SK by Afzal
> >> >         - imx6q: sabrelite, sabresd by Philipp and me
> >> >         - imx53: tqma53/mba53 by me
> >>
> >>
> >> btw, you can add my tested-by for this series..  I've been using them
> >> for the tilcdc lcd-panel output driver support.
> >>
> >
> > Thanks. The more drivers the merrier ;-)
> >
> > Steffen
> >
> >> >
> >> >
> >> > Changes since v15:
> >> >         - move include/linux/{videomode,display_timing}.h to include/video
> >> >         - move include/linux/of_{videomode,display_timing}.h to include/video
> >> >         - reimplement flags: add VESA flags and data flags
> >> >         - let pixelclock in struct videomode be unsigned long
> >> >         - rename of_display_timings_exists to of_display_timings_exist
> >> >         - revise logging/error messages: replace __func__ with np->full_name
> >> >         - rename pixelclk-inverted to pixelclk-active
> >> >         - revise comments in code
> >> >
> >> > Changes since v14:
> >> >         - fix "const struct *" warning
> >> >                 (reported by: Leela Krishna Amudala <l.krishna@samsung.com>)
> >> >         - return -EINVAL when htotal or vtotal are zero
> >> >         - remove unreachable code in of_get_display_timings
> >> >         - include headers in .c files and not implicit in .h
> >> >         - sort includes alphabetically
> >> >         - fix lower/uppercase in binding documentation
> >> >         - rebase onto v3.7-rc7
> >> >
> >> > Changes since v13:
> >> >         - fix "const struct *" warning
> >> >                 (reported by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>)
> >> >         - prevent division by zero in fb_videomode_from_videomode
> >> >
> >> > Changes since v12:
> >> >         - rename struct display_timing to via_display_timing in via subsystem
> >> >         - fix refreshrate calculation
> >> >         - fix "const struct *" warnings
> >> >                 (reported by: Manjunathappa, Prakash <prakash.pm@ti.com>)
> >> >         - some CodingStyle fixes
> >> >         - rewrite parts of commit messages and display-timings.txt
> >> >         - let display_timing_get_value get all values instead of just typical
> >> >
> >> > Changes since v11:
> >> >         - make pointers const where applicable
> >> >         - add reviewed-by Laurent Pinchart
> >> >
> >> > Changes since v10:
> >> >         - fix function name (drm_)display_mode_from_videomode
> >> >         - add acked-by, reviewed-by, tested-by
> >> >
> >> > Changes since v9:
> >> >         - don't leak memory when previous timings were correct
> >> >         - CodingStyle fixes
> >> >         - move blank lines around
> >> >
> >> > Changes since v8:
> >> >         - fix memory leaks
> >> >         - change API to be more consistent (foo_from_bar(struct bar, struct foo))
> >> >         - include headers were necessary
> >> >         - misc minor bugfixes
> >> >
> >> > Changes since v7:
> >> >         - move of_xxx to drivers/video
> >> >         - remove non-binding documentation from display-timings.txt
> >> >         - squash display_timings and videomode in one patch
> >> >         - misc minor fixes
> >> >
> >> > Changes since v6:
> >> >         - get rid of some empty lines etc.
> >> >         - move functions to their subsystems
> >> >         - split of_ from non-of_ functions
> >> >         - add at least some kerneldoc to some functions
> >> >
> >> > Changes since v5:
> >> >         - removed all display stuff and just describe timings
> >> >
> >> > Changes since v4:
> >> >         - refactored functions
> >> >
> >> > Changes since v3:
> >> >         - print error messages
> >> >         - free alloced memory
> >> >         - general cleanup
> >> >
> >> > Changes since v2:
> >> >         - use hardware-near property-names
> >> >         - provide a videomode structure
> >> >         - allow ranges for all properties (<min,typ,max>)
> >> >         - functions to get display_mode or fb_videomode
> >> >
> >> >
> >> > Regards,
> >> > Steffen
> >> >
> >> >
> >> > Steffen Trumtrar (7):
> >> >   viafb: rename display_timing to via_display_timing
> >> >   video: add display_timing and videomode
> >> >   video: add of helper for display timings/videomode
> >> >   fbmon: add videomode helpers
> >> >   fbmon: add of_videomode helpers
> >> >   drm_modes: add videomode helpers
> >> >   drm_modes: add of_videomode helpers
> >> >
> >> >  .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
> >> >  drivers/gpu/drm/drm_modes.c                        |   70 ++++++
> >> >  drivers/video/Kconfig                              |   21 ++
> >> >  drivers/video/Makefile                             |    4 +
> >> >  drivers/video/display_timing.c                     |   24 ++
> >> >  drivers/video/fbmon.c                              |   94 ++++++++
> >> >  drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
> >> >  drivers/video/of_videomode.c                       |   54 +++++
> >> >  drivers/video/via/hw.c                             |    6 +-
> >> >  drivers/video/via/hw.h                             |    2 +-
> >> >  drivers/video/via/lcd.c                            |    2 +-
> >> >  drivers/video/via/share.h                          |    2 +-
> >> >  drivers/video/via/via_modesetting.c                |    8 +-
> >> >  drivers/video/via/via_modesetting.h                |    6 +-
> >> >  drivers/video/videomode.c                          |   39 ++++
> >> >  include/drm/drmP.h                                 |    9 +
> >> >  include/linux/fb.h                                 |    8 +
> >> >  include/video/display_timing.h                     |  124 ++++++++++
> >> >  include/video/of_display_timing.h                  |   20 ++
> >> >  include/video/of_videomode.h                       |   18 ++
> >> >  include/video/videomode.h                          |   48 ++++
> >> >  21 files changed, 894 insertions(+), 13 deletions(-)
> >> >  create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
> >> >  create mode 100644 drivers/video/display_timing.c
> >> >  create mode 100644 drivers/video/of_display_timing.c
> >> >  create mode 100644 drivers/video/of_videomode.c
> >> >  create mode 100644 drivers/video/videomode.c
> >> >  create mode 100644 include/video/display_timing.h
> >> >  create mode 100644 include/video/of_display_timing.h
> >> >  create mode 100644 include/video/of_videomode.h
> >> >  create mode 100644 include/video/videomode.h
> >> >
> >> > --
> >> > 1.7.10.4
> >> >
> >>
> >
> > --
> > Pengutronix e.K.                           |                             |
> > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> _______________________________________________
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-24  8:19         ` Steffen Trumtrar
@ 2013-01-24  8:47           ` Mohammed, Afzal
  2013-01-25  8:04             ` Steffen Trumtrar
  0 siblings, 1 reply; 10+ messages in thread
From: Mohammed, Afzal @ 2013-01-24  8:47 UTC (permalink / raw)
  To: Steffen Trumtrar, Leela Krishna Amudala
  Cc: linux-fbdev@vger.kernel.org, David Airlie,
	devicetree-discuss@lists.ozlabs.org, Florian Tobias Schandinat,
	dri-devel@lists.freedesktop.org, Rob Clark, Valkeinen, Tomi,
	Laurent Pinchart, kernel@pengutronix.de, Guennady Liakhovetski,
	linux-media@vger.kernel.org

Hi Steffen,

On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote:

> Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4.

As you are going to have a v17, if you can fold the diff[1]
(that I mentioned earlier) into the patch,
"fbmon: add of_videomode helpers", it would be helpful. 

Regards
Afzal

[1]

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 58b9860..0ce30d1 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -716,9 +716,19 @@ extern void fb_destroy_modedb(struct fb_videomode *modedb);
 extern int fb_find_mode_cvt(struct fb_videomode *mode, int margins, int rb);
 extern unsigned char *fb_ddc_read(struct i2c_adapter *adapter);
 
+#if defined(CONFIG_OF_VIDEOMODE) && defined(CONFIG_FB_MODE_HELPERS)
 extern int of_get_fb_videomode(struct device_node *np,
                               struct fb_videomode *fb,
                               int index);
+#else
+static inline int of_get_fb_videomode(struct device_node *np,
+                                     struct fb_videomode *fb,
+                                     int index)
+{
+       return -EINVAL;
+}
+#endif
+
 extern int fb_videomode_from_videomode(const struct videomode *vm,
                                       struct fb_videomode *fbmode);


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
  2013-01-24  8:47           ` Mohammed, Afzal
@ 2013-01-25  8:04             ` Steffen Trumtrar
  0 siblings, 0 replies; 10+ messages in thread
From: Steffen Trumtrar @ 2013-01-25  8:04 UTC (permalink / raw)
  To: Mohammed, Afzal
  Cc: Leela Krishna Amudala, linux-fbdev@vger.kernel.org, David Airlie,
	devicetree-discuss@lists.ozlabs.org, Florian Tobias Schandinat,
	dri-devel@lists.freedesktop.org, Rob Clark, Valkeinen, Tomi,
	Laurent Pinchart, kernel@pengutronix.de, Guennady Liakhovetski,
	linux-media@vger.kernel.org

Hi Afzal,

On Thu, Jan 24, 2013 at 08:47:02AM +0000, Mohammed, Afzal wrote:
> Hi Steffen,
> 
> On Thu, Jan 24, 2013 at 13:49:58, Steffen Trumtrar wrote:
> 
> > Thanks. I'll use that opportunity for a v17 that is rebased onto 3.8-rc4.
> 
> As you are going to have a v17, if you can fold the diff[1]
> (that I mentioned earlier) into the patch,
> "fbmon: add of_videomode helpers", it would be helpful. 
> 

I thought about it and I will not include that patch. Sorry.
In one of the previous versions of the series I had something like that and
it was suggested to remove it. If I leave it like it is, one gets a compile
time error like you do. And that is correct, because you shouldn't use the
function if you do not have of_videomode enabled. You should use one of the
underlying functions that are non-DT and called by of_get_fb_videomode.

Regards,
Steffen

> Regards
> Afzal
> 
> [1]
> 
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 58b9860..0ce30d1 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -716,9 +716,19 @@ extern void fb_destroy_modedb(struct fb_videomode *modedb);
>  extern int fb_find_mode_cvt(struct fb_videomode *mode, int margins, int rb);
>  extern unsigned char *fb_ddc_read(struct i2c_adapter *adapter);
>  
> +#if defined(CONFIG_OF_VIDEOMODE) && defined(CONFIG_FB_MODE_HELPERS)
>  extern int of_get_fb_videomode(struct device_node *np,
>                                struct fb_videomode *fb,
>                                int index);
> +#else
> +static inline int of_get_fb_videomode(struct device_node *np,
> +                                     struct fb_videomode *fb,
> +                                     int index)
> +{
> +       return -EINVAL;
> +}
> +#endif
> +
>  extern int fb_videomode_from_videomode(const struct videomode *vm,
>                                        struct fb_videomode *fbmode);
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v16 RESEND 0/7] of: add display helper
@ 2013-02-01  7:40 Jingoo Han
  0 siblings, 0 replies; 10+ messages in thread
From: Jingoo Han @ 2013-02-01  7:40 UTC (permalink / raw)
  To: Steffen Trumtrar
  Cc: Rob Clark, linux-fbdev@vger.kernel.org, Mohammed, Afzal,
	Stephen Warren, devicetree-discuss@lists.ozlabs.org,
	Florian Tobias Schandinat, dri-devel@lists.freedesktop.org,
	Tomi Valkeinen, Rob Herring, Laurent Pinchart,
	kernel@pengutronix.de, Guennady Liakhovetski,
	linux-media@vger.kernel.org, Jingoo Han

Hi Steffen,

You can add my tested-by for this series.
I have tested them for Exynos: smdk4210 board.

Beat regards,
Jingoo Han

On Wednesday, January 23, 2013 6:12 PM, Steffen Trumtrar wrote
> On Tue, Jan 22, 2013 at 03:50:48PM -0600, Rob Clark wrote:
> > On Mon, Jan 21, 2013 at 5:07 AM, Steffen Trumtrar
> > <s.trumtrar@pengutronix.de> wrote:
> > > Hi!
> > >
> > > There was still no maintainer, that commented, ack'd, nack'd, apply'd the
> > > series. So, this is just a resend.
> > > The patches were tested with:
> > >
> > >         - v15 on Tegra by Thierry
> > >         - sh-mobile-lcdcfb by Laurent
> > >         - MX53QSB by Marek
> > >         - Exynos: smdk5250 by Leela
> > >         - AM335X EVM & AM335X EVM-SK by Afzal
> > >         - imx6q: sabrelite, sabresd by Philipp and me
> > >         - imx53: tqma53/mba53 by me
> >
> >
> > btw, you can add my tested-by for this series..  I've been using them
> > for the tilcdc lcd-panel output driver support.
> >
> 
> Thanks. The more drivers the merrier ;-)
> 
> Steffen
> 
> > >
> > >
> > > Changes since v15:
> > >         - move include/linux/{videomode,display_timing}.h to include/video
> > >         - move include/linux/of_{videomode,display_timing}.h to include/video
> > >         - reimplement flags: add VESA flags and data flags
> > >         - let pixelclock in struct videomode be unsigned long
> > >         - rename of_display_timings_exists to of_display_timings_exist
> > >         - revise logging/error messages: replace __func__ with np->full_name
> > >         - rename pixelclk-inverted to pixelclk-active
> > >         - revise comments in code
> > >
> > > Changes since v14:
> > >         - fix "const struct *" warning
> > >                 (reported by: Leela Krishna Amudala <l.krishna@samsung.com>)
> > >         - return -EINVAL when htotal or vtotal are zero
> > >         - remove unreachable code in of_get_display_timings
> > >         - include headers in .c files and not implicit in .h
> > >         - sort includes alphabetically
> > >         - fix lower/uppercase in binding documentation
> > >         - rebase onto v3.7-rc7
> > >
> > > Changes since v13:
> > >         - fix "const struct *" warning
> > >                 (reported by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>)
> > >         - prevent division by zero in fb_videomode_from_videomode
> > >
> > > Changes since v12:
> > >         - rename struct display_timing to via_display_timing in via subsystem
> > >         - fix refreshrate calculation
> > >         - fix "const struct *" warnings
> > >                 (reported by: Manjunathappa, Prakash <prakash.pm@ti.com>)
> > >         - some CodingStyle fixes
> > >         - rewrite parts of commit messages and display-timings.txt
> > >         - let display_timing_get_value get all values instead of just typical
> > >
> > > Changes since v11:
> > >         - make pointers const where applicable
> > >         - add reviewed-by Laurent Pinchart
> > >
> > > Changes since v10:
> > >         - fix function name (drm_)display_mode_from_videomode
> > >         - add acked-by, reviewed-by, tested-by
> > >
> > > Changes since v9:
> > >         - don't leak memory when previous timings were correct
> > >         - CodingStyle fixes
> > >         - move blank lines around
> > >
> > > Changes since v8:
> > >         - fix memory leaks
> > >         - change API to be more consistent (foo_from_bar(struct bar, struct foo))
> > >         - include headers were necessary
> > >         - misc minor bugfixes
> > >
> > > Changes since v7:
> > >         - move of_xxx to drivers/video
> > >         - remove non-binding documentation from display-timings.txt
> > >         - squash display_timings and videomode in one patch
> > >         - misc minor fixes
> > >
> > > Changes since v6:
> > >         - get rid of some empty lines etc.
> > >         - move functions to their subsystems
> > >         - split of_ from non-of_ functions
> > >         - add at least some kerneldoc to some functions
> > >
> > > Changes since v5:
> > >         - removed all display stuff and just describe timings
> > >
> > > Changes since v4:
> > >         - refactored functions
> > >
> > > Changes since v3:
> > >         - print error messages
> > >         - free alloced memory
> > >         - general cleanup
> > >
> > > Changes since v2:
> > >         - use hardware-near property-names
> > >         - provide a videomode structure
> > >         - allow ranges for all properties (<min,typ,max>)
> > >         - functions to get display_mode or fb_videomode
> > >
> > >
> > > Regards,
> > > Steffen
> > >
> > >
> > > Steffen Trumtrar (7):
> > >   viafb: rename display_timing to via_display_timing
> > >   video: add display_timing and videomode
> > >   video: add of helper for display timings/videomode
> > >   fbmon: add videomode helpers
> > >   fbmon: add of_videomode helpers
> > >   drm_modes: add videomode helpers
> > >   drm_modes: add of_videomode helpers
> > >
> > >  .../devicetree/bindings/video/display-timing.txt   |  109 +++++++++
> > >  drivers/gpu/drm/drm_modes.c                        |   70 ++++++
> > >  drivers/video/Kconfig                              |   21 ++
> > >  drivers/video/Makefile                             |    4 +
> > >  drivers/video/display_timing.c                     |   24 ++
> > >  drivers/video/fbmon.c                              |   94 ++++++++
> > >  drivers/video/of_display_timing.c                  |  239 ++++++++++++++++++++
> > >  drivers/video/of_videomode.c                       |   54 +++++
> > >  drivers/video/via/hw.c                             |    6 +-
> > >  drivers/video/via/hw.h                             |    2 +-
> > >  drivers/video/via/lcd.c                            |    2 +-
> > >  drivers/video/via/share.h                          |    2 +-
> > >  drivers/video/via/via_modesetting.c                |    8 +-
> > >  drivers/video/via/via_modesetting.h                |    6 +-
> > >  drivers/video/videomode.c                          |   39 ++++
> > >  include/drm/drmP.h                                 |    9 +
> > >  include/linux/fb.h                                 |    8 +
> > >  include/video/display_timing.h                     |  124 ++++++++++
> > >  include/video/of_display_timing.h                  |   20 ++
> > >  include/video/of_videomode.h                       |   18 ++
> > >  include/video/videomode.h                          |   48 ++++
> > >  21 files changed, 894 insertions(+), 13 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/video/display-timing.txt
> > >  create mode 100644 drivers/video/display_timing.c
> > >  create mode 100644 drivers/video/of_display_timing.c
> > >  create mode 100644 drivers/video/of_videomode.c
> > >  create mode 100644 drivers/video/videomode.c
> > >  create mode 100644 include/video/display_timing.h
> > >  create mode 100644 include/video/of_display_timing.h
> > >  create mode 100644 include/video/of_videomode.h
> > >  create mode 100644 include/video/videomode.h
> > >
> > > --
> > > 1.7.10.4
> > >
> >
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-02-01  7:40 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-01  7:40 [PATCH v16 RESEND 0/7] of: add display helper Jingoo Han
  -- strict thread matches above, loose matches on Subject: below --
2013-01-21 11:07 Steffen Trumtrar
2013-01-22 21:50 ` Rob Clark
2013-01-23  9:12   ` Steffen Trumtrar
2013-01-24  0:15     ` Dave Airlie
2013-01-24  7:56       ` Steffen Trumtrar
     [not found]     ` <20130123091202.GA11828-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-01-24  5:14       ` Leela Krishna Amudala
2013-01-24  8:19         ` Steffen Trumtrar
2013-01-24  8:47           ` Mohammed, Afzal
2013-01-25  8:04             ` Steffen Trumtrar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).