From: Rob Herring <robh@kernel.org>
To: Matt Johnston <matt@codeconstruct.com.au>
Cc: Wolfram Sang <wsa@kernel.org>,
devicetree@vger.kernel.org, Jeremy Kerr <jk@codeconstruct.com.au>
Subject: Re: [RFC PATCH 2/2] dt-bindings: net: Add mctp-i2c bus-attach property
Date: Mon, 02 Aug 2021 07:39:43 -0600 [thread overview]
Message-ID: <1627911583.098664.918767.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210802040458.334732-3-matt@codeconstruct.com.au>
On Mon, 02 Aug 2021 12:04:58 +0800, Matt Johnston wrote:
> Allows attaching multiple child busses in a mux topology
> to an mctp-i2c instance on the root bus. In general I2C
> slave mode does not make sense for mux busses, but the MCTP
> request/response protocol means the the root can switch
> between child muxes for incoming I2C messages.
>
> Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
> ---
> .../devicetree/bindings/net/mctp-i2c.yaml | 42 +++++++++++++++++--
> 1 file changed, 38 insertions(+), 4 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/mctp-i2c.example.dt.yaml:0:0: /example-0/i2cmux0: failed to match any schema with compatible: ['i2c-mux-gpio']
\ndoc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1512253
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-08-02 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 4:04 [RFC PATCH 0/2] MCTP I2C devicetree binding Matt Johnston
2021-08-02 4:04 ` [RFC PATCH 1/2] dt-bindings: net: New binding for mctp-i2c Matt Johnston
2021-08-02 16:45 ` Rob Herring
2021-08-11 3:39 ` Matt Johnston
2021-08-13 16:29 ` Rob Herring
2021-08-02 4:04 ` [RFC PATCH 2/2] dt-bindings: net: Add mctp-i2c bus-attach property Matt Johnston
2021-08-02 13:39 ` Rob Herring [this message]
2021-08-02 19:26 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1627911583.098664.918767.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=matt@codeconstruct.com.au \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).