From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Ding, Shenghao" <shenghao-ding@ti.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"Lu, Kevin" <kevin-lu@ti.com>, "Xu, Baojun" <baojun.xu@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"13916275206@139.com" <13916275206@139.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>,
"soyer@irl.hu" <soyer@irl.hu>, "tiwai@suse.de" <tiwai@suse.de>,
"Gupta, Peeyush" <peeyush@ti.com>,
"Navada Kanyana, Mukund" <navada@ti.com>
Subject: Re: [EXTERNAL] Re: [PATCH v4 1/4] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml
Date: Wed, 3 Jan 2024 17:09:29 +0100 [thread overview]
Message-ID: <1628a536-1c0b-4c80-b84a-41c290052da2@linaro.org> (raw)
In-Reply-To: <6ae4809eca654fa49929fc81720a0687@ti.com>
On 03/01/2024 16:10, Ding, Shenghao wrote:
>>> - reg:
>>> - description:
>>> - I2C address, in multiple tas2781s case, all the i2c address
>>> - aggregate as one Audio Device to support multiple audio slots.
>>> - maxItems: 8
>>> - minItems: 1
>>> - items:
>>> - minimum: 0x38
>>> - maximum: 0x3f
>>> + description: |
>>> + ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
>>> + DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
>>> +
>>> + ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
>>> + Protection and Audio Processing, 16/20/24/32bit stereo I2S or
>>> + multichannel TDM.
>>> + oneOf:
>>> + - items:
>>> + - enum:
>>> + - ti,tas2563
>>> + - const: ti,tas2781
>>> + - enum:
>>> + - ti,tas2781
>>> +
>>> + reg: true
>>
>> min/maxItems must stay here
>>
>> I already reminded this in v3.
> How to express maxItems is 4 for tas2563 on the same i2c bus(only 4 different i2c addresses)
> and maxItems is 8 for tas2781 on the same i2c bus (8 different i2c addresses) here.
Here you have only the widest constraints. In allOf:if:then you
customize them.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-01-03 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 15:30 [PATCH v4 1/4] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Shenghao Ding
2023-12-28 15:30 ` [PATCH v4 2/4] ASoC: tas2562: move tas2563 from tas2562 driver to tas2781 driver Shenghao Ding
2023-12-28 15:30 ` [PATCH v4 3/4] ASoC: tas2781: Add tas2563 into header file for DSP mode Shenghao Ding
2023-12-28 15:30 ` [PATCH v4 4/4] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2024-01-03 7:38 ` [PATCH v4 1/4] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Krzysztof Kozlowski
2024-01-03 15:10 ` [EXTERNAL] " Ding, Shenghao
2024-01-03 16:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628a536-1c0b-4c80-b84a-41c290052da2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).