From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18788276038; Tue, 11 Aug 2026 06:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786429102; cv=none; b=iRXETan45Dy7n4HxWZg4xJmtA5bZCtaDFonhMTvSQ9a4zXjCtJISO6Nu1PoQOdQzw4dt1Su+w3TdDd6AEgZwfPOOwqhEpyFWeQyjzDoTGJf/QkY5L4YNrc4wQFBCmqXE7Hg+ZLHUo7obm1+u/fYvcRfHRoPk23yABLa8c8mSR50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786429102; c=relaxed/simple; bh=Hse8OrdKiaeVNAsQHgOELN+1/U5JCEy6XSg9qioxC8k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kMQWdfeoUq/oaw08iJvz3TOOXVmMHCJ/wf3+D0x0gUFHfLdyfcCZt9L6BQMgn4vNYXmz2bBdWcuNIWRI6Zs2+MCCE/YUdFb3hlXnOzNhqAiHLt9/PckjdnGgYR1XFk7trFMm8aUH9ic40Bf/bsC7OvXhk9uxJFiOqVfP8cExTB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E0fqkw5V; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E0fqkw5V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EC9D1F000E9; Tue, 11 Aug 2026 06:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786429100; bh=fypE+WJeEIwmW1JOycblonvFMefcQW9eNEyTfiP9ohc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=E0fqkw5VDWriCOcHexkmUZM6UJ6MpPpB0wllgQLkIw1TZ7tmXXY6qZ+zydvb9UnYr NrvQsxIjT1AY0w4xaGZPzt4kkHBpxuDYEgtwjZkHFHvyVe8hnjpJHyfz6ug0n5l1uP KqZOtOxFYHYBbKVCUjqIS5GUncQfcCHf/Oo41QKr/cqdI6UM5AJRFgn2IEAY9fKU4y c1xrRLJRoy4pJXYscWNP7S9ogVgCAHQZ4Nvnseq5PPDMkYnckEIxME4bbNBT2vmL8J InkNFDdXxsOY4lTcYr6trbp5qZaItLjMhPv8fKxhd0GVWxeCDfOTZ8HWKIKYgJt2+g EgsBJyRt/JxPw== Message-ID: <162bfbf1-f8da-4083-96e9-2557688b0072@kernel.org> Date: Tue, 11 Aug 2026 08:18:13 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: phy: Add sa8255p high-speed USB PHY To: Mattijs Korpershoek Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260730-phy-qcom-snps-femto-v2-8255-v1-0-8b8bf5105a68@kernel.org> <20260730-phy-qcom-snps-femto-v2-8255-v1-1-8b8bf5105a68@kernel.org> <20260804-active-sensible-reindeer-f459a3@quoll> <87a4qu2f98.fsf@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <87a4qu2f98.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/08/2026 16:59, Mattijs Korpershoek wrote: >>> + power-domain-names: >>> + items: >>> + - const: transfer >>> + - const: core >> >> Here and in your other binding you call these 'transfer' and 'core' but >> all other bindings call them 'power' and 'perf'. Why this difference? > > Thanks for the question. I had to do some digging because I did not know > the answer to this. > > Per my understanding, the SCMI firmware (in my case, gearvm) exposes > multiple protocols identified by a protocol_id. > > For example, power domains have protocol_id=0x11 and and performance > domain have protocol_id=0x13. This is defined in ARM's den0056 spec: > https://support.arm.com/documentation/den0056/f/ > > Each USB phy has 2 distinct power domains. > This can be observed at runtime from linux via: > > /sys/kernel/debug/pm_genpd # grep 'scmi-power-usb0.*phy.*' pm_genpd_summary > scmi-power-usb0-ss-phy-pm off-0 0 > scmi-power-usb0-ss-phy-rpm off-0 0 > scmi-power-usb0-hs-phy-pm off-0 0 > scmi-power-usb0-hs-phy-rpm off-0 0 What about perf domains? > > In the case of the other bindings - for example i2c - there is only one > power domain (0x11) and one perf domain (protocol_id 0x13): > > /sys/kernel/debug/pm_genpd # grep i2c0 pm_genpd_summary > scmi-perf-i2c0_7 on 0 > scmi-power-i2c0 off-0 0 > > I hope that explains the naming difference. Please let me know if this > is still unclear. > >> What are these domains responsible for? > > If we take the example of the high-speed (hs) phy, we can see that on > the firmware side, the only difference is the -pm or -rpm suffix. > When Linux requests scmi-power-usb0-hs-phy-pm (mapped to 'core' in the > bindings), the SCMI firmware (gearvm) will interact with the reset line, > the clks and the regulator. > When requesting scmi-power-usb0-hs-phy-rpms (mapped to 'transfer' in the > bindings), the SCMI firmware will only interact with the USB clocks > (reset and regulators remain unchanged). > >> >> Commit msg is pretty useless here - repeats the diff. I can read the >> diff but I still do not understand why such naming. > > 'core' controls reset, clocks and regulators. > 'transfer' only controls clocks. Putting 'transfer' to 'off' is > interesting in case of runtime suspend/resume as it cuts the data > transfer (by disabling usb clock) Either the binding or the commit msg should be clear that these are power domains responsible only for power on SA platform, not for perf (so a power power domain... ehh :/) > > Is it more clear that way? > >> >> And why core is not the first one? It clearly feels like the power >> domain thus the main one. > > The order is based on how it's defined in the SCMI firmware. It's not a Then core goes before transfer. Best regards, Krzysztof