From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A40251CF68 for ; Wed, 23 Sep 2026 13:02:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790168558; cv=none; b=GR0WBFgsLe7pSJB8rYJ3+Vq6zlNsO1TMTHbs12jzw0V1cMYyK0WTF1LIUehe4VSxrYwoqtshGSTUOz07+hpL2GIp3zdEXEsGmP/LA0nfD7ABeE/3Px417lE+7fWTHYSNdm07jnOgfee39iYfSSksX0C18+dh+RZSJfduUpLQQ44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790168558; c=relaxed/simple; bh=aoukjc8PMMn3p0s9SeEc0oqDisI+Ii+3y99O6Pyf6wk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qpvZoXBhyGJUydJAA9TYWUKtTZhjYmwEjaYIc9kop5pKmGrjgXhQLki4uy6OKz+YKRTSAKq/gY/JkzSV4mrEqhiYDzXIF1nWOEanodGoGY1bxhb2MQrgyIe/uWWHUlMPXAgdjUSkD/WO9aO4CoG+I2XCuKQky8OPCw/jIVguEZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bbLHUTb2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FvRL/zFg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bbLHUTb2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FvRL/zFg" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68NBbVe6099118 for ; Wed, 23 Sep 2026 13:02:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rdm7/qh6VqpSPExRnuHdeR6FEt70qNeO121xfyLDFm0=; b=bbLHUTb27h3tcQxh QY6hr+EnRUkbJT52ZVejQfyYAfBeVJQfaLWOiJaZBpP6CHYNPytADaHI3LnxRVgY /vM7daIFwgoK1qtR/fJD3DzOdQfYEralGbJoIfm7HbNR67b1Jfghlxo2UCFnXRDC RU76YEu20sgUbAN1TWs0h9qBNdr2I8evB9vIALMBpi1biWNgshbgSDP44+DDenxn 9lAOQjLI9PaXHRfIbDe0/Sg2d7Q3hW2QePsY97FCiUKGZ6bmCsgz4ZtTYPVUJH7a PmwrlQTDAKz+F39TsA7pqs0m71PmKgwbi40AZinrHVTmnTaPw8pTAccROcwiRtEx /t2AhQ== Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gux8c4f0k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 23 Sep 2026 13:02:36 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-4c382ac3b8fso185908b6e.1 for ; Wed, 23 Sep 2026 06:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790168554; x=1790773354; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rdm7/qh6VqpSPExRnuHdeR6FEt70qNeO121xfyLDFm0=; b=FvRL/zFgTFmMk2Jzi+2xDb6T7N+hexEnrYkrtbOAiL6AgghvuoWWKTrNbm/LeSQbc5 bsvYGWqWtCV9jNmQZuv5p2i8A62/P5OEShEy4nxdoaPaw+eK6v7tztXEa5vTiMCpfe5t ACq29RZdrt1q/bgWKaT5QFgXIaDE3zuCE25ikKb07d/enfbYBF0F7zdH3fApAsXcZNWG zoO1bXMfZWniqUTrl8mXFDyXvH4Gk3qcGhx5M+AdsKPSweacdBIOgCu3CG2CzABP++MU Obu4hKNXikppAx2avGDgBY08bww0+0jR+jDcsf2tA40R8b41E9uYQraIS/cok8yQ0eCP choA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790168554; x=1790773354; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rdm7/qh6VqpSPExRnuHdeR6FEt70qNeO121xfyLDFm0=; b=1gL5eYqXoV7F/8R2jqH9VrZWfqQlNTavsLNw99GgJ5SJ+OE4ziaxIGUL5ld8mmUUf1 rBN3J0y3fL9Bgg7QDMsiwqI+JUT/mnrG39wKO7khtwa9SOX0YJ97967paxjQeCQ8RJOK oj+TdmvtIPXOF0o/1Zm1QVoShw49GnejyQHR/pgHPNBTZwcr/lxHxp/lm1rhK8b4e1gA s5Wr1ledEzdems7pFbN61qYDieLxPpu1oTPem1N7nhu4W/41WHtiiC36NgmOsr5N7/Nt jmytfjtBz8Pez79EYTnk5QMb5MjBoGL3eTms3JDixvrkZte8gn42gpV/GcQKDBzxs8AB ZPwA== X-Forwarded-Encrypted: i=1; AKwUvBzZ7rCWdAcoj0TkelwAzyxdC84LJHdGxpyNPw2MYP9RZah9YpymYxf+8ZK7lFPksYU0oHE9JJ4RneIR@vger.kernel.org X-Gm-Message-State: AFuF++lHZSlw/IWunqlHpksUSW6iJWvhKl9n9oo43XHbQpYDQpQpfHXN 7cZO3bgusEZIJExFq4gYxE3cqDRLEUVmYQ4zvhfN7U+MwL/EPNlTCNM+r0PrX318X5OTf/zN+Re up6vF6ZhW8VVrPwaTe9oitnD3yHgBw364X9BsfellzoYRNsfXR0JmxB1Y0aY4671Q X-Gm-Gg: AYBFou2Lk7DOnCb9HtxMCIK138E5TfsJhQ0zkAk8wvuvxQCH81TCVv/GnRZxbZ+oi+p JadYix0WFVDYZcW/pa7jO0248W4efiuEZ9UuLcnpbNdrS6MxdAVSjXYpFrJWZO+LLkpbzu/fgov zth9vHDns7r3coJjnlnjWFMxCMPBJ8zXGvthP+GMfWuVFp8rzGCszvyg0L/m+1LoDCTSgHGFZ7b WaAHYX2WvUgOEE5WDcQFSnZxW259KJc4Ghxr5QxA+SFfWv7FbmLhkJTTLEmbVJUbcUcMQ2PrXtu i0yEIjjDNiVRPdsiFKoc95TtIJA5JQzGVdeOyoWRV4D6pChFu2qpque6ke55mNHVXHcWl72xqHl 8Le9hQYe1qbS55PWkgTKFUg== X-Received: by 2002:a05:6808:118a:b0:4b5:7880:14ef with SMTP id 5614622812f47-4d5bb1321c1mr3001230b6e.6.1790168553541; Wed, 23 Sep 2026 06:02:33 -0700 (PDT) X-Received: by 2002:a05:6808:118a:b0:4b5:7880:14ef with SMTP id 5614622812f47-4d5bb1321c1mr3001170b6e.6.1790168553003; Wed, 23 Sep 2026 06:02:33 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2aae33ff75sm120445366b.9.2026.09.23.06.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 06:02:32 -0700 (PDT) Message-ID: <162d22c6-3558-48f7-a1c8-5337218e8e20@oss.qualcomm.com> Date: Wed, 23 Sep 2026 15:02:24 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH PRELIMINARY 2/5] arm64: dts: qcom: shikra: add ethernet nodes To: Mohd Ayaan Anwar , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Komal Bajaj , Anurag Pateriya , Dmitry Baryshkov , Richard Cochran , Andrew Lunn , Maxime Chevallier Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260908-shikra_ethernet_dts-v1-0-69c0c5c7c124@oss.qualcomm.com> <20260908-shikra_ethernet_dts-v1-2-69c0c5c7c124@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260908-shikra_ethernet_dts-v1-2-69c0c5c7c124@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIzMDA1MSBTYWx0ZWRfX/vA8hr2bZcB8 XaJu2Q2fkzv1NQZ57pBUdXotSLzH5lTkwIx668IjW4pFW806MIRo/iqbvDOVxMwCK61z5pS3vl8 XSgDgnVek6w294IFIWa+GBrIv3VBjJJX88XHgvLGErCLgf68XVyf5bHVcsIbkGLuYnm9IBSUmpW 1b3BHW43VlP1dvekI5Rj3/WlcDBF6l4BfInw8x+EPjV3OdGO781jKmddPYNkL3WLmwG0NAgiB7A 3v1bNBhuuJ9h8XzN3um/4aUDD2lBLEoadjDE15SbUtJEuTN7xqbLQhiW0yzeP9CveYfS6+T5wiO q63ETZUMPObnyLJv1EQdexGc9q2z0FqSTGpC1gUKV0ilf9lgX4RAo2I40eAkXdDCne/nDL+37OZ /q/jeuZbRb/0Xig5/Y5kZA05D52u6O40y/HaQlOL2cJ06qpKMeJVQBANWucq2xsPSRGvP8CKgpP zY1bTt8jPwy9wD3qTwg== X-Authority-Analysis: v=2.4 cv=P9evFSAu c=1 sm=1 tr=0 ts=6ab3cdec cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=osmAEHCOFALxNhKoBNcA:9 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 X-Proofpoint-ORIG-GUID: GzmxhU0vPzsDwUXrV7RlPnkwKsx3hTUd X-Proofpoint-GUID: GzmxhU0vPzsDwUXrV7RlPnkwKsx3hTUd X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIzMDA1MSBTYWx0ZWRfX1vvgPjB/wP7p zBfIe1nCuGP788QD3clZwRFhYRyqqLq5yQ4XlDSpZrLYbETFECYWvhvq4aQZGtYBnX1+17NVQqE szyw6nxgPrqL2Ez0c/QqAc/keHzjI9g= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-23_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609230051 On 9/8/26 8:23 AM, Mohd Ayaan Anwar wrote: > Add the two Gigabit Ethernet controllers present on Shikra (ethernet0 > at 0x5d00000, ethernet1 at 0x5d20000). Both nodes are left disabled; > board files supply the PHY details. > > Signed-off-by: Mohd Ayaan Anwar > --- [...] > + ethernet1: ethernet@5d20000 { > + compatible = "qcom,shikra-ethqos"; > + reg = <0x0 0x05d20000 0x0 0x10000>, > + <0x0 0x05d36000 0x0 0x100>; > + reg-names = "stmmaceth", "rgmii"; > + > + interrupts = ; > + interrupt-names = "macirq"; > + > + clocks = <&gcc GCC_EMAC1_AXI_CLK>, > + <&gcc GCC_EMAC1_AHB_CLK>, > + <&gcc GCC_EMAC1_PTP_CLK>, > + <&gcc GCC_EMAC1_RGMII_CLK>, > + <&gcc GCC_EMAC1_AXI_SYS_NOC_CLK>, > + <&gcc GCC_PCIE_TILE_AXI_SYS_NOC_CLK>; > + clock-names = "stmmaceth", "pclk", "ptp_ref", "rgmii", > + "axi-noc", "pcie-tile-axi-noc"; Ideally one a line, also for reg-anmes above and icc-names below Reviewed-by: Konrad Dybcio Konrad