[PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address

[PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address

[niravkumar.l.rabara]

From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>

Fix gpio0 controller address for Agilex5.

Fixes: 3f7c869e143a ("arm64: dts: socfpga: agilex5: Add gpio0 node and spi dma handshake id")
Cc: stable@vger.kernel.org
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index 51c6e19e40b8..9e4ef24c8318 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -222,7 +222,7 @@ i3c1: i3c@10da1000 {
 			status = "disabled";
 		};
 
-		gpio0: gpio@ffc03200 {
+		gpio0: gpio@10c03200 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0xffc03200 0x100>;
 			#address-cells = <1>;
-- 
2.25.1

Re: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address

[Krzysztof Kozlowski]

On 12/02/2025 11:01, niravkumar.l.rabara@intel.com wrote:
> From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> 
> Fix gpio0 controller address for Agilex5.

How do you fix it exactly?

> 
> Fixes: 3f7c869e143a ("arm64: dts: socfpga: agilex5: Add gpio0 node and spi dma handshake id")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> index 51c6e19e40b8..9e4ef24c8318 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> @@ -222,7 +222,7 @@ i3c1: i3c@10da1000 {
>  			status = "disabled";
>  		};
>  
> -		gpio0: gpio@ffc03200 {
> +		gpio0: gpio@10c03200 {

I see now warning. Are you sure you tested it according to
maintainer-soc-clean-dts profile?

>  			compatible = "snps,dw-apb-gpio";
>  			reg = <0xffc03200 0x100>;
>  			#address-cells = <1>;


Best regards,
Krzysztof

RE: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address

[Rabara, Niravkumar L]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Wednesday, 12 February, 2025 11:32 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@intel.com>; Dinh Nguyen
> <dinguyen@kernel.org>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>;
> nirav.rabara@altera.com; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Subject: Re: [PATCH] arm64: dts: socfpga: agilex5: fix gpio0 address
> 
> On 12/02/2025 11:01, niravkumar.l.rabara@intel.com wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> >
> > Fix gpio0 controller address for Agilex5.
> 
> How do you fix it exactly?

gpio0 address is incorrect here.  
0xffc03200 address is for Agilex7 not for Agilex5.
0x10c03200 is correct address for Agilex5. 
 
I will update the commit message.
"Fix incorrect gpio0 address for Agilex5".  

> 
> >
> > Fixes: 3f7c869e143a ("arm64: dts: socfpga: agilex5: Add gpio0 node and
> > spi dma handshake id")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> > ---
> >  arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > index 51c6e19e40b8..9e4ef24c8318 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > @@ -222,7 +222,7 @@ i3c1: i3c@10da1000 {
> >  			status = "disabled";
> >  		};
> >
> > -		gpio0: gpio@ffc03200 {
> > +		gpio0: gpio@10c03200 {
> 
> I see now warning. Are you sure you tested it according to maintainer-soc-
> clean-dts profile?
> 

My bad, I have submitted incorrect patch. 
It supposes to have these changes, I will update in v2.  

-               gpio0: gpio@ffc03200 {
+               gpio0: gpio@10c03200 {
                        compatible = "snps,dw-apb-gpio";
-                       reg = <0xffc03200 0x100>;
+                       reg = <0x10c03200 0x100>;

Thanks,
Nirav