From: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
To: <hminas@synopsys.com>, <gregkh@linuxfoundation.org>,
<robh+dt@kernel.org>, <alexandre.torgue@foss.st.com>
Cc: <balbi@kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>, <amelie.delaunay@foss.st.com>,
<fabrice.gasnier@foss.st.com>
Subject: [PATCH 0/3] usb: dwc2: fill in gadget caps, configure it for stm32mp15
Date: Wed, 15 Sep 2021 09:54:30 +0200 [thread overview]
Message-ID: <1631692473-8732-1-git-send-email-fabrice.gasnier@foss.st.com> (raw)
This patchset fills in 'otg_caps' of the usb_gadget structure, and configures it
on stm32mp15.
When dwc2 is configured as dual role (OTG), the USB gadget descriptors (device mode)
are configured via configfs. This lead in calling usb_otg_descriptor_init().
In usb_otg_descriptor_init() (drivers/usb/gadget/config.c):
- If otg caps structure is provided -> use it
- If otg caps structure isn't provided -> HNP and SRP are enabled by default
This could lead to a configuration mismatch beetween:
- OTG controller: HNP and SRP aren't enabled
- gadget descriptors: HNP and SRP are advertised
Fabrice Gasnier (3):
usb: dwc2: add otg_rev and otg_caps information for gadget driver
usb: dwc2: stm32mp15: set otg_rev
ARM: dts: stm32: set otg-rev on stm32mp151
arch/arm/boot/dts/stm32mp151.dtsi | 1 +
drivers/usb/dwc2/core.h | 7 +++++++
drivers/usb/dwc2/gadget.c | 1 +
drivers/usb/dwc2/params.c | 16 ++++++++++++++++
4 files changed, 25 insertions(+)
--
2.7.4
next reply other threads:[~2021-09-15 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 7:54 Fabrice Gasnier [this message]
2021-09-15 7:54 ` [PATCH 1/3] usb: dwc2: add otg_rev and otg_caps information for gadget driver Fabrice Gasnier
2021-10-01 11:10 ` Minas Harutyunyan
2021-10-06 6:27 ` gregkh
2021-09-15 7:54 ` [PATCH 2/3] usb: dwc2: stm32mp15: set otg_rev Fabrice Gasnier
2021-10-01 11:10 ` Minas Harutyunyan
2021-09-15 7:54 ` [PATCH 3/3] ARM: dts: stm32: set otg-rev on stm32mp151 Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1631692473-8732-1-git-send-email-fabrice.gasnier@foss.st.com \
--to=fabrice.gasnier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).