From: Rob Herring <robh@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
devicetree@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: net: wireless: qca,ath9k: convert to the json-schema
Date: Thu, 23 Sep 2021 17:37:43 -0500 [thread overview]
Message-ID: <1632436663.364411.3653402.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210923202029.575660-1-chunkeey@gmail.com>
On Thu, 23 Sep 2021 22:20:29 +0200, Christian Lamparter wrote:
> This replaces the existing .txt binding file. Furthermore, this
> also helps with validating DTS files.
>
> Introduced binding changes:
> 1. added inherited mac-address nvmem property
> 2. added inherited ieee80211-freq-limit property
> 3. added new calibration nvmem property
> 4. added second example (taken from the Netgear WNDR3700v2)
> Reason: Setting qca,no-eeprom; takes presedence over
> nvmem-cells. I think a different example is needed,
> because the driver can only reads from one calibration
> source per device.
> 5. (re-added) chip list (based on data from ath9k's pci.c)
>
> Added binding .yaml to MAINTAINERS.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
>
> ---
> v1 -> v2:
> - added second example (pci device - AR9220)
> - added commented chip list from the qca,ath9k.txt+ath9k's pci.c
>
> v2 -> v3:
> - forgot to include patch version in tag. Oops.
> (Please ignore the v2 with the missing v2 I just sent.)
>
> (I hope my changes didn't invalidate Rob's review there.
> I did run "make dt_binding_check" and no warning/error
> came up.)
> ---
> .../bindings/net/wireless/qca,ath9k.txt | 48 ----------
> .../bindings/net/wireless/qca,ath9k.yaml | 90 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 91 insertions(+), 48 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.txt
> create mode 100644 Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml:23:21: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1531944
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2021-09-23 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 20:20 [PATCH v3] dt-bindings: net: wireless: qca,ath9k: convert to the json-schema Christian Lamparter
2021-09-23 22:37 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1632436663.364411.3653402.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chunkeey@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).