From: Rob Herring <robh@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: devicetree@vger.kernel.org,
Oleksij Rempel <linux@rempel-privat.de>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding
Date: Fri, 01 Oct 2021 08:16:57 -0500 [thread overview]
Message-ID: <1633094217.893290.3666445.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211001000417.15334-3-leoyang.li@nxp.com>
On Thu, 30 Sep 2021 19:04:03 -0500, Li Yang wrote:
> When the binding was converted from txt to yaml, it actually added more
> constrains than the original txt binding which was already used in many
> in-tree DTSes. Some of the newly added constrains are either not valid
> or not neccessary.
>
> Not all SoCs use ipg as the clock name for i2c. There is no point in
> having SoC integration information defined in i2c binding. Remove the
> clock name requirement in the schema.
>
> The original txt binding didn't require the order of tx and rx for
> dmas/dma-names. Many in tree DTSes are already using the other order.
> Both orders should just work fine. Update the schema to allow both.
>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
> v2:
> Updated the patch description
>
> Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1535099
i2c@21a4000: clock-frequency:0:0: 50000 is not one of [100000, 400000]
arch/arm/boot/dts/imx6dl-alti6p.dt.yaml
i2c@21f8000: clock-frequency:0:0: 50000 is not one of [100000, 400000]
arch/arm/boot/dts/imx6dl-alti6p.dt.yaml
i2c@30a20000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml
i2c@30a30000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml
i2c@30a40000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml
i2c@30a50000: clock-frequency:0:0: 387000 is not one of [100000, 400000]
arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dt.yaml
next prev parent reply other threads:[~2021-10-01 13:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 0:04 [PATCH v2 00/16] Cleanup of LS1021a device trees Li Yang
2021-10-01 0:04 ` [PATCH v2 01/16] dt-bindings: arm: fsl: add ls1021a-tsn board Li Yang
2021-10-01 0:04 ` [PATCH v2 02/16] dt-bindings: i2c: imx: update schema to align with original txt binding Li Yang
2021-10-01 13:16 ` Rob Herring [this message]
2021-10-01 13:23 ` Rob Herring
2021-10-01 17:37 ` Li Yang
2021-10-08 22:20 ` Rob Herring
2021-10-09 3:08 ` Li Yang
2021-10-01 0:04 ` [PATCH v2 03/16] ARM: dts: ls1021a: change to use SPDX identifiers Li Yang
2021-10-01 0:04 ` [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI flash Li Yang
2021-10-01 5:24 ` [EXT] " Kuldeep Singh
2021-10-01 20:08 ` Li Yang
2021-10-04 5:53 ` Kuldeep Singh
2021-10-01 0:04 ` [PATCH v2 05/16] ARM: dts: ls1021a: update pcie nodes for dt-schema check Li Yang
2021-10-01 0:04 ` [PATCH v2 06/16] ARM: dts: ls1021a: fix board compatible to follow binding schema Li Yang
2021-10-01 0:04 ` [PATCH v2 07/16] ARM: dts: ls1021a: breakup long values in thermal node Li Yang
2021-10-01 0:04 ` [PATCH v2 08/16] ARM: dts: ls1021a: disable ifc node by default Li Yang
2021-10-01 0:04 ` [PATCH v2 09/16] ARM: dts: ls1021a: remove regulators simple-bus Li Yang
2021-10-01 0:04 ` [PATCH v2 10/16] ARM: dts: ls1021a: fix memory node for schema check Li Yang
2021-10-01 0:04 ` [PATCH v2 11/16] ARM: dts: ls1021a: add #dma-cells to qdma node Li Yang
2021-10-01 0:04 ` [PATCH v2 12/16] ARM: dts: ls1021a: add #power-domain-cells for power-controller node Li Yang
2021-10-01 0:04 ` [PATCH v2 13/16] ARM: dts: ls1021a-qds: change fpga to simple-mfd device Li Yang
2021-10-01 0:04 ` [PATCH v2 14/16] ARM: dts: ls1021a-tsn: remove undocumented property "position" from mma8452 node Li Yang
2021-10-01 0:04 ` [PATCH v2 15/16] ARM: dts: ls1021a: move thermal-zones node out of soc/ Li Yang
2021-10-01 0:04 ` [PATCH v2 16/16] ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash Li Yang
2021-10-01 5:14 ` [EXT] " Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1633094217.893290.3666445.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).