devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc: bgoswami@codeaurora.org,
	Venkata Prasad Potturu <potturu@codeaurora.org>,
	broonie@kernel.org, srinivas.kandagatla@linaro.org,
	plai@codeaurora.org, devicetree@vger.kernel.org, tiwai@suse.com,
	lgirdwood@gmail.com, swboyd@chromium.org,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	judyhsiao@chromium.org, agross@kernel.org,
	rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
	perex@perex.cz, robh+dt@kernel.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH 6/8] ASoC: dt-bindings: Add SC7280 sound card bindings
Date: Fri, 01 Oct 2021 14:03:37 -0500	[thread overview]
Message-ID: <1633115017.918117.4113070.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <1633087292-1378-7-git-send-email-srivasam@codeaurora.org>

On Fri, 01 Oct 2021 16:51:30 +0530, Srinivasa Rao Mandadapu wrote:
> Add bindings for lpass sc7280 based soundcards which supports
> audio over i2s based speaker, soundwire based headset, msm dmics
> and HDMI Port.
> 
> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  | 69 +++++++++++++++++++---
>  1 file changed, 61 insertions(+), 8 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml: allOf:3:then:properties:interrupt-names:anyOf:2:items: 'anyOf' conditional failed, one must be fixed:
	[{'const': 'lpass-irq-lpaif'}, 'lpass-irq-vaif', 'lpass-irq-rxtxif', 'lpass-irq-hdmi'] is not of type 'object', 'boolean'
	'lpass-irq-vaif' is not of type 'object', 'boolean'
	'lpass-irq-rxtxif' is not of type 'object', 'boolean'
	'lpass-irq-hdmi' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml: ignoring, error in schema: allOf: 3: then: properties: interrupt-names: anyOf: 2: items
warning: no schema found in file: ./Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml:0:0: /example-0/soc/lpass@62d80000: failed to match any schema with compatible: ['qcom,sc7180-lpass-cpu']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1535291

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2021-10-01 19:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-01 11:21 [PATCH 0/8] Add support for audio on SC7280 based targets Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 1/8] ASoC: qcom: Move lpass_pcm_data structure to lpass header Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 2/8] ASoC: qcom: lpass: Add dma fields for codec dma lpass interface Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 3/8] ASoC: qcom: Add register definition for codec rddma and wrdma Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 4/8] ASoC: qcom: Add lapss CPU driver for codec dma control Srinivasa Rao Mandadapu
2021-10-01 15:52   ` Matthias Kaehlcke
2021-10-04 15:50     ` Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 5/8] ASoC: qcom: Add support for codec dma driver Srinivasa Rao Mandadapu
2021-10-01 16:52   ` Matthias Kaehlcke
2021-10-04 17:01     ` Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 6/8] ASoC: dt-bindings: Add SC7280 sound card bindings Srinivasa Rao Mandadapu
2021-10-01 19:03   ` Rob Herring [this message]
2021-10-01 11:21 ` [PATCH 7/8] ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio Srinivasa Rao Mandadapu
2021-10-01 11:21 ` [PATCH 8/8] ASoc: qcom: lpass: Add suspend and resume for sc7280 platform Srinivasa Rao Mandadapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1633115017.918117.4113070.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=judyhsiao@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=plai@codeaurora.org \
    --cc=potturu@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=rohitkr@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=srivasam@codeaurora.org \
    --cc=swboyd@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).