devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@mailbox.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property
Date: Sun, 24 Oct 2021 09:27:27 -0500	[thread overview]
Message-ID: <1635085647.937250.2015034.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211023214856.30097-1-alexander.stein@mailbox.org>

On Sat, 23 Oct 2021 23:48:53 +0200, Alexander Stein wrote:
> Fixes the schema check warning "audio-controller@32000: 'AVDD-supply'
> do not match any of the regexes: 'pinctrl-[0-9]+'"
> 
> Fixes: 5c36abcd2621 ("ASoC: meson: add t9015 internal codec binding documentation")
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> I am aware that adding required properties to bindings is frowned upon. But in
> this case it seems acceptable for the following reasons:
> * AVDD-supply was used from the very first driver commit
> * All DT (g12 and gxl) using t9015 controller provide AVDD-supply
>   already
> But I'm ok to not add it to required properties as well. The driver uses
> it nevertheless though.
> 
>  Documentation/devicetree/bindings/sound/amlogic,t9015.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.example.dt.yaml: audio-controller@32000: 'AVDD-supply' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/amlogic,t9015.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1545246

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  parent reply	other threads:[~2021-10-24 14:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 21:48 [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Alexander Stein
2021-10-23 21:48 ` [PATCH 2/4] arm64: dts: amlogic: meson-g12: Fix thermal-zones indent Alexander Stein
2021-10-26  7:27   ` Neil Armstrong
2021-10-26 16:21     ` Alexander Stein
2021-10-23 21:48 ` [PATCH 3/4] arm64: dts: amlogic: meson-g12: Fix GPU operating point table node name Alexander Stein
2021-10-25  8:19   ` Neil Armstrong
2021-10-23 21:48 ` [PATCH 4/4] arm64: dts: amlogic: Fix SPI NOR flash node name for ODROID N2/N2+ Alexander Stein
2021-10-25  8:20   ` Neil Armstrong
2021-10-24 14:27 ` Rob Herring [this message]
2021-10-25  9:44 ` [PATCH 1/4] dt-bindings: sound: amlogic: t9015: Add missing AVDD-supply property Mark Brown
2021-10-25 15:53 ` Jerome Brunet
2021-10-26 16:30   ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1635085647.937250.2015034.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.stein@mailbox.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).