From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rong Zhang <i@rong.moe>, Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH 4/4] ARM: dts: qcom: msm8974: Add device tree for Samsung Galaxy S5 China
Date: Mon, 22 Jan 2024 11:50:54 +0100 [thread overview]
Message-ID: <1635b0e5-df47-4918-be83-edc27c59d8cf@linaro.org> (raw)
In-Reply-To: <20240121154010.168440-5-i@rong.moe>
On 21.01.2024 16:39, Rong Zhang wrote:
> This device has little difference compared to Samsung Galaxy S5 (klte),
> so the device tree is based on qcom-msm8974pro-samsung-klte.dts. The
> only difference is the gpio pins of i2c_led_gpio. With pins corrected,
> the LEDs and WiFi are able to work properly.
>
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
Looks like you didn't change the brcm,board-type though?
[...]
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-kltechn.dts
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "qcom-msm8974pro-samsung-klte.dts"
It's customary not to include .dts files, instead split the common parts
into e.g. qcom-msm8974pro-samsung-klte-common.dtsi and include this in
both the existing and the new one.
Konrad
next prev parent reply other threads:[~2024-01-22 10:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 15:39 [PATCH 0/4] ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support Rong Zhang
2024-01-21 15:39 ` [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led Rong Zhang
2024-01-22 9:48 ` Krzysztof Kozlowski
2024-01-22 14:54 ` Rong Zhang
2024-01-21 15:39 ` [PATCH 2/4] ARM: dts: qcom: msm8974-samsung-klte: Pin brcm,board-type in wifi Rong Zhang
2024-01-21 15:39 ` [PATCH 3/4] dt-bindings: arm: qcom: add Samsung Galaxy S5 China (kltechn) Rong Zhang
2024-01-22 9:47 ` Krzysztof Kozlowski
2024-01-21 15:39 ` [PATCH 4/4] ARM: dts: qcom: msm8974: Add device tree for Samsung Galaxy S5 China Rong Zhang
2024-01-22 9:48 ` Krzysztof Kozlowski
2024-01-22 14:51 ` Rong Zhang
2024-01-22 15:17 ` Krzysztof Kozlowski
2024-01-22 15:27 ` Rong Zhang
2024-01-22 10:50 ` Konrad Dybcio [this message]
2024-01-22 14:01 ` Icenowy Zheng
2024-01-22 17:37 ` Rong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1635b0e5-df47-4918-be83-edc27c59d8cf@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=i@rong.moe \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).