From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Subject: Re: [PATCH 1/5] dt-bindings: memory: tegra: Document #interconnect-cells property
Date: Fri, 12 Nov 2021 17:05:57 -0600 [thread overview]
Message-ID: <1636758357.459966.3548673.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211112130627.3682795-2-thierry.reding@gmail.com>
On Fri, 12 Nov 2021 14:06:23 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The #interconnect-cells properties are required to hook up memory
> clients to the MC/EMC in interconnects properties. Add a description for
> these properties.
>
> Also, allow multiple reg and interrupt entries required by Tegra194 and
> later.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../memory-controllers/nvidia,tegra186-mc.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.example.dt.yaml: memory-controller@2c00000: reg: [[0, 46137344, 0, 720896]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.example.dt.yaml: memory-controller@2c00000: interrupts: [[0, 223, 4]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.example.dt.yaml: memory-controller@2c00000: external-memory-controller@2c60000:reg: [[0, 46530560, 0, 327680]] is too short
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra186-mc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1554376
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-11-12 23:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:06 [PATCH 0/5] memory: tegra: Add Tegra234 support Thierry Reding
2021-11-12 13:06 ` [PATCH 1/5] dt-bindings: memory: tegra: Document #interconnect-cells property Thierry Reding
2021-11-12 23:05 ` Rob Herring [this message]
2021-11-23 19:53 ` Krzysztof Kozlowski
2021-11-12 13:06 ` [PATCH 2/5] dt-bindings: memory: tegra: Add Tegra234 support Thierry Reding
2021-11-29 21:00 ` Rob Herring
2021-11-12 13:06 ` [PATCH 3/5] " Thierry Reding
2021-11-12 13:06 ` [PATCH 4/5] arm64: tegra: Add memory controller on Tegra234 Thierry Reding
2021-11-12 13:06 ` [PATCH 5/5] arm64: tegra: Hook up MMC and BPMP to memory controller Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636758357.459966.3548673.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).