From: Rob Herring <robh@kernel.org>
To: Jayesh Choudhary <j-choudhary@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH v3] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema
Date: Sat, 27 Nov 2021 16:13:22 -0700 [thread overview]
Message-ID: <1638054802.120379.1973544.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211126050228.6257-1-j-choudhary@ti.com>
On Fri, 26 Nov 2021 10:32:28 +0530, Jayesh Choudhary wrote:
> Convert the bindings for McASP controllers for TI SOCs
> from txt to YAML schema.
>
> Adds additional properties 'clocks', 'clock-names', 'power-domains',
> '#sound-dai-cells', 'num-serializer' and 'port' which were not there
> in the txt file.
> Adds 'dmas' and 'dma-names' in the example which were not there in
> the txt file.
> Changes 'interrupts' and 'interrupt-names' from optional to
> required properties.
>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> Changelog:
> v3:
> - removes maxItems from 'clock-names'
>
> v2:
> - changes the commit message
> - modifies the properties 'clocks', 'clock-names', 'dma-names',
> 'dmas', 'interrupts' and 'interrupt-names' according to the
> arm SOCs
> - adds 'port' and 'num-serializer' as node properties
>
> .../bindings/sound/davinci-mcasp-audio.txt | 86 ---------
> .../bindings/sound/davinci-mcasp-audio.yaml | 178 ++++++++++++++++++
> 2 files changed, 178 insertions(+), 86 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt
> create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1559951
mcasp@0: 'rt-num-evt' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/am335x-wega-rdk.dt.yaml
mcasp@2b00000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b00000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b00000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b10000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b10000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b10000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b20000: 'op-mode' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b20000: 'serial-dir' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
mcasp@2b20000: 'tdm-slots' is a required property
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
next prev parent reply other threads:[~2021-11-27 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 5:02 [PATCH v3] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Jayesh Choudhary
2021-11-27 23:13 ` Rob Herring [this message]
2021-11-29 1:16 ` Rob Herring
2021-11-29 6:53 ` Péter Ujfalusi
2021-11-29 11:21 ` Jayesh Choudhary
2021-11-29 17:14 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638054802.120379.1973544.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-choudhary@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).