From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>, "Ray Jui" <rjui@broadcom.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Scott Branden" <sbranden@broadcom.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
bcm-kernel-feedback-list@broadcom.com,
"Doug Berger" <opendmb@gmail.com>
Subject: Re: [PATCH net-next 6/7] dt-bindings: net: Convert SYSTEMPORT to YAML
Date: Wed, 01 Dec 2021 08:33:22 -0600 [thread overview]
Message-ID: <1638369202.204682.1684346.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211201041228.32444-7-f.fainelli@gmail.com>
On Tue, 30 Nov 2021 20:12:27 -0800, Florian Fainelli wrote:
> Convert the Broadcom SYSTEMPORT Ethernet controller Device Tree binding
> to YAML.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/net/brcm,systemport.txt | 38 ---------
> .../bindings/net/brcm,systemport.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 84 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/brcm,systemport.txt
> create mode 100644 Documentation/devicetree/bindings/net/brcm,systemport.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: properties:interrupts: {'minItems': 2, 'maxItems': 3, 'items': [{'description': 'interrupt line for RX queues'}, {'description': 'interrupt line for TX queues'}, {'description': 'interrupt line for Wake-on-LAN'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/brcm,systemport.yaml: ignoring, error in schema: properties: interrupts
warning: no schema found in file: ./Documentation/devicetree/bindings/net/brcm,systemport.yaml
Documentation/devicetree/bindings/net/brcm,systemport.example.dt.yaml:0:0: /example-0/ethernet@f04a0000: failed to match any schema with compatible: ['brcm,systemport-v1.00']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1561999
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-12-01 14:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 4:12 [PATCH net-next 0/7] Broadcom DT bindings conversion to YAML Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 1/7] dt-bindings: net: brcm,unimac-mdio: reg-names is optional Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 2/7] dt-bindings: net: brcm,unimac-mdio: Update maintainers for binding Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 3/7] dt-bindings: net: Document moca PHY interface Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 17:15 ` Florian Fainelli
2021-12-01 18:28 ` Rob Herring
2021-12-01 4:12 ` [PATCH net-next 4/7] dt-bindings: net: Convert GENET binding to YAML Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 4:12 ` [PATCH net-next 5/7] dt-bindings: net: Convert AMAC " Florian Fainelli
2021-12-01 4:12 ` [PATCH net-next 6/7] dt-bindings: net: Convert SYSTEMPORT " Florian Fainelli
2021-12-01 14:33 ` Rob Herring [this message]
2021-12-01 4:12 ` [PATCH net-next 7/7] dt-bindings: net: Convert iProc MDIO mux " Florian Fainelli
2021-12-01 14:33 ` Rob Herring
2021-12-01 19:06 ` Rob Herring
2021-12-01 19:48 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1638369202.204682.1684346.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=rafal@milecki.pl \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).