From: Rob Herring <robh@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org,
Daniel Vetter <daniel.vetter@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema
Date: Fri, 17 Dec 2021 16:25:06 -0600 [thread overview]
Message-ID: <1639779906.571728.3686965.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20211217132502.95880-1-maxime@cerno.tech>
On Fri, 17 Dec 2021 14:25:01 +0100, Maxime Ripard wrote:
> The lvds.yaml file so far was both defining the generic LVDS properties
> (such as data-mapping) that could be used for any LVDS sink, but also
> the panel-lvds binding.
>
> That last binding was to describe LVDS panels simple enough, and had a
> number of other bindings using it as a base to specialise it further.
>
> However, this situation makes it fairly hard to extend and reuse both
> the generic parts, and the panel-lvds itself.
>
> Let's remove the panel-lvds parts and leave only the generic LVDS
> properties.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> ---
>
> Changes from v1:
> - Moved the schema out of panel
> ---
> .../bindings/display/{panel => }/lvds.yaml | 31 ++-----------------
> .../display/panel/advantech,idk-1110wr.yaml | 19 ++++++++++--
> .../display/panel/innolux,ee101ia-01d.yaml | 23 ++++++++++++--
> .../display/panel/mitsubishi,aa104xd12.yaml | 19 ++++++++++--
> .../display/panel/mitsubishi,aa121td01.yaml | 19 ++++++++++--
> .../display/panel/sgd,gktw70sdae4se.yaml | 19 ++++++++++--
> 6 files changed, 91 insertions(+), 39 deletions(-)
> rename Documentation/devicetree/bindings/display/{panel => }/lvds.yaml (86%)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml references a file that doesn't exist: Documentation/devicetree/bindings/display/panel/lvds.yaml
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/display/panel/lvds.yaml
Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml: Documentation/devicetree/bindings/display/panel/lvds.yaml
MAINTAINERS: Documentation/devicetree/bindings/display/panel/lvds.yaml
See https://patchwork.ozlabs.org/patch/1570028
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2021-12-17 22:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 13:25 [PATCH v2 1/2] dt-bindings: display: Turn lvds.yaml into a generic schema Maxime Ripard
2021-12-17 13:25 ` [PATCH v2 2/2] dt-bindings: panel: Introduce a panel-lvds binding Maxime Ripard
2021-12-17 22:25 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1639779906.571728.3686965.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox