From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 4/7] arm64: dts: renesas: condor: Enable MAX9286
Date: Mon, 17 Jan 2022 12:09:47 +0000 [thread overview]
Message-ID: <164242138750.10801.12504005374537076233@Monstersaurus> (raw)
In-Reply-To: <20211216163439.139579-5-jacopo+renesas@jmondi.org>
Quoting Jacopo Mondi (2021-12-16 16:34:36)
> Enable the MAX9286 GMSL deserializers on Condor-V3H board.
>
> Connected cameras should be defined in a device-tree overlay or included
> after these definitions.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
This looks good to me. It now enables the CSI2s, and the max9286 will
have no children. Will this create a completed media graph that simply
has no cameras connected? Or will the max9286 return a failure if there
are no devices attached.
I could look this up I guess, but I'm only curious of what potential
side effects there are of having a now successfully probed CSI2
receiver/VIN but without any cameras.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> .../boot/dts/renesas/r8a77980-condor.dts | 193 ++++++++++++++++++
> 1 file changed, 193 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> index 3d6d10c82f48..2eb2b852ddca 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> @@ -6,6 +6,8 @@
> * Copyright (C) 2018 Cogent Embedded, Inc.
> */
>
> +#include <dt-bindings/gpio/gpio.h>
> +
> /dts-v1/;
> #include "r8a77980.dtsi"
> #include <dt-bindings/gpio/gpio.h>
> @@ -108,6 +110,34 @@ channel0 {
> };
> };
>
> +&csi40 {
> + status = "okay";
> +
> + ports {
> + port@0 {
> + csi40_in: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&max9286_out0>;
> + };
> + };
> + };
> +};
> +
> +&csi41 {
> + status = "okay";
> +
> + ports {
> + port@0 {
> + csi41_in: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&max9286_out1>;
> + };
> + };
> + };
> +};
> +
> &du {
> clocks = <&cpg CPG_MOD 724>,
> <&x1_clk>;
> @@ -200,6 +230,164 @@ adv7511_out: endpoint {
> };
> };
>
> +&i2c1 {
> + pinctrl-0 = <&i2c1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + gmsl0: gmsl-deserializer@48 {
> + compatible = "maxim,max9286";
> + reg = <0x48>;
> +
> + maxim,gpio-poc = <0 GPIO_ACTIVE_LOW>;
> + enable-gpios = <&io_expander0 0 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + };
> +
> + port@2 {
> + reg = <2>;
> + };
> +
> + port@3 {
> + reg = <3>;
> + };
> +
> + port@4 {
> + reg = <4>;
> + max9286_out0: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi40_in>;
> + };
> + };
> + };
> +
> + i2c-mux {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + status = "disabled";
> + };
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> +
> + status = "disabled";
> + };
> +
> + i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <3>;
> +
> + status = "disabled";
> + };
> + };
> + };
> +
> + gmsl1: gmsl-deserializer@4a {
> + compatible = "maxim,max9286";
> + reg = <0x4a>;
> +
> + maxim,gpio-poc = <0 GPIO_ACTIVE_LOW>;
> + enable-gpios = <&io_expander1 0 GPIO_ACTIVE_HIGH>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + };
> +
> + port@2 {
> + reg = <2>;
> + };
> +
> + port@3 {
> + reg = <3>;
> + };
> +
> + port@4 {
> + reg = <4>;
> + max9286_out1: endpoint {
> + clock-lanes = <0>;
> + data-lanes = <1 2 3 4>;
> + remote-endpoint = <&csi41_in>;
> + };
> + };
> + };
> +
> + i2c-mux {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + i2c@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + status = "disabled";
> + };
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> +
> + status = "disabled";
> + };
> +
> + i2c@3 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <3>;
> +
> + status = "disabled";
> + };
> + };
> + };
> +};
> +
> &lvds0 {
> status = "okay";
>
> @@ -256,6 +444,11 @@ i2c0_pins: i2c0 {
> function = "i2c0";
> };
>
> + i2c1_pins: i2c1 {
> + groups = "i2c1";
> + function = "i2c1";
> + };
> +
> mmc_pins: mmc {
> groups = "mmc_data8", "mmc_ctrl", "mmc_ds";
> function = "mmc";
> --
> 2.33.1
>
next prev parent reply other threads:[~2022-01-17 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:34 [PATCH v8 0/7] arm64: dts: renesas: Enable MAX9286 on Eagle and Condor Jacopo Mondi
2021-12-16 16:34 ` [PATCH v8 1/7] dt-bindings: media: max9286: Re-indent example Jacopo Mondi
2021-12-16 16:34 ` [PATCH v8 2/7] dt-bindings: media: max9286: Define 'maxim,gpio-poc' Jacopo Mondi
2022-01-17 11:57 ` Kieran Bingham
2021-12-16 16:34 ` [PATCH v8 3/7] media: i2c: max9286: Use "maxim,gpio-poc" property Jacopo Mondi
2021-12-16 16:34 ` [PATCH v8 4/7] arm64: dts: renesas: condor: Enable MAX9286 Jacopo Mondi
2022-01-17 12:09 ` Kieran Bingham [this message]
2022-01-20 9:14 ` Geert Uytterhoeven
2022-01-20 10:25 ` Jacopo Mondi
2021-12-16 16:34 ` [PATCH v8 5/7] arm64: dts: renesas: eagle: " Jacopo Mondi
2022-01-17 12:00 ` Kieran Bingham
2022-01-20 9:22 ` Geert Uytterhoeven
2021-12-16 16:34 ` [PATCH v8 6/7] arm64: dts: renesas: Add GMSL cameras .dtsi Jacopo Mondi
2022-01-20 9:24 ` Geert Uytterhoeven
2021-12-16 16:34 ` [PATCH v8 7/7] DNI: arm64: dts: renesas: eagle: Include eagle-gmsl Jacopo Mondi
2021-12-17 14:30 ` [v8.1 3/7] media: i2c: max9286: Use "maxim,gpio-poc" property Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164242138750.10801.12504005374537076233@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox