From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: horms@verge.net.au, linux-sh@vger.kernel.org,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ian.campbell@citrix.com, devicetree@vger.kernel.org,
magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support
Date: Mon, 02 Sep 2013 15:14:37 +0200 [thread overview]
Message-ID: <1643070.uIkONXsrBj@avalon> (raw)
In-Reply-To: <201309010315.49763.sergei.shtylyov@cogentembedded.com>
Hi Sergei,
Thank you for the patch.
On Sunday 01 September 2013 03:15:48 Sergei Shtylyov wrote:
> Define the generic R8A777x part of the Ether device node.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> Index: renesas/arch/arm/boot/dts/r8a7778.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7778.dtsi
> @@ -98,4 +98,15 @@
> reg = <0xfffc000 0x118>;
> #gpio-range-cells = <3>;
> };
> +
> + ether: ethernet@fde00000 {
> + device_type = "network";
Documentation/devicetree/bindings/net/sh_eth.txt from "[PATCH 2/2] sh_eth: add
device tree support" doesn't document this property, should you update it ?
> + compatible = "renesas,ether-r8a7779";
> + reg = <0xfde00000 0x400>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 105 0x4>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-09-02 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201309010311.05466.sergei.shtylyov@cogentembedded.com>
2013-08-31 23:15 ` [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-02 13:14 ` Laurent Pinchart [this message]
2013-09-02 14:05 ` Sergei Shtylyov
2013-09-02 14:18 ` Laurent Pinchart
2013-09-02 15:32 ` Pawel Moll
2013-09-03 12:11 ` Laurent Pinchart
2013-09-03 13:53 ` Sergei Shtylyov
2013-09-03 15:17 ` Magnus Damm
2013-09-03 18:27 ` Sergei Shtylyov
2013-09-04 5:35 ` Magnus Damm
2013-09-04 9:39 ` Laurent Pinchart
2013-09-05 6:03 ` Simon Horman
2013-08-31 23:22 ` [PATCH 3/4] ARM: shmobile: bockw-reference: " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1643070.uIkONXsrBj@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).