devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Emma Anholt <emma@anholt.net>,
	bcm-kernel-feedback-list@broadcom.com,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Russell King <linux@armlinux.org.uk>,
	Scott Branden <sbranden@broadcom.com>,
	Will Deacon <will@kernel.org>, David Airlie <airlied@linux.ie>,
	linux-rpi-kernel@lists.infradead.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Ray Jui <rjui@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v4 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema
Date: Tue, 15 Feb 2022 09:22:45 -0600	[thread overview]
Message-ID: <1644938565.082103.3450863.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220213225646.67761-2-pbrobinson@gmail.com>

On Sun, 13 Feb 2022 22:56:33 +0000, Peter Robinson wrote:
> From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> 
> This converts the brcm,bcm2835-pm bindings from text to proper schema.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  .../bindings/soc/bcm/brcm,bcm2835-pm.txt      | 46 -----------
>  .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 79 +++++++++++++++++++
>  2 files changed, 79 insertions(+), 46 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml: properties:reg: {'minItems': 1, 'maxItems': 2, 'items': [{'description': 'PM registers'}, {'description': 'ASB registers'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml: ignoring, error in schema: properties: reg
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.example.dt.yaml:0:0: /example-0/watchdog@7e100000: failed to match any schema with compatible: ['brcm,bcm2835-pm', 'brcm,bcm2835-pm-wdt']
Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.example.dt.yaml:0:0: /example-0/watchdog@7e100000: failed to match any schema with compatible: ['brcm,bcm2835-pm', 'brcm,bcm2835-pm-wdt']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1592167

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2022-02-15 15:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13 22:56 [PATCH v4 00/15] Raspberry PI 4 V3D enablement Peter Robinson
2022-02-13 22:56 ` [PATCH v4 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema Peter Robinson
2022-02-15 15:22   ` Rob Herring [this message]
2022-02-13 22:56 ` [PATCH v4 02/15] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Peter Robinson
2022-02-13 22:56 ` [PATCH v4 03/15] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 Peter Robinson
2022-02-14 12:11   ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 04/15] ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node Peter Robinson
2022-02-13 22:56 ` [PATCH v4 05/15] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node Peter Robinson
2022-02-13 22:56 ` [PATCH v4 06/15] mfd: bcm2835-pm: Use 'reg-names' to get resources Peter Robinson
2022-02-13 22:56 ` [PATCH v4 07/15] mfd: bcm2835-pm: Add support for BCM2711 Peter Robinson
2022-02-19 15:21   ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 08/15] soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB Peter Robinson
2022-02-19 15:39   ` Stefan Wahren
2022-02-20 19:27     ` Peter Robinson
2022-02-20 21:14       ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 09/15] soc: bcm: bcm2835-power: Bypass power_on/off() calls Peter Robinson
2022-02-13 22:56 ` [PATCH v4 10/15] dt-bindings: gpu: v3d: Add BCM2711's compatible Peter Robinson
2022-02-13 22:56 ` [PATCH v4 11/15] drm/v3d: Get rid of pm code Peter Robinson
2022-02-13 22:56 ` [PATCH v4 12/15] drm/v3d: Add support for bcm2711 Peter Robinson
2022-02-24 19:56   ` Adrien Thierry
2022-02-13 22:56 ` [PATCH v4 13/15] ARM: dts: bcm2711: Enable V3D Peter Robinson
2022-02-19 15:43   ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 14/15] ARM: configs: Enable DRM_V3D Peter Robinson
2022-02-19 15:48   ` Stefan Wahren
2022-02-13 22:56 ` [PATCH v4 15/15] arm64: config: " Peter Robinson
2022-02-19 12:12 ` [PATCH v4 00/15] Raspberry PI 4 V3D enablement Stefan Wahren
2022-02-19 12:50   ` Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1644938565.082103.3450863.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=emma@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=nsaenz@kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=pbrobinson@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).