From: Rob Herring <robh@kernel.org>
To: Dmitry Antipov <daantipov@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Brown <broonie@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
linux-spi@vger.kernel.org, Dmitry Antipov <dmanti@microsoft.com>,
Felipe Balbi <balbi@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/6] Documentation: DT bindings for Microsoft G6 Touch Digitizer
Date: Fri, 25 Feb 2022 08:16:07 -0600 [thread overview]
Message-ID: <1645798567.332089.857887.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220225005936.3485405-4-dmanti@microsoft.com>
On Thu, 24 Feb 2022 16:59:33 -0800, Dmitry Antipov wrote:
> From: Dmitry Antipov <dmanti@microsoft.com>
>
> Documentation describes the required and optional properties for
> implementing Device Tree for a Microsoft G6 Touch Digitizer that
> supports HID over SPI Protocol 1.0 specification.
>
> Signed-off-by: Dmitry Antipov <dmanti@microsoft.com>
> ---
> .../input/microsoft,g6-touch-digitizer.yaml | 105 ++++++++++++++++++
> 1 file changed, 105 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.yaml:22:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dts:23.11-21: Warning (reg_format): /example-0/spi-hid-dev0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dts:21.22-37.11: Warning (unit_address_vs_reg): /example-0/spi-hid-dev0: node has a reg or ranges property, but no unit name
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/input/microsoft,g6-touch-digitizer.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1597405
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-02-25 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:59 [PATCH v4 0/6] Add spi-hid, transport for HID over SPI bus Dmitry Antipov
2022-02-25 0:59 ` [PATCH v4 1/6] HID: Add BUS_SPI support when printing out device info in hid_connect() Dmitry Antipov
2022-02-25 0:59 ` [PATCH v4 2/6] HID: define HID_SPI_DEVICE macro in hid.h Dmitry Antipov
2022-02-25 0:59 ` [PATCH v4 3/6] Documentation: DT bindings for Microsoft G6 Touch Digitizer Dmitry Antipov
2022-02-25 14:16 ` Rob Herring [this message]
2022-02-25 14:58 ` Rob Herring
2022-02-25 0:59 ` [PATCH v4 4/6] Documentation: Correction in HID output_report callback description Dmitry Antipov
2022-02-25 0:59 ` [PATCH v4 5/6] HID: add spi-hid, transport driver for HID over SPI bus Dmitry Antipov
2022-02-25 0:59 ` [PATCH v4 6/6] Defconfig: add CONFIG_SPI_HID=m Dmitry Antipov
-- strict thread matches above, loose matches on Subject: below --
2022-06-16 18:14 [PATCH v4 3/6] Documentation: DT bindings for Microsoft G6 Touch Digitizer Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1645798567.332089.857887.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=broonie@kernel.org \
--cc=daantipov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmanti@microsoft.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).