devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: devicetree@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Baruch Siach <baruch.siach@siklu.com>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	linux-arm-msm@vger.kernel.org,
	Robert Marko <robert.marko@sartura.hr>,
	netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible
Date: Sun, 27 Feb 2022 20:44:30 -0600	[thread overview]
Message-ID: <1646016270.923889.47194.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <e96e06d3228d9bbd927da32379ba78d5b4b718a7.1645949914.git.baruch@tkos.co.il>

On Sun, 27 Feb 2022 10:18:33 +0200, Baruch Siach wrote:
> From: Baruch Siach <baruch.siach@siklu.com>
> 
> The IPQ60xx MDIO bus is the same as IPQ4019.
> 
> Change 'enum' to 'items' list to allow fallback to older compatible
> strings.
> 
> Signed-off-by: Baruch Siach <baruch.siach@siklu.com>
> ---
> 
> v2:
> 
>   Update the schema to allow fallback compatible (Rob Herring)
> ---
>  Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: properties:compatible:items: 'anyOf' conditional failed, one must be fixed:
	['qcom,ipq4019-mdio', 'qcom,ipq5018-mdio', 'qcom,ipq6018-mdio'] is not of type 'object', 'boolean'
	'qcom,ipq4019-mdio' is not of type 'object', 'boolean'
	'qcom,ipq5018-mdio' is not of type 'object', 'boolean'
	'qcom,ipq6018-mdio' is not of type 'object', 'boolean'
	from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: ignoring, error in schema: properties: compatible: items
Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.example.dt.yaml:0:0: /example-0/mdio@90000: failed to match any schema with compatible: ['qcom,ipq4019-mdio']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1598217

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


      parent reply	other threads:[~2022-02-28  2:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-27  8:18 [PATCH v2 1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible Baruch Siach
2022-02-27  8:18 ` [PATCH v2 2/2] arm64: dts: qcom: ipq6018: Add mdio bus description Baruch Siach
2022-02-28  2:44 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1646016270.923889.47194.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=baruch.siach@siklu.com \
    --cc=baruch@tkos.co.il \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).