From: Rob Herring <robh@kernel.org>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: David Rhodes <drhodes@opensource.cirrus.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH v3 15/16] ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost
Date: Tue, 08 Mar 2022 15:24:39 -0600 [thread overview]
Message-ID: <1646774679.497272.1390766.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220308171730.454587-16-tanureal@opensource.cirrus.com>
On Tue, 08 Mar 2022 17:17:29 +0000, Lucas Tanure wrote:
> From: David Rhodes <drhodes@opensource.cirrus.com>
>
> Document internal and external boost feature for ASoC CS35L41.
> For internal boost the following properties are required:
> - cirrus,boost-peak-milliamp
> - cirrus,boost-ind-nanohenry
> - cirrus,boost-cap-microfarad
>
> For external boost, the GPIO1 must be configured as output,
> so the following properties are required:
> - cirrus,gpio1-src-select = <1>
> - cirrus,gpio1-output-enable
>
> Signed-off-by: David Rhodes <drhodes@opensource.cirrus.com>
> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
> ---
> .../bindings/sound/cirrus,cs35l41.yaml | 44 +++++++++++++++++--
> 1 file changed, 41 insertions(+), 3 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml:152:13: [warning] wrong indentation: expected 10 but found 12 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1603100
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-03-08 21:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 17:17 [PATCH v3 00/16] Support external boost at CS35l41 ASoC driver Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 01/16] sound: cs35l41: Unify hardware configuration Lucas Tanure
2022-03-10 13:44 ` Takashi Iwai
2022-03-10 16:40 ` tanureal
2022-03-10 16:43 ` Takashi Iwai
2022-03-08 17:17 ` [PATCH v3 02/16] sound: cs35l41: Check hw_config before using it Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 03/16] sound: cs35l41: Move cs35l41_gpio_config to shared lib Lucas Tanure
2022-03-10 13:40 ` Takashi Iwai
2022-03-08 17:17 ` [PATCH v3 04/16] ALSA: hda: cs35l41: Fix I2S params comments Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 05/16] ALSA: hda: cs35l41: Always configure the DAI Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 06/16] ALSA: hda: cs35l41: Add Boost type flag Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 07/16] hda: cs35l41: Put the device into safe mode for external boost Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 08/16] hda: cs35l41: Mute the device before shutdown Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 09/16] sound: cs35l41: Enable Internal Boost in shared lib Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 10/16] ALSA: hda: cs35l41: Move boost config to initialization code Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 11/16] ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 12/16] ALSA: hda: cs35l41: Reorganize log for playback actions Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 13/16] ALSA: hda: cs35l41: Handle all external boost setups the same way Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 14/16] ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use Lucas Tanure
2022-03-08 17:17 ` [PATCH v3 15/16] ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost Lucas Tanure
2022-03-08 21:24 ` Rob Herring [this message]
2022-03-09 1:20 ` Rob Herring
2022-03-09 9:28 ` Lucas tanure
2022-03-09 9:37 ` Charles Keepax
2022-03-08 17:17 ` [PATCH v3 16/16] ASoC: cs35l41: Support external boost Lucas Tanure
2022-03-09 9:36 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646774679.497272.1390766.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drhodes@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).