From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
<krzk+dt@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<peter.ujfalusi@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>
Cc: <oder_chiou@realtek.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, Sameer Pujar <spujar@nvidia.com>
Subject: [RFC PATCH v2 6/6] ASoC: tegra: Get clock rate in consumer mode
Date: Mon, 28 Mar 2022 11:44:10 +0530 [thread overview]
Message-ID: <1648448050-15237-7-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1648448050-15237-1-git-send-email-spujar@nvidia.com>
When Tegra I2S is consumer the clock is driven by the external codec.
In such cases, ideally the bit clock (BCLK) rate needs to be updated by
provider. Consumer can use standard clock function to get the rate.
On Tegra HW it is possible to use I2S BCLK clock as reference to the
I/O (other I2S or DMIC or DSPK) interfaces. This input clock is called
as SYNC input clock and it can act as a parent clock to any of the
remaining I/O interfaces. Thus it is important to set the clock rate
in Tegra I2S consumer mode as well.
With this patch SYNC input clock rate is updated and any I/O interface
relying on this can derive required rate.
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
Following are the DT binding cases I tried on Jetson AGX Xavier platform.
1. Sysclk derived from MCLK : This is currently being used. No DT
binding change would be necessary.
Clock tree dump snippet in this case with proposed series:
...
pll_a
|
|-- plla_out0
|
|-- ahub
|
|-- aud_mclk
| |
| |-- rt5659_sysclk
|
|-- i2s1
...
2. Sysclk is derived from codec internal PLL and this PLL uses I2S
bit clock (BCLK) as reference.
rt5658: audio-codec@1a {
...
clocks = <&bpmp TEGRA194_CLK_AUD_MCLK>,
<&bpmp TEGRA194_CLK_I2S1>,
<&bpmp TEGRA194_CLK_I2S1>,
<&rt5658 0>;
clock-names = "mclk", "bclk1", "pll_ref", "sysclk";
#clock-cells = <1>;
clock-output-names = "rt5659_pll_out";
...
};
Clock tree dump snippet in this case with proposed series:
...
pll_a
|
|-- plla_out0
|
|-- ahub
|
|-- aud_mclk
|
|-- i2s1
|
|-- rt5659_pll_ref
|
|-- rt5659_pll_out
|
|-- rt5659_sysclk
...
sound/soc/tegra/tegra210_i2s.c | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/sound/soc/tegra/tegra210_i2s.c b/sound/soc/tegra/tegra210_i2s.c
index 9552bbb..53e5307 100644
--- a/sound/soc/tegra/tegra210_i2s.c
+++ b/sound/soc/tegra/tegra210_i2s.c
@@ -53,17 +53,24 @@ static int tegra210_i2s_set_clock_rate(struct device *dev,
regmap_read(i2s->regmap, TEGRA210_I2S_CTRL, &val);
- /* No need to set rates if I2S is being operated in slave */
- if (!(val & I2S_CTRL_MASTER_EN))
- return 0;
-
- err = clk_set_rate(i2s->clk_i2s, clock_rate);
- if (err) {
- dev_err(dev, "can't set I2S bit clock rate %u, err: %d\n",
- clock_rate, err);
- return err;
+ /*
+ * If I2S is consumer, then the clock rate is expected to be
+ * set by the respective provider and thus just read the rate
+ * in such case. If I2S is provider, then set the clock rate.
+ */
+ if (!(val & I2S_CTRL_MASTER_EN)) {
+ clock_rate = clk_get_rate(i2s->clk_i2s);
+ } else {
+ err = clk_set_rate(i2s->clk_i2s, clock_rate);
+ if (err) {
+ dev_err(dev, "can't set I2S bit clock rate %u, err: %d\n",
+ clock_rate, err);
+ return err;
+ }
}
+ dev_dbg(dev, "bit clock (BCLK) rate is %u\n", clock_rate);
+
if (!IS_ERR(i2s->clk_sync_input)) {
/*
* Other I/O modules in AHUB can use i2s bclk as reference
--
2.7.4
prev parent reply other threads:[~2022-03-28 6:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 6:14 [RFC PATCH v2 0/6] Flexible codec clock configuration Sameer Pujar
2022-03-28 6:14 ` [RFC PATCH v2 1/6] ASoC: dt-bindings: Convert rt5659 bindings to YAML schema Sameer Pujar
2022-03-28 7:02 ` Krzysztof Kozlowski
2022-03-28 12:51 ` Rob Herring
2022-03-28 13:26 ` Sameer Pujar
2022-03-28 6:14 ` [RFC PATCH v2 2/6] ASoC: dt-bindings: Add audio-graph-port bindings to rt5659 Sameer Pujar
2022-03-28 7:03 ` Krzysztof Kozlowski
2022-03-28 7:58 ` Sameer Pujar
2022-03-28 6:14 ` [RFC PATCH v2 3/6] ASoC: dt-bindings: Extend clock bindings of rt5659 Sameer Pujar
2022-03-28 7:06 ` Krzysztof Kozlowski
2022-03-28 7:58 ` Sameer Pujar
2022-03-28 8:07 ` Krzysztof Kozlowski
2022-03-28 13:19 ` Sameer Pujar
2022-03-28 13:28 ` Krzysztof Kozlowski
2022-03-29 8:27 ` Sameer Pujar
2022-03-28 6:14 ` [RFC PATCH v2 4/6] ASoC: soc-pcm: tweak DPCM BE hw_param() call order Sameer Pujar
2022-03-28 15:11 ` Amadeusz Sławiński
2022-03-29 8:28 ` Sameer Pujar
2022-03-28 15:29 ` Ranjani Sridharan
2022-03-29 8:31 ` Sameer Pujar
2022-03-28 6:14 ` [RFC PATCH v2 5/6] ASoC: rt5659: Expose internal clock relationships Sameer Pujar
2022-03-28 6:14 ` Sameer Pujar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1648448050-15237-7-git-send-email-spujar@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).