From: Rob Herring <robh@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Ondrej Jirman <x@xff.cz>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: input: Add the PinePhone keyboard binding
Date: Mon, 18 Apr 2022 08:35:48 -0500 [thread overview]
Message-ID: <1650288948.488026.3125295.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220417021633.56127-2-samuel@sholland.org>
On Sat, 16 Apr 2022 21:16:29 -0500, Samuel Holland wrote:
> Add devicetree support for the PinePhone keyboard case, which provides a
> matrix keyboard interface and a proxied I2C bus.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> Changes in v2:
> - Drop keymap DT properties
> - Add vbat-supply property
>
> .../input/pine64,pinephone-keyboard.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml: 'additionalProperties' is a required property
hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties"
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.yaml: ignoring, error in schema:
Documentation/devicetree/bindings/input/pine64,pinephone-keyboard.example.dtb:0:0: /example-0/i2c/keyboard@15: failed to match any schema with compatible: ['pine64,pinephone-keyboard']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-04-18 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 2:16 [PATCH v2 0/4] Pine64 PinePhone keyboard support Samuel Holland
2022-04-17 2:16 ` [PATCH v2 1/4] dt-bindings: input: Add the PinePhone keyboard binding Samuel Holland
2022-04-18 12:24 ` Krzysztof Kozlowski
2022-04-18 13:35 ` Rob Herring [this message]
2022-04-17 2:16 ` [PATCH v2 2/4] Input: pinephone-keyboard - Add PinePhone keyboard driver Samuel Holland
2022-04-17 2:16 ` [PATCH v2 3/4] Input: pinephone-keyboard - Support the proxied I2C bus Samuel Holland
2022-04-17 2:16 ` [PATCH v2 4/4] [DO NOT MERGE] arm64: dts: allwinner: pinephone: Add keyboard Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1650288948.488026.3125295.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=x@xff.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).