devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: devicetree@vger.kernel.org, zac@squareup.com, krzk+dt@kernel.org,
	jun.nie@linaro.org, linux-arm-msm@vger.kernel.org,
	benl@squareup.com, robh+dt@kernel.org,
	bjorn.andersson@linaro.org, shawn.guo@linaro.org,
	jgates@squareup.com, mchen@squareup.com, jwillcox@squareup.com,
	agross@kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: arm: qcom: Document MSM8939 SoC binding
Date: Tue, 19 Apr 2022 07:12:43 -0500	[thread overview]
Message-ID: <1650370363.502202.1977861.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220419010903.3109514-2-bryan.odonoghue@linaro.org>

On Tue, 19 Apr 2022 02:09:00 +0100, Bryan O'Donoghue wrote:
> Document the MSM8939 and supported boards in upstream Sony "Tulip" M4 Aqua
> and Square APQ8039 T2.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/qcom.yaml:37:1: [error] syntax error: found character '\t' that cannot start any token (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/qcom.example.dts'
Traceback (most recent call last):
  File "/usr/local/bin/dt-extract-example", line 52, in <module>
    binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
    return constructor.get_single_data()
  File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
    node = self.composer.get_single_node()
  File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
  File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
  File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
  File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node
  File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a block scalar
  in "<unicode string>", line 12, column 14
found a tab character where an indentation space is expected
  in "<unicode string>", line 37, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/qcom.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/arm/qcom.yaml:  while scanning a block scalar
  in "<unicode string>", line 12, column 14
found a tab character where an indentation space is expected
  in "<unicode string>", line 37, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/qcom.yaml: ignoring, error parsing file
make: *** [Makefile:1401: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  parent reply	other threads:[~2022-04-19 12:13 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  1:08 [PATCH v1 0/4] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2022-04-19  1:09 ` [PATCH v1 1/4] dt-bindings: arm: qcom: Document MSM8939 SoC binding Bryan O'Donoghue
2022-04-19  7:13   ` Krzysztof Kozlowski
2022-04-19 12:12   ` Rob Herring [this message]
2022-04-19  1:09 ` [PATCH v1 2/4] arm64: dts: Add msm8939 SoC Bryan O'Donoghue
2022-04-19  7:33   ` Krzysztof Kozlowski
2022-04-19  8:30     ` Bryan O'Donoghue
2022-04-19  8:44       ` Krzysztof Kozlowski
2022-04-20  9:31     ` Jun Nie
2022-04-20  9:38       ` Krzysztof Kozlowski
2022-04-20  9:57         ` Jun Nie
2022-04-20 10:00           ` Jun Nie
2022-04-20 10:10             ` Krzysztof Kozlowski
2022-04-20 10:09           ` Krzysztof Kozlowski
2022-04-19 17:21   ` Vincent Knecht
2022-04-19 22:01     ` Bryan O'Donoghue
2022-05-26 13:32     ` Bryan O'Donoghue
2022-04-19 18:31   ` Stephan Gerhold
2022-04-20 10:12     ` Jun Nie
2022-04-19 18:47   ` Vincent Knecht
2022-04-19 21:11   ` Bjorn Andersson
2022-04-20  5:34     ` Stephan Gerhold
2022-04-19  1:09 ` [PATCH v1 3/4] arm64: dts: Add aqp8039-t2 board Bryan O'Donoghue
2022-04-19  7:35   ` Krzysztof Kozlowski
2022-04-19 19:20   ` Stephan Gerhold
2022-04-19 21:43     ` Bryan O'Donoghue
2022-04-19 21:39   ` Bjorn Andersson
2022-04-19 21:52     ` Bryan O'Donoghue
2022-04-19  1:09 ` [PATCH v1 4/4] arm64: dts: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2022-04-19 19:27   ` Stephan Gerhold
2022-04-19 22:03     ` Bryan O'Donoghue
2022-04-20  5:36       ` Stephan Gerhold
2022-05-26 22:03       ` Dmitry Baryshkov
2022-04-19 21:51   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1650370363.502202.1977861.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=benl@squareup.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jgates@squareup.com \
    --cc=jun.nie@linaro.org \
    --cc=jwillcox@squareup.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=mchen@squareup.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=zac@squareup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).