* [RESEND PATCH V6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional [not found] <1651108369-11059-1-git-send-email-quic_fenglinw@quicinc.com> @ 2022-04-28 1:12 ` Fenglin Wu 2022-04-29 22:30 ` Rob Herring 0 siblings, 1 reply; 5+ messages in thread From: Fenglin Wu @ 2022-04-28 1:12 UTC (permalink / raw) To: linux-arm-msm, linux-kernel, sboyd, Andy Gross, Bjorn Andersson, Rob Herring, devicetree Cc: quic_collinsd, quic_subbaram, quic_fenglinw, tglx, maz, David Collins From: David Collins <collinsd@codeaurora.org> Make all interrupt related properties as optional instead of required. Some boards do not required PMIC IRQ support and it isn't needed to handle SPMI bus transactions, so specify it as optional. Signed-off-by: David Collins <collinsd@codeaurora.org> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> --- Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml index 55d379c..fee4f0e 100644 --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml @@ -88,9 +88,6 @@ properties: required: - compatible - reg-names - - interrupts - - interrupt-names - - '#interrupt-cells' - qcom,ee - qcom,channel -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH V6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional 2022-04-28 1:12 ` [RESEND PATCH V6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional Fenglin Wu @ 2022-04-29 22:30 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2022-04-29 22:30 UTC (permalink / raw) To: Fenglin Wu Cc: quic_collinsd, tglx, linux-arm-msm, Bjorn Andersson, linux-kernel, quic_subbaram, devicetree, Andy Gross, David Collins, maz, Rob Herring, sboyd On Thu, 28 Apr 2022 09:12:47 +0800, Fenglin Wu wrote: > From: David Collins <collinsd@codeaurora.org> > > Make all interrupt related properties as optional instead of > required. Some boards do not required PMIC IRQ support and it > isn't needed to handle SPMI bus transactions, so specify it as > optional. > > Signed-off-by: David Collins <collinsd@codeaurora.org> > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 3 --- > 1 file changed, 3 deletions(-) > I just applied the dependent patch, so I've applied, thanks! ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <1655004286-11493-1-git-send-email-quic_fenglinw@quicinc.com>]
* [RESEND PATCH v6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional [not found] <1655004286-11493-1-git-send-email-quic_fenglinw@quicinc.com> @ 2022-06-12 3:24 ` Fenglin Wu 2022-08-31 17:36 ` Stephen Boyd 0 siblings, 1 reply; 5+ messages in thread From: Fenglin Wu @ 2022-06-12 3:24 UTC (permalink / raw) To: linux-arm-msm, linux-kernel, sboyd, Andy Gross, Bjorn Andersson, Rob Herring, devicetree Cc: quic_collinsd, quic_subbaram, quic_fenglinw, tglx, maz, David Collins From: David Collins <collinsd@codeaurora.org> Make all interrupt related properties as optional instead of required. Some boards do not required PMIC IRQ support and it isn't needed to handle SPMI bus transactions, so specify it as optional. Signed-off-by: David Collins <collinsd@codeaurora.org> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml index 55d379c..fee4f0e 100644 --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml @@ -88,9 +88,6 @@ properties: required: - compatible - reg-names - - interrupts - - interrupt-names - - '#interrupt-cells' - qcom,ee - qcom,channel -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH v6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional 2022-06-12 3:24 ` [RESEND PATCH v6 " Fenglin Wu @ 2022-08-31 17:36 ` Stephen Boyd 2022-09-02 11:41 ` Fenglin Wu 0 siblings, 1 reply; 5+ messages in thread From: Stephen Boyd @ 2022-08-31 17:36 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Fenglin Wu, Rob Herring, devicetree, linux-arm-msm, linux-kernel Cc: quic_collinsd, quic_subbaram, quic_fenglinw, tglx, maz, David Collins Quoting Fenglin Wu (2022-06-11 20:24:44) > From: David Collins <collinsd@codeaurora.org> > > Make all interrupt related properties as optional instead of > required. Some boards do not required PMIC IRQ support and it > isn't needed to handle SPMI bus transactions, so specify it as > optional. > > Signed-off-by: David Collins <collinsd@codeaurora.org> > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > index 55d379c..fee4f0e 100644 > --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml > @@ -88,9 +88,6 @@ properties: > required: > - compatible > - reg-names > - - interrupts > - - interrupt-names > - - '#interrupt-cells' Let me clarify my comment on the next driver patch here. It looks like we're making the properties optional here so that the driver can choose to create or not create the irqchip based on the presence of the property. Are there PMIC arbiters that don't have irq support? Or is it only that some board designs don't use interrupt support of the PMIC, because all the devices that use interrupts on the PMIC aren't enabled (status = "okay")? We shouldn't get into a situation where we're removing the interrupt properties because we want the driver to skip creating the irqchip. That makes the binding too loose, where we can't validate existing DT files. It also makes it confusing to include the DTS files when the device always supports interrupt capabilities, just we don't want to use it. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH v6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional 2022-08-31 17:36 ` Stephen Boyd @ 2022-09-02 11:41 ` Fenglin Wu 0 siblings, 0 replies; 5+ messages in thread From: Fenglin Wu @ 2022-09-02 11:41 UTC (permalink / raw) To: Stephen Boyd, Andy Gross, Bjorn Andersson, Rob Herring, devicetree, linux-arm-msm, linux-kernel Cc: quic_collinsd, quic_subbaram, tglx, maz, David Collins On 2022/9/1 1:36, Stephen Boyd wrote: > Quoting Fenglin Wu (2022-06-11 20:24:44) >> From: David Collins <collinsd@codeaurora.org> >> >> Make all interrupt related properties as optional instead of >> required. Some boards do not required PMIC IRQ support and it >> isn't needed to handle SPMI bus transactions, so specify it as >> optional. >> >> Signed-off-by: David Collins <collinsd@codeaurora.org> >> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >> index 55d379c..fee4f0e 100644 >> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml >> @@ -88,9 +88,6 @@ properties: >> required: >> - compatible >> - reg-names >> - - interrupts >> - - interrupt-names >> - - '#interrupt-cells' > > Let me clarify my comment on the next driver patch here. It looks like > we're making the properties optional here so that the driver can choose > to create or not create the irqchip based on the presence of the > property. Are there PMIC arbiters that don't have irq support? Or is it > only that some board designs don't use interrupt support of the PMIC, > because all the devices that use interrupts on the PMIC aren't enabled > (status = "okay")? > > We shouldn't get into a situation where we're removing the interrupt > properties because we want the driver to skip creating the irqchip. That > makes the binding too loose, where we can't validate existing DT files. > It also makes it confusing to include the DTS files when the device > always supports interrupt capabilities, just we don't want to use it. Thanks for reviewing the changes Stephen. I discussed with the change author David, he mentioned that these two changes were made for supporting trust VM features. In the design, there are two SPMI arbiter device instances, one is in non-secure world (with Linux Android) and the other is in secure world (with LE), both instances use the same SPMI arbiter driver but only the LA system handles the interrupt, and the irqchip will not be created for LE system to prevent any interrupt being fired and routed to the LA system. There are actually two other changes in SPMI driver made for the same secure VM feature. The driver exports a new API which would translate the SPMI address (SID+PID+OFFSET) into the SoC physical register address range that handles the SPMI write to the corresponding SPMI registers, and the secure system would do some protection on these registers to block any SPMI write from non-secure world when the secure feature is enabled. There will be 4 changes related in total, I will send them together with a new topic next time and you can help to review them after that. Thank you! ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-02 11:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1651108369-11059-1-git-send-email-quic_fenglinw@quicinc.com>
2022-04-28 1:12 ` [RESEND PATCH V6 08/10] dt-bindings: spmi: spmi-pmic-arb: make interrupt properties as optional Fenglin Wu
2022-04-29 22:30 ` Rob Herring
[not found] <1655004286-11493-1-git-send-email-quic_fenglinw@quicinc.com>
2022-06-12 3:24 ` [RESEND PATCH v6 " Fenglin Wu
2022-08-31 17:36 ` Stephen Boyd
2022-09-02 11:41 ` Fenglin Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).