From: Rob Herring <robh@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Sven Peter <sven@svenpeter.dev>, Hector Martin <marcan@marcan.st>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Kettenis <kettenis@openbsd.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property
Date: Thu, 26 May 2022 07:40:33 -0500 [thread overview]
Message-ID: <1653568833.758093.3797153.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220526014107.2871787-1-robh@kernel.org>
On Wed, 25 May 2022 20:41:07 -0500, Rob Herring wrote:
> The 'unevaluatedProperties' schema checks is not fully working and doesn't
> catch some cases where there's a $ref to another schema. A fix is pending,
> but results in new warnings in examples.
>
> The Apple PCIe host has 3 power domains at least according to the example.
> Add the 'power-domains' property to the schema.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Ideally, we'd define what each power domain is, but I don't know what
> they are.
> ---
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
pcie@690000000: power-domains: [[59]] is too short
arch/arm64/boot/dts/apple/t8103-j274.dtb
arch/arm64/boot/dts/apple/t8103-j293.dtb
arch/arm64/boot/dts/apple/t8103-j313.dtb
arch/arm64/boot/dts/apple/t8103-j456.dtb
arch/arm64/boot/dts/apple/t8103-j457.dtb
next prev parent reply other threads:[~2022-05-26 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:41 [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property Rob Herring
2022-05-26 12:40 ` Rob Herring [this message]
2022-05-26 13:48 ` Sven Peter
2022-05-26 21:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1653568833.758093.3797153.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).