From: Rob Herring <robh@kernel.org>
To: Harsh Agarwal <quic_harshq@quicinc.com>
Cc: linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
quic_pkondeti@quicinc.com,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
quic_ppratap@quicinc.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
quic_jackp@quicinc.com
Subject: Re: [PATCH 1/3] dt-bindings: usb: dwc3: Add support for multiport related properties
Date: Tue, 31 May 2022 08:21:25 -0500 [thread overview]
Message-ID: <1654003285.276061.1610157.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <1653985217-20953-2-git-send-email-quic_harshq@quicinc.com>
On Tue, 31 May 2022 13:50:15 +0530, Harsh Agarwal wrote:
> Added support for multiport, mport, num-ssphy and num-hsphy
> properties. These properties are used to support devices having
> a multiport controller.
>
> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
> ---
> .../devicetree/bindings/usb/snps,dwc3.yaml | 55 ++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:366:8: [warning] wrong indentation: expected 6 but found 7 (indentation)
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:367:10: [warning] wrong indentation: expected 11 but found 9 (indentation)
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:369:11: [warning] wrong indentation: expected 11 but found 10 (indentation)
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:86.27-89.15: Warning (unit_address_vs_reg): /example-2/usb@4a000000/multiport/mport@1: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:91.27-93.15: Warning (unit_address_vs_reg): /example-2/usb@4a000000/multiport/mport@2: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:95.27-97.15: Warning (unit_address_vs_reg): /example-2/usb@4a000000/multiport/mport@3: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/usb/snps,dwc3.example.dts:99.27-101.15: Warning (unit_address_vs_reg): /example-2/usb@4a000000/multiport/mport@4: node has a unit name, but no reg or ranges property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.example.dtb: usb@4a000000: multiport: 'mport' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-05-31 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 8:20 [PATCH 0/3] Add support for multiport controller Harsh Agarwal
2022-05-31 8:20 ` [PATCH 1/3] dt-bindings: usb: dwc3: Add support for multiport related properties Harsh Agarwal
2022-05-31 13:21 ` Rob Herring [this message]
2022-05-31 8:20 ` [PATCH 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle Harsh Agarwal
2022-05-31 10:20 ` kernel test robot
2022-05-31 8:20 ` [PATCH 3/3] usb: dwc3: Refactor PHY logic to support Multiport Controller Harsh Agarwal
2022-05-31 12:26 ` Pavan Kondeti
2022-06-05 18:29 ` Harsh Agarwal
2022-06-01 19:53 ` Andrew Halaney
2022-06-05 18:21 ` Harsh Agarwal
2022-06-06 13:04 ` Andrew Halaney
2022-06-08 14:29 ` Harsh Agarwal
2022-06-08 17:34 ` Harsh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654003285.276061.1610157.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_harshq@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).